Skip to contentSkip to conversation

at91: Add esd gmbh OTC570 board support

PATCH New Daniel Gorsulowski 3 participants 4 messages Jan 19, 2010 – Feb 2, 2010 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 at91: Add esd gmbh OTC570 board support

This patch adds support for esd gmbh OTC570 board. The OTC570 is based on an Atmel AT91SAM9263 SoC.

---
 MAINTAINERS                  |    1 +
 MAKEALL                      |    1 +
 Makefile                     |    3 +
 board/esd/otc570/Makefile    |   55 ++++++
 board/esd/otc570/config.mk   |    1 +
 board/esd/otc570/otc570.c    |  429 ++++++++++++++++++++++++++++++++++++++++++
 board/esd/otc570/partition.c |   37 ++++
 include/configs/otc570.h     |  247 ++++++++++++++++++++++++
 tools/Makefile               |    3 +
 tools/logos/esd.bmp          |  Bin 0 -> 35078 bytes
 10 files changed, 777 insertions(+), 0 deletions(-)
 create mode 100644 board/esd/otc570/Makefile
 create mode 100644 board/esd/otc570/config.mk
 create mode 100644 board/esd/otc570/otc570.c
 create mode 100644 board/esd/otc570/partition.c
 create mode 100644 include/configs/otc570.h
 create mode 100644 tools/logos/esd.bmp
MAINTAINERS +1 -0
index e8ba4bc..0c2b1b1 100644
@@ -574,6 +574,7 @@ Peter Figuli <[email protected]>
 Daniel Gorsulowski <[email protected]>
 
 	meesc		ARM926EJS (AT91SAM9263 SoC)
+	otc570		ARM926EJS (AT91SAM9263 SoC)
 
 Sedji Gaouaou<[email protected]>
 	at91sam9g10ek		ARM926EJS (AT91SAM9G10 SoC)
MAKEALL +1 -0
index dd635bd..eefd3dd 100755
@@ -654,6 +654,7 @@ LIST_at91="			\
 	meesc			\
 	mp2usb			\
 	m501sk			\
+	otc570			\
 	pm9261			\
 	pm9263			\
 	SBC35_A9G20		\
Makefile +3 -0
index 1ab197b..5fda1b9 100644
@@ -2862,6 +2862,9 @@ at91sam9g45ekes_config	:	unconfig
 	fi;
 	@$(MKCONFIG) -a at91sam9m10g45ek arm arm926ejs at91sam9m10g45ek atmel at91
 
+otc570_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs otc570 esd at91
+
 pm9263_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91
 
board/esd/otc570/Makefile new file +55 -0

55 lines not on this page · raw message

board/esd/otc570/config.mk new file +1 -0
new file mode 100644
index 0000000..ff2cfd1
@@ -0,0 +1 @@
+TEXT_BASE = 0x23f00000
board/esd/otc570/otc570.c new file +429 -0

429 lines not on this page · raw message

board/esd/otc570/partition.c new file +37 -0
new file mode 100644
index 0000000..df0e1db
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2008
+ * Ulf Samuelsson <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+#include <common.h>
+#include <config.h>
+#include <asm/hardware.h>
+#include <dataflash.h>
+
+AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS];
+
+struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS] = {
+	{CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0, 0},	/* Logical adress, CS */
+};
+
+/* define the area offsets */
+dataflash_protect_t area_list[NB_DATAFLASH_AREA] = {
+	{0x00000000, 0x000041FF, FLAG_PROTECT_SET,   0, "Bootstrap"},
+	{0x00004200, 0x000083FF, FLAG_PROTECT_CLEAR, 0, "Environment"},
+	{0x00008400, 0x00041FFF, FLAG_PROTECT_SET,   0, "U-Boot"},
+};
include/configs/otc570.h new file +247 -0

247 lines not on this page · raw message

tools/Makefile +3 -0
index 5b8c3c3..c91e19d 100644
@@ -102,6 +102,9 @@ endif
 ifeq ($(VENDOR),atmel)
 LOGO_BMP= logos/atmel.bmp
 endif
+ifeq ($(VENDOR),esd)
+LOGO_BMP= logos/esd.bmp
+endif
 ifeq ($(VENDOR),ronetix)
 LOGO_BMP= logos/ronetix.bmp
 endif
tools/logos/esd.bmp new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..a6b403024fbd92952c6fac576d215b49afdb6626
GIT binary patch

zcmeHQy>BDO6<^6@L|+U_;sGaGS5Q1L(1(GG1W9K|q-MoCRtC~s>DHx7mu}qzNSV at Y zngA(Nx(!kVH!66Z at zZke(#E+#S0&>+}WA;X5M at A=FRMUEZ_g>cYlsFyz4~KDMJ6o z^><ubQBTMJ_opa2{=K;n$pj5d?crw+R}X<bTtnUwF~l|IHS9%axQ2Us(Qvqj=RG{{ zMVGvfamRJb>ufK2kLz|kM0kksF#3kq<uLk)>s#J$amV%Xa*Xg8;c at gGulM8Vdt5*8 zi9q8^dqm2XVFi%{=)0qv*@q5e)@QcXI$T2;`uWAnfLE-$MrW}-(N=m!1YgDKYw?N zI9%V~BJLJ(xPG{ee!=xGUO(PO|H1XkkM9wFkMR5G*I$3#TpJyH at -|>Rfc?F>zP{G3 zVi$o+pLB?)Q~h*~(9p-@!JzLW;LwrBjm7AWXEEU7m3 at ABuK29Zc5Oueg3l+tQ_vqE zZi4&RAzu)AHtw3|-D~sI0m_+0DY|tZfP2T(Lj=^o;ho}XzR#yAqOV<a57DuHB6|GN z!~-QZqV~WDc~K_M=r&f$2ofJ_+*g}0EnX|h+;l7lMSQr1keRX=1Hl2sAgeM3V(M& zrD7^;%nWRfQAAZ3hVL1o<_Hp9O-(F?)(Y#AkNHf2Q%(GqfyH#XU?EzNsm55$HOs8e z&w(7HGl-zBCDxRB16m-q0mYMPe1e0gz*Lj?{@JJG6K=EKkwkh!86qouHrSc!T~L z;d^2*@&-hM8CaSufT&55IiaBXdn0ZVkd%ip#bLE1<IUkzn~bSDC(ReNum3rfzCS7 z)+tfr*FY%&vJk8J7g0oVZ$Vo#W)@$8a<1d81zGf+D1xd{urat!AHYJ8!(1D8Kfb>h zMaQ#yW!g}O5<x(%W6cgLoW(|@WqnLQY+B^){p|#~+yR4@7afyDlf=hd0JVbP7g2N> z$E<W?=i9I**mm5Hdd$Qd9MES59el7^xc00w?}J<0l(tQ2TU{*{bPRyjZ*eoNT1(~{ zIFZRVBu#*o3%&r?V1Ozu0TeKM2~Im~&tq_?IZdOlm|BoS{NYi1ed8-px+&!9y(P0 z$fMf=hA8>^)zE>iAFKPFIlIGwnApD^P?j(m1U?uAnCx74uM1)Hug+k;4Hg97SzI3 z1m(YFI~dSoXqUxW=tHbU7kQ{I_%M1#EnL!Y&!R>AunXeE!=V7m5r9@^SNmDoK0N^_ z;v>V#2*mG9Q2#;>Nao-H^@!S?n;Jssfi_qS;OQI&sN&v2&3Ctvjdoe&s2d^ca~S6| zIz<UujT(Id^!{AUyGdF^EckiumTF^bjW5#4is6qBF5w0jwatx8}zr*h3%(ESfQ~ zaUt9&<2Sw0j#1e-NS;k at N^?21^4Q+=qOhAZ&_h|MAIx#3q+@K1-i=<#l_<T!U!3_ z6t>l2^U9f%4pPlFxUeIg9dR%$zN&WuaSbr^c7<0N#O?(vJKA=r+;@)V-VE%T)3M3 z2V+4nhS_%11;dcwt+8tu+!q49gT~_w&SZQE{1Y7{!*^&Kqxsr)$x=I&J{qTw?X~< z3W6(BKQ~B$gy71WGt5J~ZH<s!?uJ{x(j3<&!IDN0t>?L4El%G0pLt~Ez<yi-ead6 z&ynF30<Mq5;~{u4j^ay0M{$fIkH@;%!wFfANNW9&=4=}h8#CIvM^At_GG{twZLr$& zY1Hh7^v(Tbg#BRfbI#jV3Z at KEtaJ_;%ijRYwgMDX#;du6k-8aK%c at S1|)<^w?U at J z05tmW0X4eCD!$u|y4n*v8HG(gEWo~Oqn(i?ND9X9=qU5eXg<cf0!FP(;l<KpZkK zU?;0berPqu!LVkp(fJwl9inSb$h#kufd@DO6{FDsLAxvTu4;Y<@rX#P(aj>B!$6rw z*g()pA0$?!!NCTA{Z~tkTFN{m<4NzW;~@Cdj$$bbI@$SE!oPZ^BA%dMqh5wb(JS| zZ!+JWYW_fFZJqtT2BkD5YDPz>cmSD0ql}_AIti+un-)d0X2lo-FnyvaCjEOkolbSz z>LFmd%qxUWaGCMx8A4j$Lj-P-W(=0-CSRflEhLJ*yj;xZb9Id7rQzT!Xn#JxKXJZk z_Z$d|i+;p0+#A8s?ui2G;w?=CaDcqcP;}r!CS^6hy}oRd-Tvps?YiQ7y3JGF#;>|~ z+&g_IZxH#sgY0Zg^*(PtE4f3jYKF&^n9my_8F)NzKC8H+*UvPNDxznYKEeco at vF~} zxeZGj4Qw>9(ZEIn8x3qUu+hLq19=+gA5PA%G1>H?6(}{mIzPrzb^#0*IoT>TyFQ;B z>Q}Ax at OVaFHSh)fkE{nVLlrdh=Mn$VmNtWrsJA%oxwi6hX_lMLT938n32i?=c@~V zg)1{DnWd{8)5E*XQe;TDoK4)+Ny5drybPqC7Sv>tM at gtNS?JlZgo)*Z%w$?nu$hf3 z&-}Qxb-ltASb5%UQ)gxl&P&3H&PoU;DmV502WLu^KOkGC*1VHR8?Net{2u|JwVyv zH06^4R!l at I8PzEXiQ~OFJQMQ$SK{Y1-sa880ge2>%O5N<UadnRRQlX}}W}w(Ehi zbG=3Sm+`w#*)$x(Y8uS)a;2mWs1FS~_+C!``UKUZ+-@2ukt;|Z%F0sVVyM)9<_Uy zK2IN5TunyFdUmtW(aGJyEY$eybRbzU*ZTlqFy*3O|GENEGJm0tOq%xgqumQ%2Y3x zG}gf>H+Kk7Zt)zroZNLV_qH=Q$q at OK>U06=XU^YCn2GHcY5e-nW2{)poD+q8ly{ z1bH6n9Y!t%cU8Ki<|(-rD?zL;dAv4(?J*bTLh#Grq4w-<8e78FC?!2t;;X^zSaW4z zeKK&5)znoOyXm&)#=pIg+0=5*i|a5EtR?NLusm+kNdTK-3Nc$INS+k-dl(QE<r|1i zOcALUm4&}cgkZ?2tCFrhg5KGclwuZ8%_a&To6(+M=QSwa9E*y55vqlo*q#8SKjgLv z!V5110@)T|_6b=W^-$$L1$wwo!W6cY-_#()R>-y(nq*#^WU}6RSi+2OR(8W<33|(< zUf2eGul_DH1-o%DC_u0#c5nnpE+~cvaaH9xs>b(8XhX5x5*GF#d2i%ldR4;}rdz|i zHI~2-aD!Rc5PF5%4FPBvHyWrx*z<ys|B&Xq!Ch-BwPLd;3Zi+EvogC)ti10q%C| zOp+)<VW(QY<4lk>f6!af99w!{F!B&Ruye;j-hxQ)O9~Q2kQ<RaWM(x4>LVYxRmg*F zhetjFpz?I?o0HLBdF(z<6VUU7y}*$IVcL;H?yU%36Rg1_8?wx4C)9v;Vs0A|1Pz z&IR;tKUYvPb7S{TxY;Yx0MRhuL-2pNG_7p(yjX3Htpf9W8dG!yQi;KDZD3d5^&Cm z8#6p)h9=-6w3mCHTryj%jn4S?*hWf_<9$@JK{!nwXh|KX+<ZTE1h>S+DMNj6GZMq z^pNcYd78sP;fBF1gv=4Y9(kl=ET<dptZ4K$by=D&)v+yx!)_y94Fa5f<(e8{WN% zgiS4P8k8HkJruvBipjUnoOH=uG!QqlxePg+(-3x(GuHlt7XpFe*Hlp-PTz?ba^t;g zAj^=$y-RVssfU~fBI+YMlys~LIr7ZUmw}GT8N)K<u&*G(u_}AGz%j>r&Gx}#9v<@E z1bKqQgWaaSM1N)Wq5A@|9Ef3Tj=@-&1xv1T3iTm|&Zj0tzTkK!ngpDQre1Ep3X9fZ zG0EjCF@qL%Y092w5J<v)-K=KlWSVfF;J)>RaQn80L_C-7lMwjeB6IFxe;Ma(gb&B{ zbDM#1GP8Frz#LLycAbzOr_&^iLOJpVkCP*jIh|&{#}~B3j?(~<-=jB-G44<miHju z;IpkKDM(anFr@VuVrXI~UvOM10q4a$#S#Ph6ofCTxS69!kHtXF3y2t+xEcJg^(}wi zE>T4IR-cTElJp>?Pv$ydawfZY5XFNV0foI&FWq9q~<|6VUlMpNuDFmBm+4WB8Dcm z1>xjOKxW->lIOBQq7$?y*NXBMJ$f?tnxKnUGIK&iTB9mG at RMZJI5Y^GVda#&6gtPU z0?q4_VB|-5tS37AkQ)9})q2>FVJNNVxT-RL12f at Vj@F5$zJ=8a3(l(8L*Ta6nwhl ze*vZ#nz*60m}jZI at D=1*72FmhJ9kW~j7rSCqDGQ2gP{tCCduSX*wAx$_lKLhA~`N zLhid_I-k?91%TXqe<8sVYtk;7M{*O$5;?qf_hC5y!D6af2a6Fdi$wF+Vxd<IO}u9o zLk3bwqIUcns@_>@QL$zpH3<7UaD?4U;ZREqP5j^<-&GKR$FhTp4dfCH(v(sBMl147 zwOZ27&b{VCjulVc8W;;P^uz4pwR>T8SPk#pBOLHeX~<7MR_7&G6)l5{yR+l*(b19E zgJ%wm>Ks$ceuiqUE>4a?)Er)qC+9PMI3NQ#omzoN9U4<T2&y=}qFgV7##rS8D=Cp! z%q}e{aLb*vS1BcInW$!sOtptk0 at NyL5h_5uPSzrCjFjHl7#5!w-pOfSxrOeB)Hk*5 zF*mQONOKB4EU-GfEf!6ROOUUZPr5g=<;acS!KeiFN2!ugeHT%gcLqV~Ocq@7)R&{0 zOtv~AJ$u=$S&#X-mBsQ)LG57cDA$3@!bAgMIT%USs7RSfji=)2^%}x;Q?)GLb7AF zt)n^>S)Qv%#kVfTVvJXV^9;%{y=k#5;$t?R_>dndC?*nImOn6@QWwDh~|Or8*)^{ zm7D!Z<-2{zH@G6Aa^6Mi^zhMDk+9Yqygs?Wft(yDUXbq&%qgB6qB>FfIL at F^_nk1j z32ij6(ZEIntJ1(1ht<$}oU$q*P)^>F2hpwI!B29mkgvu?WhRo+Qs4t%ev+ec?yDof zrx~jtnB-U;UrkFAdw&WfdejiODMKys>r8d5MFXj}tE$b&Ej74gGQ9azLf#&jCA0D9 z>@xG^Ia0lObSW#ypoZsNiw44PP*%YT)cNQla%S)|Vy%Pc<;PB|U@Z(wEYaplqrQ1 zt*;=1Pi1KGGPe$7WU&6S0?oE7VyDKm(ONW+8a>Foor+dVRqc84nb_5)T*>PLz9+k z39a~PO;lqm>RL1qv3EiD)&^j{k66JmQ7gQK+3l3FPoe8H8Klt_D)~VCB1gK~GIt zy-4SewLUc~kIKK!&}1EEe?FC=Nu3Wdt%c{U9=pf!IvAGRQk!yB_Oa0?e;(Cb+Y{Fq zny91p*{_T;JX(q8?jo822x{al6PwWs0s_P at M*{4ljirv0pgfwASLI at 2QRIIg+f& z&?JZRRFwYDp}L0pTj6~&Lz9Q<dET-!c)ykYGv!tfO;o(ZEkT*`mlZKewT8UMwHTUI z+tsqp1T0JSx%s$1Gs~+77q=Eelj<I%^8Y$>6}0L|apJ_)K<d5 at Llge<U=^&#(4 at Mh z*FO}pYHJG0t21j7pg-GSouP?8_w;O~z*holG?29znpAt<^%$De@w}BMZl8g{)tEJ@ xIFSAfgdhw2x8w>~hh3M?M4KBnHX7JyV55PJ2L3-ZkpAveD0Nv{h`0Li{{S%4%!vR1

literal 0
HcmV?d00001

Signature · 1 line
1.6.1
#1 lore raw

PATCH 1/1 at91: Add esd gmbh OTC570 board support

Quoted 4 lines · Daniel Gorsulowski

This patch adds support for esd gmbh OTC570 board. The OTC570 is based on an Atmel AT91SAM9263 SoC.

For u-boot-video.
Maybe some u-boot commands that could be common.

Quoted 4 lines
---
 MAINTAINERS                  |    1 +
 MAKEALL                      |    1 +
 Makefile                     |    3 +

<snip>

Quoted 6 lines
board/esd/otc570/otc570.c new file +0 -0
new file mode 100644
index 0000000..fee27ca

board/esd/otc570/otc570.c line 9

Quoted 9 lines
board/esd/otc570/otc570.c new file +9 -0
@@ -0,0 +1,429 @@
+/*
+ * (C) Copyright 2007-2008
+ * Stelian Pop <[email protected]>
+ * Lead Tech Design <www.leadtechdesign.com>
+ *
+ * (C) Copyright 2010
+ * Daniel Gorsulowski <[email protected]>
+ * esd electronic system design gmbh <www.esd.eu>
+ *

New copyrights before old
Swap places

Quoted 3 lines
board/esd/otc570/otc570.c new file +3 -0
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *

<snip>

Quoted 18 lines
board/esd/otc570/otc570.c new file +18 -0
+
+#ifdef CONFIG_CMD_NAND
+static void otc570_nand_hw_init(void)
+{
+	unsigned long csa;
+
+	/* Enable CS3 */
+	csa = at91_sys_read(AT91_MATRIX_EBI0CSA);
+	at91_sys_write(AT91_MATRIX_EBI0CSA,
+		csa | AT91_MATRIX_EBI0_CS3A_SMC_SMARTMEDIA);
+
+	/* Configure SMC CS3 for NAND/SmartMedia */
+	at91_sys_write(AT91_SMC_SETUP(3),
+		AT91_SMC_NWESETUP_(1) | AT91_SMC_NCS_WRSETUP_(0) |
+		AT91_SMC_NRDSETUP_(1) | AT91_SMC_NCS_RDSETUP_(0));
+	at91_sys_write(AT91_SMC_PULSE(3),
+		AT91_SMC_NWEPULSE_(3) | AT91_SMC_NCS_WRPULSE_(3) |
+		AT91_SMC_NRDPULSE_(3) | AT91_SMC_NCS_RDPULSE_(3));

board/esd/otc570/otc570.c line 98

Quoted 10 lines
board/esd/otc570/otc570.c new file +10 -0
+	at91_sys_write(AT91_SMC_CYCLE(3),
+		AT91_SMC_NWECYCLE_(5) | AT91_SMC_NRDCYCLE_(5));
+	at91_sys_write(AT91_SMC_MODE(3),
+		AT91_SMC_READMODE | AT91_SMC_WRITEMODE |
+		AT91_SMC_EXNWMODE_DISABLE |
+#ifdef CONFIG_SYS_NAND_DBW_16
+		AT91_SMC_DBW_16 |
+#else /* CONFIG_SYS_NAND_DBW_8 */
+		AT91_SMC_DBW_8 |
+#endif

I do not see where CONFIG_SYS_NAND_DBW_16 is ever set to 1 I see meesc has similar logic.

It looks like this #if-def can be removed.
Do this or add comment explaining.

board/esd/otc570/otc570.c line 108

Quoted 10 lines
board/esd/otc570/otc570.c new file +10 -0
+		AT91_SMC_TDF_(2));
+
+	/* Configure RDY/BSY */
+	at91_set_gpio_input(CONFIG_SYS_NAND_READY_PIN, 1);
+
+	/* Enable NandFlash */
+	at91_set_gpio_output(CONFIG_SYS_NAND_ENABLE_PIN, 1);
+}
+#endif /* CONFIG_CMD_NAND */
+

<snip>

Convert the element initialization to be
.vl_col = 640
.vl_row = 480
etc..

Quoted 20 lines
board/esd/otc570/otc570.c new file +20 -0
+#ifdef CONFIG_LCD
+/* Number of columns and rows, pixel clock in Hz and hsync/vsync polarity */
+vidinfo_t panel_info = {
+	vl_col:		640,
+	vl_row:		480,
+	vl_clk:		25175000,
+	vl_sync:	ATMEL_LCDC_INVLINE_INVERTED |
+			ATMEL_LCDC_INVFRAME_INVERTED,
+
+	vl_bpix:	3,	/* Bits per pixel, 0 = 1bit, 3 = 8bit */
+	vl_tft:		1,	/* 0 = passive, 1 = TFT */
+	vl_vsync_len:	1,	/* Length of vertical sync in number of lines */
+	vl_upper_margin:35,	/* Idle lines at the beginning of the frame */
+	vl_lower_margin:5,	/* Idle lines at the end of the frame */
+	vl_hsync_len:	5,	/* Width of the LCDHSYNC pulse */
+	vl_left_margin:	112,	/* Idle cycles at the beginning of the line */
+	vl_right_margin:1,	/* Idle cycles at the end of the line */
+
+	mmio:		AT91SAM9263_LCDC_BASE,	/* Memory mapped registers */
+};

<snip>

Quoted 21 lines
board/esd/otc570/otc570.c new file +21 -0
+static void otc570_lcd_hw_init(void)
+{
+	at91_set_A_periph(AT91_PIN_PC0, 0);	/* LCDVSYNC */
+	at91_set_A_periph(AT91_PIN_PC1, 0);	/* LCDHSYNC */
+	at91_set_A_periph(AT91_PIN_PC2, 0);	/* LCDDOTCK */
+	at91_set_A_periph(AT91_PIN_PC3, 0);	/* LCDDEN */
+	at91_set_B_periph(AT91_PIN_PB9, 0);	/* LCDCC */
+	at91_set_A_periph(AT91_PIN_PC6, 0);	/* LCDD2 */
+	at91_set_A_periph(AT91_PIN_PC7, 0);	/* LCDD3 */
+	at91_set_A_periph(AT91_PIN_PC8, 0);	/* LCDD4 */
+	at91_set_A_periph(AT91_PIN_PC9, 0);	/* LCDD5 */
+	at91_set_A_periph(AT91_PIN_PC10, 0);	/* LCDD6 */
+	at91_set_A_periph(AT91_PIN_PC11, 0);	/* LCDD7 */
+	at91_set_A_periph(AT91_PIN_PC14, 0);	/* LCDD10 */
+	at91_set_A_periph(AT91_PIN_PC15, 0);	/* LCDD11 */
+	at91_set_A_periph(AT91_PIN_PC16, 0);	/* LCDD12 */
+	at91_set_B_periph(AT91_PIN_PC12, 0);	/* LCDD13 */
+	at91_set_A_periph(AT91_PIN_PC18, 0);	/* LCDD14 */
+	at91_set_A_periph(AT91_PIN_PC19, 0);	/* LCDD15 */
+	at91_set_A_periph(AT91_PIN_PC22, 0);	/* LCDD18 */
+	at91_set_A_periph(AT91_PIN_PC23, 0);	/* LCDD19 */

board/esd/otc570/otc570.c line 209

Quoted 10 lines
board/esd/otc570/otc570.c new file +10 -0
+	at91_set_A_periph(AT91_PIN_PC24, 0);	/* LCDD20 */
+	at91_set_B_periph(AT91_PIN_PC17, 0);	/* LCDD21 */
+	at91_set_A_periph(AT91_PIN_PC26, 0);	/* LCDD22 */
+	at91_set_A_periph(AT91_PIN_PC27, 0);	/* LCDD23 */
+	at91_set_gpio_output(AT91_PIN_PA30, 1);	/* PCI */
+
+	at91_sys_write(AT91_PMC_PCER, 1 << AT91SAM9263_ID_LCDC);
+
+#ifndef CONFIG_FB_TO_SDRAM
+	gd->fb_base = AT91SAM9263_SRAM0_BASE;

Should there be an #else ?

Quoted 3 lines
board/esd/otc570/otc570.c new file +3 -0
+#endif
+}
+

<snip>

Quoted 6 lines
board/esd/otc570/otc570.c new file +6 -0
+#ifdef CONFIG_MISC_INIT_R
+int misc_init_r(void)
+{
+	char str[64];
+
+	at91_set_gpio_output(AT91_PIN_PA29, 1);

board/esd/otc570/otc570.c line 311

Quoted 10 lines
board/esd/otc570/otc570.c new file +10 -0
+	at91_set_A_periph(AT91_PIN_PA26, 1);			/* TXD0 */
+	at91_set_A_periph(AT91_PIN_PA27, 0);			/* RXD0 */
+	at91_sys_write(AT91_PMC_PCER, 1 << AT91SAM9263_ID_US0);
+	/* Set USART_MODE = 1 (RS485) */
+	at91_sys_write((0xFFF8C004 - AT91_BASE_SYS), 1);
+
+	puts("USART0: ");
+
+	if (getenv_r("usart0", str, sizeof(str)) == -1) {
+		puts("No entry - assuming 1-wire\n");

Why are you mixing puts and printf ?

Quoted 6 lines
board/esd/otc570/otc570.c new file +6 -0
+		/* CTS pin, works as mode select pin (0 = 1-wire; 1 = RS485) */
+		at91_set_gpio_output(AT91_PIN_PA29, 0);
+	} else {
+		if (strcmp(str, "1-wire") == 0) {
+			printf("%s\n", str);
+			at91_set_gpio_output(AT91_PIN_PA29, 0);

board/esd/otc570/otc570.c line 327

Quoted 10 lines
board/esd/otc570/otc570.c new file +10 -0
+		} else if (strcmp(str, "rs485") == 0) {
+			printf("%s\n", str);
+			at91_set_gpio_output(AT91_PIN_PA29, 1);
+		} else {
+			puts("Wrong entry - assuming 1-wire ");
+			puts("(valid values are '1-wire' or 'rs485')\n");
+			at91_set_gpio_output(AT91_PIN_PA29, 0);
+		}
+	}
+	printf("Display memory address: 0x%08lX\n", gd->fb_base);

Above #ifndef may not set fb_base

Quoted 5 lines
board/esd/otc570/otc570.c new file +5 -0
+
+	return 0;
+}
+#endif /* CONFIG_MISC_INIT_R */
+

<snip>

Quoted 48 lines
board/esd/otc570/otc570.c new file +48 -0
+
+/*
+ * U-Boot commands
+ */
+
+/* Set brightness */
+int do_blbright(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	unsigned long value = 0xff;
+
+	if (argc > 1) {
+		value = simple_strtoul(argv[1], NULL, 0);
+		if ((value >= 0) && (value <= 255)) {
+			printf("Writing value %02lX ...", value);
+			__raw_writel(value, (panel_info.mmio +
+						ATMEL_LCDC_CONTRAST_VAL));
+			puts("done\n");
+		} else {
+			puts("Invalid value! ");
+			puts("Valid values are 0 ... 255 or 0x0 ... 0xFF\n");
+			return -1;
+		}
+	} else {
+		puts("No value given! ");
+		puts("Valid values are 0 ... 255 or 0x0 ... 0xFF\n");
+		return -1;
+	}
+	return 0;
+}
+U_BOOT_CMD(
+	blbright,	2,	1,	do_blbright,
+	"sets display brightness",
+	"\n"
+);
+
+/* Switch backlight power */
+int do_blpower(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	int i = 0;
+	if (argc > 1) {
+		i = argv[1][0] == '0';
+		if (i) {
+			puts("Switching backlight off... ");
+			lcd_disable();
+		} else {
+			puts("Switching backlight on... ");
+			lcd_enable();
+		}

board/esd/otc570/otc570.c line 429

Quoted 10 lines
board/esd/otc570/otc570.c new file +10 -0
+		puts("done\n");
+	} else
+		puts("No value given!\n");
+	return 0;
+}
+U_BOOT_CMD(
+	blpower,	2,	1,	do_blpower,
+	"switches display-backlight on or off",
+	"\n"
+);

These video commands look common enough that maybe they should go into common/* Is there anything that already does this?

<snip>

Quoted 6 lines
include/configs/otc570.h new file +0 -0
new file mode 100644
index 0000000..bb04abd

include/configs/otc570.h line 9

Quoted 9 lines
include/configs/otc570.h new file +9 -0
@@ -0,0 +1,247 @@
+/*
+ * (C) Copyright 2007-2008
+ * Stelian Pop <[email protected]>
+ * Lead Tech Design <www.leadtechdesign.com>
+ *
+ * (C) Copyright 2009
+ * Daniel Gorsulowski <[email protected]>
+ * esd electronic system design gmbh <www.esd.eu>
+ *

New copyrights before old
swap.

Quoted 16 lines
include/configs/otc570.h new file +16 -0
+ * Configuation settings for the esd OTC570 board.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License

include/configs/otc570.h line 35

Quoted 10 lines
include/configs/otc570.h new file +10 -0
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/* Common stuff */
+#define CONFIG_SYS_HZ			1000	/* decrementer freq */

board and cpu defines first
Move CONFIG_SYS_HZ lower

Quoted 5 lines
include/configs/otc570.h new file +5 -0
+#define CONFIG_OTC570			1	/* Board is esd OTC570 */
+#define CONFIG_ARM926EJS		1	/* This is an ARM926EJS Core */
+#define CONFIG_AT91SAM9263		1	/* It's an AT91SAM9263 SoC */
+#define CONFIG_DISPLAY_BOARDINFO	1
+#define CONFIG_DISPLAY_CPUINFO		1	/* display cpu info and speed */

<snip>

tools/Makefile endif · line 107

Quoted 10 lines

index 5b8c3c3..c91e19d 100644

tools/Makefile +3 -0
@@ -102,6 +102,9 @@ endif
 ifeq ($(VENDOR),atmel)
 LOGO_BMP= logos/atmel.bmp
 endif
+ifeq ($(VENDOR),esd)
+LOGO_BMP= logos/esd.bmp
+endif

There are a number of esd board.
Is this bmp ok for all of them ?

tools/logos/esd.bmp

Quoted 4 lines
tools/Makefile +0 -0
 ifeq ($(VENDOR),ronetix)
 LOGO_BMP= logos/ronetix.bmp
 endif
tools/logos/esd.bmp +0 -0

This looks ok

Quoted 1 line

new file mode 100644

#2 lore raw

PATCH 1/1 at91: Add esd gmbh OTC570 board support

Hello Tom,

thanks for reviewing...

Quoted 9 lines · Tom
Quoted 4 lines · Daniel Gorsulowski

This patch adds support for esd gmbh OTC570 board. The OTC570 is based on an Atmel AT91SAM9263 SoC.

For u-boot-video.
Maybe some u-boot commands that could be common.

<snip>

Quoted 53 lines
Quoted 53 lines
board/esd/otc570/otc570.c new file +53 -0
+
+/*
+ * U-Boot commands
+ */
+
+/* Set brightness */
+int do_blbright(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	unsigned long value = 0xff;
+
+	if (argc > 1) {
+		value = simple_strtoul(argv[1], NULL, 0);
+		if ((value >= 0) && (value <= 255)) {
+			printf("Writing value %02lX ...", value);
+			__raw_writel(value, (panel_info.mmio +
+						ATMEL_LCDC_CONTRAST_VAL));
+			puts("done\n");
+		} else {
+			puts("Invalid value! ");
+			puts("Valid values are 0 ... 255 or 0x0 ... 0xFF\n");
+			return -1;
+		}
+	} else {
+		puts("No value given! ");
+		puts("Valid values are 0 ... 255 or 0x0 ... 0xFF\n");
+		return -1;
+	}
+	return 0;
+}
+U_BOOT_CMD(
+	blbright,	2,	1,	do_blbright,
+	"sets display brightness",
+	"\n"
+);
+
+/* Switch backlight power */
+int do_blpower(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	int i = 0;
+	if (argc > 1) {
+		i = argv[1][0] == '0';
+		if (i) {
+			puts("Switching backlight off... ");
+			lcd_disable();
+		} else {
+			puts("Switching backlight on... ");
+			lcd_enable();
+		}
+		puts("done\n");
+	} else
+		puts("No value given!\n");
+	return 0;
+}
Quoted 9 lines

board/esd/otc570/otc570.c line 429

Quoted 5 lines
board/esd/otc570/otc570.c new file +5 -0
+U_BOOT_CMD(
+	blpower,	2,	1,	do_blpower,
+	"switches display-backlight on or off",
+	"\n"
+);

These video commands look common enough that maybe they should go into common/* Is there anything that already does this?

I'll think about, how to make these commands common. Until then I can live without them, so I'll remove them for now.

<snip>

Quoted 5 lines
Quoted 5 lines

index 5b8c3c3..c91e19d 100644

tools/Makefile +0 -0
@@ -102,6 +102,9 @@ endif
 ifeq ($(VENDOR),atmel)
Quoted 9 lines

tools/Makefile endif · line 107

Quoted 5 lines
tools/Makefile +3 -0
 LOGO_BMP= logos/atmel.bmp
 endif
+ifeq ($(VENDOR),esd)
+LOGO_BMP= logos/esd.bmp
+endif

There are a number of esd board.
Is this bmp ok for all of them ?

Yes, this bmp is common for all esd boards that have a LCD and provide a bootup logo

Quoted 4 lines

tools/logos/esd.bmp

Quoted 4 lines
tools/Makefile +0 -0
 ifeq ($(VENDOR),ronetix)
 LOGO_BMP= logos/ronetix.bmp
 endif
tools/logos/esd.bmp +0 -0

<snip>

All other other suggestions I applyed in v2.

Regards,
Daniel

#3 lore raw

PATCH 1/1 at91: Add esd gmbh OTC570 board support

Hi Daniel,

Quoted 77 lines

Hello Tom,

thanks for reviewing...

Quoted 9 lines · Tom
Quoted 4 lines · Daniel Gorsulowski

This patch adds support for esd gmbh OTC570 board. The OTC570 is based on an Atmel AT91SAM9263 SoC.

For u-boot-video.
Maybe some u-boot commands that could be common.

<snip>

Quoted 53 lines
Quoted 53 lines
board/esd/otc570/otc570.c new file +53 -0
+
+/*
+ * U-Boot commands
+ */
+
+/* Set brightness */
+int do_blbright(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	unsigned long value = 0xff;
+
+	if (argc > 1) {
+		value = simple_strtoul(argv[1], NULL, 0);
+		if ((value >= 0) && (value <= 255)) {
+			printf("Writing value %02lX ...", value);
+			__raw_writel(value, (panel_info.mmio +
+						ATMEL_LCDC_CONTRAST_VAL));
+			puts("done\n");
+		} else {
+			puts("Invalid value! ");
+			puts("Valid values are 0 ... 255 or 0x0 ... 0xFF\n");
+			return -1;
+		}
+	} else {
+		puts("No value given! ");
+		puts("Valid values are 0 ... 255 or 0x0 ... 0xFF\n");
+		return -1;
+	}
+	return 0;
+}
+U_BOOT_CMD(
+	blbright,	2,	1,	do_blbright,
+	"sets display brightness",
+	"\n"
+);
+
+/* Switch backlight power */
+int do_blpower(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	int i = 0;
+	if (argc > 1) {
+		i = argv[1][0] == '0';
+		if (i) {
+			puts("Switching backlight off... ");
+			lcd_disable();
+		} else {
+			puts("Switching backlight on... ");
+			lcd_enable();
+		}
+		puts("done\n");
+	} else
+		puts("No value given!\n");
+	return 0;
+}
Quoted 9 lines

board/esd/otc570/otc570.c line 429

Quoted 5 lines
board/esd/otc570/otc570.c new file +5 -0
+U_BOOT_CMD(
+	blpower,	2,	1,	do_blpower,
+	"switches display-backlight on or off",
+	"\n"
+);

These video commands look common enough that maybe they should go into common/* Is there anything that already does this?

Quoted 2 lines

I'll think about, how to make these commands common. Until then I can live without them, so I'll remove them for now.

Indeed - if you (case insensitive) grep for "brightness", you will find lots of implementations to set a display brightness. Maybe we should setup common code and defer the implementation into a weak function? It seems that we have a good chance to merge lots of code here.

Cheers
Detlev

Signature · 8 lines
[Linux] USB consoles was a  bad hack written on a drunken dare.   I'm still
constantly amazed that the thing even works at all, let alone the fact that
people are actually using it :) 
                            -- Greg KH <[email protected]>
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de