Skip to contentSkip to conversation

KVM: x86: Remove emulation failure report

PATCH New Sheng Yang 1 participant 1 message Jan 19, 2010

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Sheng Yang

author
#0 lore raw

PATCH 1/1 KVM: x86: Remove emulation failure report

As Avi noted:

Quoted 4 lines

There are two problems with the kernel failure report. First, it doesn't report enough data - registers, surrounding instructions, etc. that are needed to explain what is going on. Second, it can flood dmesg, which is a pretty bad thing to do.

So we remove the emulation failure report in handle_invalid_guest_state(), and would inspected the guest using userspace tool in the future.

Signed-off-by Sheng Yang <[email protected]>
---
 arch/x86/kvm/vmx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/kvm/vmx.c +0 -1
index 92c2f9a..27b9905 100644
@@ -3438,7 +3438,6 @@ static int handle_invalid_guest_state(struct kvm_vcpu *vcpu)
 		}
 
 		if (err != EMULATE_DONE) {
-			kvm_report_emulation_failure(vcpu, "emulation failure");
 			vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
 			vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_EMULATION;
 			vcpu->run->internal.ndata = 0;
Signature · 1 line
1.5.4.5