Skip to contentSkip to conversation

xfstests: kill in 131 needs to be quiet

PATCH In review Dave Chinner 2 participants 3 messages Jan 20, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: kill in 131 needs to be quiet

If the kill fails because the processes have already terminates, the output from kill (no such process) will cause the test to fail. Make sure kill doesn't output anything.

---
 131 |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
131 +2 -2
index 9be0a14..783765e 100755
@@ -34,8 +34,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _cleanup()
 {
-    kill $locktest_pid2
-    kill $locktest_pid1
+    kill $locktest_pid2 2&>1 /dev/null
+    kill $locktest_pid1 2&>1 /dev/null
     _cleanup_testdir
 }
 
Signature · 6 lines
1.6.5

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dave Chinner

If the kill fails because the processes have already terminates, the output from kill (no such process) will cause the test to fail. Make sure kill doesn't output anything.

Yes, I see the same here,

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 5 lines · Dave Chinner

If the kill fails because the processes have already terminates, the output from kill (no such process) will cause the test to fail. Make sure kill doesn't output anything.

Yes, I see the same here,

Pushed.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs