Skip to contentSkip to conversation

linux-storcenter: fix circular dependency between do_package and do_deploy

PATCH In review Guo Hongruan 3 participants 5 messages Jan 23, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-storcenter: fix circular dependency between do_package and do_deploy

* 'addtask deploy' sentence in linux-storcenter_2.6.27.7.bb conflicts with the same one in kernel.bbclass and causes circular dependency between do_package and do_deploy

---
 recipes/linux/linux-storcenter_2.6.27.7.bb |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
recipes/linux/linux-storcenter_2.6.27.7.bb +0 -2
index b403cda..e842ab7 100644
@@ -53,5 +53,3 @@ do_deploy() {
 }
 
 do_deploy[dirs] = "${S}"
-
-addtask deploy before do_package after do_install
Signature · 1 line
1.5.4.3
#1 lore raw
Quoted 3 lines · On Saturday 23 January 2010 10:36:07 Guo Hongruan wrote:

* 'addtask deploy' sentence in linux-storcenter_2.6.27.7.bb conflicts with the same one in kernel.bbclass and causes circular dependency between do_package and do_deploy

Could you please grep through recipes/linux and see how many more issues we have of the same kind?

#2 lore raw

Yes, I did.

the same question exists in
recipes/linux/gumstix-linux.inc|72| addtask deploy before do_package after do_install which may cause circular dependency too.

Quoted 12 lines · 在 Sat, 23 Jan 2010 17:51:06 +0800,Holger Hans Peter Freyther…
Quoted 3 lines · On Saturday 23 January 2010 10:36:07 Guo Hongruan wrote:

* 'addtask deploy' sentence in linux-storcenter_2.6.27.7.bb conflicts with the same one in kernel.bbclass and causes circular dependency between do_package and do_deploy

Could you please grep through recipes/linux and see how many more issues we have of the same kind?

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 4 lines
Guo Hongruan, Embedded Linux Consultant
Skype: camelguo
Twitter: camelguo
http://www.gulessoft.com
#3 lore raw
Quoted 6 lines · Guo Hongruan

Yes, I did.

the same question exists in recipes/linux/gumstix-linux.inc|72| addtask deploy before do_package after do_install
which may cause circular dependency too.

But if you just remove that line, the custom do_deploy task won't be used at all IIRC.. so proper fix would be to adjust after and before like in a55e9a527a8c9823044196d031f2da2783ff8f35 and then bc2bddb71d8c5db25b80aa6435392ec1c8df39f9

Probably:
addtask deploy before do_build after do_package

but please check
before do_build was needed to force it run at all (for -c build) after do_package was used, because we're packing already stripped modules to modules.tgz and we needed to have packages-split already populated.

Regards,

Signature · 3 lines
uin:136542059                jid:[email protected]
Jansa Martin                 sip:[email protected] 
JaMa                         
#4 lore raw

the do_deploy task has been added in kernel.bbclass, which defines the proper order for these tasks. So it should be safe to remove 'addtask deploy' from the recipe.

Quoted 24 lines · 在 Sat, 23 Jan 2010 18:10:47 +0800,Martin Jansa <[email protected]> 写道:
Quoted 6 lines · Guo Hongruan

Yes, I did.

the same question exists in recipes/linux/gumstix-linux.inc|72| addtask deploy before do_package after do_install
which may cause circular dependency too.

But if you just remove that line, the custom do_deploy task won't be used at all IIRC.. so proper fix would be to adjust after and before like in a55e9a527a8c9823044196d031f2da2783ff8f35 and then bc2bddb71d8c5db25b80aa6435392ec1c8df39f9

Probably:
addtask deploy before do_build after do_package

but please check
before do_build was needed to force it run at all (for -c build) after do_package was used, because we're packing already stripped modules to modules.tgz and we needed to have packages-split already populated.

Regards,

Signature · 4 lines
Guo Hongruan, Embedded Linux Consultant
Skype: camelguo
Twitter: camelguo
http://www.gulessoft.com