Skip to contentSkip to conversation

ath9k: fix eeprom INI values override for 2GHz-only cards

PATCH In review Felix Fietkau 3 participants 3 messages Jan 23, 2010 – Jan 25, 2010 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore

Felix Fietkau

author
#0 lore raw

PATCH 1/1 ath9k: fix eeprom INI values override for 2GHz-only cards

Among other changes, this commit:

commit 06d0f0663e11cab4ec5f2c143a118d71a12fbbe9
Author: Sujith <[email protected]>
Date: Thu Feb 12 10:06:45 2009 +0530

ath9k: Enable Fractional N mode

changed the hw attach code to fix up initialization values only for dual band devices, however the commit message did not give a reason as to why this would be useful or necessary.

According to tests by Jorge Boncompte, this breaks at least some 2GHz-only cards, so the code should be changed back to the unconditional INI fixup.

Signed-off-by Felix Fietkau <[email protected]>
Reported-by Jorge Boncompte <[email protected]>
Cc [email protected]

---

drivers/net/wireless/ath/ath9k/hw.c +3 -4
@@ -823,12 +823,11 @@ static void ath9k_hw_init_mode_gain_regs
 	}
 }
 
-static void ath9k_hw_init_11a_eeprom_fix(struct ath_hw *ah)
+static void ath9k_hw_init_eeprom_fix(struct ath_hw *ah)
 {
 	u32 i, j;
 
-	if ((ah->hw_version.devid == AR9280_DEVID_PCI) &&
-	    test_bit(ATH9K_MODE_11A, ah->caps.wireless_modes)) {
+	if (ah->hw_version.devid == AR9280_DEVID_PCI) {
 
 		/* EEPROM Fixup */
 		for (i = 0; i < ah->iniModes.ia_rows; i++) {

@@ -948,7 +947,7 @@ int ath9k_hw_init(struct ath_hw *ah)
 	if (r)
 		return r;
 
-	ath9k_hw_init_11a_eeprom_fix(ah);
+	ath9k_hw_init_eeprom_fix(ah);
 
 	r = ath9k_hw_init_macaddr(ah);
 	if (r) {
#1 lore raw

PATCH 1/1 ath9k: fix eeprom INI values override for 2GHz-only cards

Quoted 8 lines · Felix Fietkau

Among other changes, this commit:

commit 06d0f0663e11cab4ec5f2c143a118d71a12fbbe9
Author: Sujith <[email protected]>
Date: Thu Feb 12 10:06:45 2009 +0530

ath9k: Enable Fractional N mode

Quoted 7 lines

changed the hw attach code to fix up initialization values only for dual band devices, however the commit message did not give a reason as to why this would be useful or necessary.

According to tests by Jorge Boncompte, this breaks at least some 2GHz-only cards, so the code should be changed back to the unconditional INI fixup.

The original fix was a workaround for MB-92 cards, which certainly was applicable to both single/dual band cards.

During a sync-up with internal HW-specific code changes, this was changed to 11A specific. Not sure why this was done so. Will look into this.

Sujith

Tested-by on v1 1/1
#2 lore raw
In reply to Felix Fietkau
Quoted 12 lines · Felix Fietkau

Among other changes, this commit:

commit 06d0f0663e11cab4ec5f2c143a118d71a12fbbe9
Author: Sujith <[email protected]>
Date: Thu Feb 12 10:06:45 2009 +0530

ath9k: Enable Fractional N mode

changed the hw attach code to fix up initialization values only for dual band devices, however the commit message did not give a reason as to why this would be useful or necessary.

Quoted 7 lines

According to tests by Jorge Boncompte, this breaks at least some 2GHz-only cards, so the code should be changed back to the unconditional INI fixup.

Signed-off-by Felix Fietkau <[email protected]>
Reported-by Jorge Boncompte <[email protected]>
Cc [email protected]
Tested-by Pavel Roskin <[email protected]>

Tested on Ubiquiti SR71-15 and Ubiquiti SR71-12.

Signature · 2 lines
Regards,
Pavel Roskin