Skip to contentSkip to conversation

Clean-up a few comments.

PATCH In review Justin P. Mattock 3 participants 4 messages Jan 26, 2010 – Jan 27, 2010 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Clean-up a few comments.

---
 arch/x86/kernel/setup.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
arch/x86/kernel/setup.c +4 -5
index f7b8b98..1bd37e9 100644
@@ -245,7 +245,7 @@ struct edd edd;
 #ifdef CONFIG_EDD_MODULE
 EXPORT_SYMBOL(edd);
 #endif
-/**
+/*
  * copy_edd() - Copy the BIOS EDD information
  *              from boot_params into a safe place.
  *
@@ -398,8 +398,8 @@ static void __init reserve_initrd(void)
 
 	if (ramdisk_end <= end_of_lowmem) {
 		/* All in lowmem, easy case */
-		/*
-		 * don't need to reserve again, already reserved early
+		
+		/* don't need to reserve again, already reserved early
 		 * in i386_start_kernel
 		 */
 		initrd_start = ramdisk_image + PAGE_OFFSET;
@@ -665,8 +665,7 @@ static struct dmi_system_id __initdata bad_bios_dmi_table[] = {
  * for initialization.  Note, the efi init code path is determined by the
  * global efi_enabled. This allows the same kernel image to be used on existing
  * systems (with a traditional BIOS) as well as on EFI systems.
- */
-/*
+ *
  * setup_arch - architecture-specific boot-time initializations
  *
  * Note: On x86_64, fixmaps are ready for use even before this is called.
Signature · 1 line
1.6.5.GIT
#1 lore raw
Quoted 10 lines · Justin P. Mattock
---
 arch/x86/kernel/setup.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
arch/x86/kernel/setup.c +0 -0
index f7b8b98..1bd37e9 100644

arch/x86/kernel/setup.c struct edd edd; · line 248

Quoted 5 lines
arch/x86/kernel/setup.c +1 -1
@@ -245,7 +245,7 @@ struct edd edd;
 #ifdef CONFIG_EDD_MODULE
 EXPORT_SYMBOL(edd);
 #endif
-/**
+/*

There are zillions of '**' comment starters in kernel sources.

	$ git grep '/\*\*$' drivers/ | wc -l
	15506

So it doesn't seem to make sense to fix only this particular one.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#2 lore raw
Quoted 20 lines · Jiri Kosina
Quoted 10 lines · Justin P. Mattock
---
  arch/x86/kernel/setup.c |    9 ++++-----
  1 files changed, 4 insertions(+), 5 deletions(-)
arch/x86/kernel/setup.c +0 -0
index f7b8b98..1bd37e9 100644

arch/x86/kernel/setup.c struct edd edd; · line 248

Quoted 5 lines
arch/x86/kernel/setup.c +1 -1
@@ -245,7 +245,7 @@ struct edd edd;
  #ifdef CONFIG_EDD_MODULE
  EXPORT_SYMBOL(edd);
  #endif
-/**
+/*

There are zillions of '**' comment starters in kernel sources.

Quoted 5 lines
	$ git grep '/\*\*$' drivers/ | wc -l
	15506

So it doesn't seem to make sense to fix only this particular one.

alright.. was just going through and noticed. In any case I'll stick to typos if I come across any.

Justin P. Mattock

#3 lore raw
In reply to Jiri Kosina
Quoted 20 lines · Jiri Kosina
Quoted 10 lines · Justin P. Mattock

---
 arch/x86/kernel/setup.c |    9 ++++-----

 1 files changed, 4 insertions(+), 5 deletions(-)
arch/x86/kernel/setup.c +0 -0
index f7b8b98..1bd37e9 100644

arch/x86/kernel/setup.c struct edd edd; · line 248

Quoted 5 lines
arch/x86/kernel/setup.c +1 -1
@@ -245,7 +245,7 @@ struct edd edd;
  #ifdef CONFIG_EDD_MODULE
  EXPORT_SYMBOL(edd);
  #endif
-/**
+/*

There are zillions of '**' comment starters in kernel sources.

Quoted 4 lines
       $ git grep '/\*\*$' drivers/ | wc -l
       15506

So it doesn't seem to make sense to fix only this particular one.

Some of them are needed by kerneldoc generation, it doesn't make sense to fix them.