Make firmware vs driver major version mismatch an error.
PATCH 1/1 Make firmware vs driver major version mismatch an error.
From: Eliot Blennerhassett <[email protected]>
I.e. incompatible firmware will fail driver load.
Signed-off-by Eliot Blennerhassett <[email protected]>
--- pci/asihpi/hpidspcd.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
pci/asihpi/hpidspcd.c +7 -0
@@ -103,6 +103,13 @@ short HpiDspCode_Open( goto error2; } +if (header.version /10000 !=HPI_VER_DECIMAL /10000 ) { +HPI_DEBUG_LOG (ERROR , +"Firmware Major Version mismatch DSP image %d != Driver %d\n" , + header.version,HPI_VER_DECIMAL ); + goto error2; + } +if (header.version !=HPI_VER_DECIMAL ) { HPI_DEBUG_LOG(WARNING, "Version mismatch DSP image %d != Driver %d\n",
Signature · 1 line
1.7.0.rc0.8.ge3f67d
At Wed, 03 Feb 2010 10:07:37 +1300,
Quoted 6 lines · [email protected] wrote:
From: Eliot Blennerhassett <[email protected]>
I.e. incompatible firmware will fail driver load.
Signed-off-by Eliot Blennerhassett <[email protected]>
Applied now. Thanks.
Takashi
Quoted 25 lines
--- pci/asihpi/hpidspcd.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)pci/asihpi/hpidspcd.c +7
-0@@ -103,6 +103,13 @@ short HpiDspCode_Open( goto error2; } +if (header.version /10000 !=HPI_VER_DECIMAL /10000 ) { +HPI_DEBUG_LOG (ERROR , +"Firmware Major Version mismatch DSP image %d != Driver %d\n" , + header.version,HPI_VER_DECIMAL ); + goto error2; + } +if (header.version !=HPI_VER_DECIMAL ) { HPI_DEBUG_LOG(WARNING, "Version mismatch DSP image %d != Driver %d\n",Signature · 1 line
1.7.0.rc0.8.ge3f67d