Load the initial SIDs upon every policy load
PATCH 1/1 Load the initial SIDs upon every policy load
Author: Guido Trentalancia <[email protected]> Date: Mon Feb 03 17:03:32 2010 +0100
Always load the initial SIDs, even in the case of a policy reload and not just at the initial policy load. This comes particularly handy after the introduction of a recent patch for enabling runtime switching between different policy types, although this patch is in theory independent from that feature.
---
security/selinux/ss/services.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
security/selinux/ss/services.c +12 -4
@@ -1506,7 +1506,10 @@ static int clone_sid(u32 sid, {struct sidtab *s = arg; -return sidtab_insert (s, sid, context); +if (sid >SECINITSID_NUM ) +return sidtab_insert (s, sid, context); +else +return 0 ; }static inline int convert_context_handle_invalid_context (struct context *context)
@@ -1552,7 +1555,10 @@ static int convert_context(u32 key,struct user_datum *usrdatum;char *s;u32 len; -int rc; +int rc =0 ; + +if (key <=SECINITSID_NUM ) + goto out; args = p;
@@ -1712,9 +1718,11 @@ int security_load_policy(void *data, sizif (policydb_read (&newpolicydb, fp))return -EINVAL ; -if (sidtab_init (&newsidtab)) { + rc =policydb_load_isids (&newpolicydb, &newsidtab); +if (rc) { +printk (KERN_ERR "SELinux: unable to load the initial SIDs\n" );policydb_destroy (&newpolicydb); -return -ENOMEM ; +return rc; } if (selinux_set_mapping(&newpolicydb, secclass_map,
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 11 lines · Guido Trentalancia
Author: Guido Trentalancia <[email protected]> Date: Mon Feb 03 17:03:32 2010 +0100Always load the initial SIDs, even in the case of a policy reload and not just at the initial policy load. This comes particularly handy after the introduction of a recent patch for enabling runtime switching between different policy types, although this patch is in theory independent from that feature.
Signed-off-by Guido Trentalancia <[email protected]>
Note: This is a change in behavior for SELinux. Changes to the initial SID contexts will take effect immediately upon policy reload, so e.g. ps -eZ will show a difference if you switch from targeted to mls in Fedora, ala:
setenforce 0
sed -e "/SELINUXTYPE/s/targeted/mls/" /etc/selinux/config > /etc/selinux/config.new mv /etc/selinux/config.new /etc/selinux/config
ps -eZ | grep kthreaddload_policy
ps -eZ | grep kthreadd
Previously the initial SID contexts would not have changed until the next reboot.
Quoted 46 lines
---
security/selinux/ss/services.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)security/selinux/ss/services.c +12
-4@@ -1506,7 +1506,10 @@ static int clone_sid(u32 sid, {struct sidtab *s = arg; -return sidtab_insert (s, sid, context); +if (sid >SECINITSID_NUM ) +return sidtab_insert (s, sid, context); +else +return 0 ; }static inline int convert_context_handle_invalid_context (struct context *context)@@ -1552,7 +1555,10 @@ static int convert_context(u32 key,struct user_datum *usrdatum;char *s;u32 len; -int rc; +int rc =0 ; + +if (key <=SECINITSID_NUM ) + goto out; args = p;@@ -1712,9 +1718,11 @@ int security_load_policy(void *data, sizif (policydb_read (&newpolicydb, fp))return -EINVAL ; -if (sidtab_init (&newsidtab)) { + rc =policydb_load_isids (&newpolicydb, &newsidtab); +if (rc) { +printk (KERN_ERR "SELinux: unable to load the initial SIDs\n" );policydb_destroy (&newpolicydb); -return -ENOMEM ; +return rc; } if (selinux_set_mapping(&newpolicydb, secclass_map,
Signature · 8 lines
Stephen Smalley National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.