Skip to contentSkip to conversation

ASoC: pandora: Add APLL supply to fix audio output

PATCH Applied Grazvydas Ignotas 4 participants 4 messages Feb 4, 2010 – Feb 5, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: pandora: Add APLL supply to fix audio output

Pandora's external DAC is using 256*Fs output from the TWL4030 codec, and TWL4030 needs to have APLL enabled for it's 256*Fs output to function.

---
I noticed this a bit late because TWL4030 codec used to have APLL enable hardcoded until that was clean up by not-so-old patch. Would be nice to see this in next -rc, as without this audio won't work completely on pandora (again)..

 sound/soc/omap/omap3pandora.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/omap/omap3pandora.c +1 -0
index 71b2c16..68980c1 100644
@@ -145,6 +145,7 @@ static const struct snd_soc_dapm_widget omap3pandora_in_dapm_widgets[] = {
 };
 
 static const struct snd_soc_dapm_route omap3pandora_out_map[] = {
+	{"PCM DAC", NULL, "APLL Enable"},
 	{"Headphone Amplifier", NULL, "PCM DAC"},
 	{"Line Out", NULL, "PCM DAC"},
 	{"Headphone Jack", NULL, "Headphone Amplifier"},
Signature · 1 line
1.6.3.3
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote:

Pandora's external DAC is using 256*Fs output from the TWL4030 codec, and TWL4030 needs to have APLL enabled for it's 256*Fs output to function.

---
I noticed this a bit late because TWL4030 codec used to have APLL enable hardcoded until that was clean up by not-so-old patch. Would be nice to see this in next -rc, as without this audio won't work completely on pandora (again)..

Yeah, when I made the changes to the twl4030 codec, I did missed the pandora setup..

Acked-by
#2 lore raw
Quoted 12 lines · Peter Ujfalusi
Quoted 10 lines · On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote:

Pandora's external DAC is using 256*Fs output from the TWL4030 codec, and TWL4030 needs to have APLL enabled for it's 256*Fs output to function.

---
I noticed this a bit late because TWL4030 codec used to have APLL enable hardcoded until that was clean up by not-so-old patch. Would be nice to see this in next -rc, as without this audio won't work completely on pandora (again)..

Quoted 4 lines

Yeah, when I made the changes to the twl4030 codec, I did missed the pandora setup..

Btw, I may be getting a pandora soon so I should be able to keep on top of any future breakages.

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
Applied
#3 lore raw
Quoted 13 lines · Liam Girdwood
Quoted 12 lines · Peter Ujfalusi
Quoted 10 lines · On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote:

Pandora's external DAC is using 256*Fs output from the TWL4030 codec, and TWL4030 needs to have APLL enabled for it's 256*Fs output to function.

---
I noticed this a bit late because TWL4030 codec used to have APLL enable hardcoded until that was clean up by not-so-old patch. Would be nice to see this in next -rc, as without this audio won't work completely on pandora (again)..

Quoted 6 lines
Quoted 4 lines

Yeah, when I made the changes to the twl4030 codec, I did missed the pandora setup..

Applied, thanks.