Skip to contentSkip to conversation

mac80211: fix bss_conf.dtim_period

PATCH In review Johannes Berg 2 participants 3 messages Feb 5, 2010 mac80211

lore
Share & tools
lore

Johannes Berg

author maintainer
#0 lore raw

PATCH 1/1 mac80211: fix bss_conf.dtim_period

In AP mode, the only mode where the parameter is supposed to be valid, we never assign it! Fix that to allow drivers to avoid parsing the TIM IE for the value.

---
 net/mac80211/cfg.c |    2 ++
 1 file changed, 2 insertions(+)
net/mac80211/cfg.c +2 -0
@@ -515,6 +515,8 @@ static int ieee80211_config_beacon(struc
 		if (old)
 			memcpy(new->tail, old->tail, new_tail_len);
 
+	sdata->vif.bss_conf.dtim_period = new->dtim_period;
+
 	rcu_assign_pointer(sdata->u.ap.beacon, new);
 
 	synchronize_rcu();
#1 lore raw
Quoted 6 lines · Johannes Berg

In AP mode, the only mode where the parameter is supposed to be valid, we never assign it! Fix that to allow drivers to avoid parsing the TIM IE for the value.

Stable fix too?

Luis

author maintainer
#2 lore raw
Quoted 9 lines · Luis R. Rodriguez
Quoted 6 lines · Johannes Berg

In AP mode, the only mode where the parameter is supposed to be valid, we never assign it! Fix that to allow drivers to avoid parsing the TIM IE for the value.

Stable fix too?

Seems no driver actually relies on it, so I guess not.

johannes