Skip to contentSkip to conversation

input: schedule corgi_ssp and corgi_ts to be removed

PATCH New Eric Miao 6 participants 12 messages Feb 5, 2010 – Feb 11, 2010

Subsystems (2)
lore
Share & tools
lore

Eric Miao

author
#0 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

commit 31cec413e534520111716802833675f53ac99b0b

Author: Eric Miao <[email protected]>
Date:   Thu Feb 4 16:41:28 2010 -0800

input: schedule corgi_ssp and corgi_ts to be removed

Cc Richard Purdie <[email protected]>
(quoted diff) +0 -0

b/Documentation/feature-removal-schedule.txt
index 5860583..e16529e 100644

Documentation/feature-removal-schedule.txt +0 -0
@@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix

keyboard driver that
and so are difficult to maintain.
Who: Eric Miao <[email protected]>

+----------------------------
+
+What: corgi_ssp and corgi_ts driver
+When: 2.6.35
+Files: arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
+Why: The corgi touchscreen is now deprecated in favour of the generic
+ ads7846.c driver. The noise reduction technique used in corgi_ts.c
+ that to wait til vsync before ADC sampling is also inte grated into
+ ads7846 driver now. Provided that the original driver is no generic
+ and difficult to maintain, will be removed later.
+Who: Eric Miao <[email protected]>
+

#1 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Hi Eric,

Quoted 9 lines
Documentation/feature-removal-schedule.txt +0 -0
index 5860583..e16529e 100644
@@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix

keyboard driver that

Documentation/feature-removal-schedule.txt +0 -0
 	and so are difficult to maintain.
 Who:	Eric Miao <[email protected]>

Documentation/feature-removal-schedule.txt

Quoted 10 lines
Documentation/feature-removal-schedule.txt +9 -0
 
+----------------------------
+
+What:	corgi_ssp and corgi_ts driver
+When:	2.6.35
+Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
+Why:	The corgi touchscreen is now deprecated in favour of the generic
+	ads7846.c driver. The noise reduction technique used in corgi_ts.c
+	that to wait til vsync before ADC sampling is also inte grated into
+	ads7846 driver now. Provided that the original driver is no generic

s/no /not / or s/is no/isn't/

Best regards
Uwe

Quoted 3 lines
Documentation/feature-removal-schedule.txt +3 -0
+	and difficult to maintain, will be removed later.
+Who:	Eric Miao <[email protected]>
+
Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
#2 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

In reply to Eric Miao

Hello.

Quoted 9 lines · Eric Miao

commit 31cec413e534520111716802833675f53ac99b0b

Author: Eric Miao <[email protected]>
Date:   Thu Feb 4 16:41:28 2010 -0800

input: schedule corgi_ssp and corgi_ts to be removed

Cc Richard Purdie <[email protected]>

Some grammar nitpicking...

Quoted 8 lines
Documentation/feature-removal-schedule.txt +0 -0
index 5860583..e16529e 100644
@@ -554,3 +554,15 @@ Why:	We now have a generic GPIO based matrix

keyboard driver that

Documentation/feature-removal-schedule.txt +0 -0
 	and so are difficult to maintain.

Documentation/feature-removal-schedule.txt

Quoted 10 lines
Documentation/feature-removal-schedule.txt +8 -0
 Who:	Eric Miao <[email protected]>
 
+----------------------------
+
+What:	corgi_ssp and corgi_ts driver
+When:	2.6.35
+Files:	arch/arm/mach-pxa/corgi_ssp.c, drivers/input/touchscreen/corgi_ts.c
+Why:	The corgi touchscreen is now deprecated in favour of the generic
+	ads7846.c driver. The noise reduction technique used in corgi_ts.c
+	that to wait til vsync before ADC sampling is also

that's?

Quoted 2 lines

inte grated into

integrated.

Documentation/feature-removal-schedule.txt

Quoted 2 lines
Documentation/feature-removal-schedule.txt +1 -0
+	ads7846 driver now. Provided that the original driver is no generic

not generic

Documentation/feature-removal-schedule.txt

Quoted 2 lines
Documentation/feature-removal-schedule.txt +1 -0
+	and difficult to maintain, will be removed later.

it will.

Documentation/feature-removal-schedule.txt

Quoted 3 lines
Documentation/feature-removal-schedule.txt +2 -0
+Who:	Eric Miao <[email protected]>
+

WBR, Sergei

author
#3 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Quoted 4 lines
Quoted 1 line

?Some grammar nitpicking...

Grrr.... anyone has a good recommendation of English training institute for me? :-)

Patch updated as below:

#5 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

In reply to Eric Miao
Quoted 8 lines · Eric Miao

commit 31cec413e534520111716802833675f53ac99b0b

Author: Eric Miao <[email protected]>
Date:   Thu Feb 4 16:41:28 2010 -0800

input: schedule corgi_ssp and corgi_ts to be removed

Cc Richard Purdie <[email protected]>

ACK.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#6 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Quoted 5 lines · Pavel Machek
Quoted 4 lines · Eric Miao

commit 31cec413e534520111716802833675f53ac99b0b
Author: Eric Miao <[email protected]>
Date: ? Thu Feb 4 16:41:28 2010 -0800

Quoted 7 lines
Quoted 4 lines

? ? input: schedule corgi_ssp and corgi_ts to be removed

? ? Cc: Richard Purdie <[email protected]>
? ? Signed-off-by: Eric Miao <[email protected]>

ACK.

Thanks, guys.

Dmitry, I'm hoping these two patches will go through your tree please?

#7 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Quoted 11 lines · Eric Miao
Quoted 10 lines · Pavel Machek
Quoted 8 lines · Eric Miao

commit 31cec413e534520111716802833675f53ac99b0b
Author: Eric Miao <[email protected]>
Date: ? Thu Feb 4 16:41:28 2010 -0800

? ? input: schedule corgi_ssp and corgi_ts to be removed

? ? Cc: Richard Purdie <[email protected]>
? ? Signed-off-by: Eric Miao <[email protected]>

Quoted 6 lines
Quoted 2 lines

ACK.

Thanks, guys.

Dmitry, I'm hoping these two patches will go through your tree please?

I have it in next, do you want it in .33 instead?

Signature · 1 line
Dmitry
author
#8 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Quoted 12 lines · Dmitry Torokhov
Quoted 11 lines · Eric Miao
Quoted 10 lines · Pavel Machek
Quoted 8 lines · Eric Miao

commit 31cec413e534520111716802833675f53ac99b0b
Author: Eric Miao <[email protected]>
Date: ? Thu Feb 4 16:41:28 2010 -0800

? ? input: schedule corgi_ssp and corgi_ts to be removed

? ? Cc: Richard Purdie <[email protected]>
? ? Signed-off-by: Eric Miao <[email protected]>

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

ACK.

Thanks, guys.

Dmitry, I'm hoping these two patches will go through your tree please?

I have it in next, do you want it in .33 instead?

No. -next is good, thanks man.

author
#9 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Quoted 17 lines · Eric Miao
Quoted 15 lines · Dmitry Torokhov
Quoted 14 lines · Eric Miao
Quoted 12 lines · Pavel Machek
Quoted 8 lines · Eric Miao

commit 31cec413e534520111716802833675f53ac99b0b
Author: Eric Miao <[email protected]>
Date: ? Thu Feb 4 16:41:28 2010 -0800

? ? input: schedule corgi_ssp and corgi_ts to be removed

? ? Cc: Richard Purdie <[email protected]>
? ? Signed-off-by: Eric Miao <[email protected]>

ACK.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

Thanks, guys.

Dmitry, I'm hoping these two patches will go through your tree please?

I have it in next, do you want it in .33 instead?

No. -next is good, thanks man.

Dmitry,

Attached are the two patches updated, with Pavel's suggestion to make them
default to 'n' and with their Acks. Please consider re-apply, sorry for the
bother.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-input-mark-corgi-spitz-tosa-kbd-driver-deprecated.patch
Type: text/x-patch
Size: 3424 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100209/95484599/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-input-schedule-corgi_ssp-and-corgi_ts-to-be-removed.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100209/95484599/attachment-0001.bin>

#10 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Quoted 25 lines · Eric Miao
Quoted 24 lines · Eric Miao
Quoted 21 lines · Dmitry Torokhov
Quoted 11 lines · Eric Miao
Quoted 10 lines · Pavel Machek
Quoted 8 lines · Eric Miao

commit 31cec413e534520111716802833675f53ac99b0b
Author: Eric Miao <[email protected]>
Date: ? Thu Feb 4 16:41:28 2010 -0800

? ? input: schedule corgi_ssp and corgi_ts to be removed

? ? Cc: Richard Purdie <[email protected]>
? ? Signed-off-by: Eric Miao <[email protected]>

Quoted 6 lines
Quoted 2 lines

ACK.

Thanks, guys.

Dmitry, I'm hoping these two patches will go through your tree please?

I have it in next, do you want it in .33 instead?

Quoted 8 lines
Quoted 2 lines

No. -next is good, thanks man.

Dmitry,

Attached are the two patches updated, with Pavel's suggestion to make them default to 'n' and with their Acks. Please consider re-apply, sorry for the bother.

Re-applied (with just removing 'default y' instead of replacing with 'default n' which is the same thing).

Thanks.

Signature · 1 line
Dmitry
author
#11 lore raw

PATCH 1/1 input: schedule corgi_ssp and corgi_ts to be removed

Quoted 3 lines

Re-applied (with just removing 'default y' instead of replacing with 'default n' which is the same thing).

Ah, yes, that's much cleaner. Thanks Dmitry.