Skip to contentSkip to conversation

- Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

PATCH New Abhijith Das 2 participants 2 messages Feb 5, 2010 – Feb 8, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1794011848.1142141265412324522.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com

#1 lore raw

PATCH 1/1 - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one.

--Abhi

Quoted 26 lines · ----- "Abhijith Das

From: "Abhijith Das" <[email protected]>
To: "cluster-devel" <[email protected]>
Sent: Friday, February 5, 2010 5:17:56 PM GMT -06:00 US/Canada Central
Subject: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

Hi,

We need this one-liner to signal the mount helper of the 'insufficient journals' condition.

fs/gfs2/ops_fstype.c +1 -1
index d405c38..a054b52 100644
@@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int
 undo)
 		goto fail;
 	}
 
-	error = -EINVAL;
+	error = -EUSERS;
 	if (!gfs2_jindex_size(sdp)) {
 		fs_err(sdp, "no journals!\n");
Quoted 1 line

goto fail_jindex;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bz537201-kernel-upstream.patch
Type: text/x-patch
Size: 362 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20100205/6553d242/attachment.bin>

#2 lore raw

PATCH 1/1 - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

Quoted 33 lines · Abhijith Das

Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one.

--Abhi

Quoted 27 lines · ----- "Abhijith Das

From: "Abhijith Das" <[email protected]>
To: "cluster-devel" <[email protected]>
Sent: Friday, February 5, 2010 5:17:56 PM GMT -06:00 US/Canada Central
Subject: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

Hi,

We need this one-liner to signal the mount helper of the 'insufficient journals' condition.

fs/gfs2/ops_fstype.c +1 -1
index d405c38..a054b52 100644
@@ -724,7 +724,7 @@ static int init_journal(struct gfs2_sbd *sdp, int
 undo)
 		goto fail;
 	}
 
-	error = -EINVAL;
+	error = -EUSERS;
 	if (!gfs2_jindex_size(sdp)) {
 		fs_err(sdp, "no journals!\n");

goto fail_jindex;