Skip to contentSkip to conversation

hwmon w83627hf: add mfd support

PATCH In review Rodolfo Giometti 3 participants 3 messages Feb 10, 2010 – Sep 22, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon w83627hf: add mfd support

The drivers has been splitted up into two parts:

* drivers/mfd/w83627hf-core.c - detects the chip and define proper
platform devices into mfd support

* drivers/hwmon/w83627hf.c - implements the driver for hwmon
functionality only

---

Jean, can you please take a look at this patch? It should apply over your last patch.

If everything is ok I'm going to produce GPIO support too.

Rodolfo

 drivers/hwmon/Kconfig        |    1 +
 drivers/hwmon/w83627hf.c     |  374 ++++++++++++------------------------------
 drivers/mfd/Kconfig          |   15 ++
 drivers/mfd/Makefile         |    1 +
 drivers/mfd/w83627hf-core.c  |  186 +++++++++++++++++++++
 include/linux/mfd/w83627hf.h |  118 +++++++++++++
 6 files changed, 427 insertions(+), 268 deletions(-)
 create mode 100644 drivers/mfd/w83627hf-core.c
 create mode 100644 include/linux/mfd/w83627hf.h
drivers/hwmon/Kconfig +1 -0
index 700e93a..3d9b883 100644
@@ -892,6 +892,7 @@ config SENSORS_W83L786NG
 
 config SENSORS_W83627HF
 	tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF"
+	select MFD_W83627HF
 	select HWMON_VID
 	help
 	  If you say yes here you get support for the Winbond W836X7 series
drivers/hwmon/w83627hf.c +106 -268

520 lines not on this page · raw message

drivers/mfd/Kconfig +15 -0
index 570be13..1c875ed 100644
@@ -305,6 +305,21 @@ config EZX_PCAP
 	  This enables the PCAP ASIC present on EZX Phones. This is
 	  needed for MMC, TouchScreen, Sound, USB, etc..
 
+config MFD_W83627HF
+	tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF"
+	depends on MFD_CORE
+	help
+	  If you say yes here you add support for the Winbond W836X7 series
+	  of super-IO chips: the W83627HF, W83627THF, W83637HF, W83687THF and
+	  W83697HF to your platform.
+
+	  This is a multi functional device and this support defines a new
+	  platform device only. See other configuration submenus in order to
+	  enable the drivers of Winbond chip's functionalities.
+
+	  This driver can also be built as a module.  If so, the module
+	  will be called w83627hf-core.
+
 endmenu
 
 menu "Multimedia Capabilities Port drivers"
drivers/mfd/Makefile +1 -0
index f3b277b..1b25d37 100644
@@ -32,6 +32,7 @@ obj-$(CONFIG_MFD_MC13783)	+= mc13783-core.o
 obj-$(CONFIG_MFD_CORE)		+= mfd-core.o
 
 obj-$(CONFIG_EZX_PCAP)		+= ezx-pcap.o
+obj-$(CONFIG_MFD_W83627HF)	+= w83627hf-core.o
 
 obj-$(CONFIG_MCP)		+= mcp-core.o
 obj-$(CONFIG_MCP_SA11X0)	+= mcp-sa11x0.o
drivers/mfd/w83627hf-core.c new file +186 -0

186 lines not on this page · raw message

include/linux/mfd/w83627hf.h new file +118 -0

118 lines not on this page · raw message

Signature · 7 lines
1.6.3.3


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Hi Rodolfo,

Quoted 5 lines · Rodolfo Giometti

The drivers has been splitted up into two parts:

* drivers/mfd/w83627hf-core.c - detects the chip and define proper
platform devices into mfd support

Quoted 8 lines

* drivers/hwmon/w83627hf.c - implements the driver for hwmon
functionality only

---

Jean, can you please take a look at this patch? It should apply over your last patch.

Are you sure you sent the latest version of your patch? It doesn't apply on top of 2.6.33, there are 6 FAILED on drivers/hwmon/w83627hf.c. I will try fixing them myself if I must, but if you happen to have an updated version already...

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw
In reply to Rodolfo Giometti
Quoted 4 lines · Jean Delvare

Are you sure you sent the latest version of your patch? It doesn't apply on top of 2.6.33, there are 6 FAILED on drivers/hwmon/w83627hf.c. I will try fixing them myself if I must, but if you happen to have an updated version already...

Hi Jean,

finally I resumed this old project! :) I just updated it to latest kernel release... can you please trying to apply it again?

If everything goes wrong, please, let me know and I'll try to fix it up.

Ciao,

Rodolfo

Signature · 5 lines
GNU/Linux Solutions                  e-mail: [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

From 922cf9c086bc405db8024b65b3a2537cc7262f61 Mon Sep 17 00:00:00 2001
From: Rodolfo Giometti <[email protected]>
Date: Mon, 29 Aug 2011 14:41:48 +0200
Subject: [PATCH 1/2] hwmon w83627hf: add mfd support

The drivers has been splitted up into two parts:

* drivers/mfd/w83627hf-core.c - detects the chip and define proper
platform devices into mfd support

* drivers/hwmon/w83627hf.c - implements the driver for hwmon
functionality only

---
 drivers/hwmon/Kconfig        |    1 +
 drivers/hwmon/w83627hf.c     |  331 +++++++++++-------------------------------
 drivers/mfd/Kconfig          |   15 ++
 drivers/mfd/Makefile         |    1 +
 drivers/mfd/w83627hf-core.c  |  186 +++++++++++++++++++++++
 include/linux/mfd/w83627hf.h |  118 +++++++++++++++
 6 files changed, 407 insertions(+), 245 deletions(-)
 create mode 100644 drivers/mfd/w83627hf-core.c
 create mode 100644 include/linux/mfd/w83627hf.h
drivers/hwmon/Kconfig +1 -0
index 5f888f7..fb5b5b3 100644
@@ -1271,6 +1271,7 @@ config SENSORS_W83L786NG
 
 config SENSORS_W83627HF
 	tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF"
+	select MFD_W83627HF
 	select HWMON_VID
 	help
 	  If you say yes here you get support for the Winbond W836X7 series
drivers/hwmon/w83627hf.c +86 -245

437 lines not on this page · raw message

drivers/mfd/Kconfig +15 -0
index 6ca938a..22b536e 100644
@@ -731,6 +731,21 @@ config MFD_TPS65910
 config TPS65911_COMPARATOR
 	tristate
 
+config MFD_W83627HF
+	tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF"
+	depends on MFD_CORE
+	help
+	  If you say yes here you add support for the Winbond W836X7 series
+	  of super-IO chips: the W83627HF, W83627THF, W83637HF, W83687THF and
+	  W83697HF to your platform.
+
+	  This is a multi functional device and this support defines a new
+	  platform device only. See other configuration submenus in order to
+	  enable the drivers of Winbond chip's functionalities.
+
+	  This driver can also be built as a module.  If so, the module
+	  will be called w83627hf-core.
+
 endif # MFD_SUPPORT
 
 menu "Multimedia Capabilities Port drivers"
drivers/mfd/Makefile +1 -0
index d7d47d2..b59e1db 100644
@@ -48,6 +48,7 @@ obj-$(CONFIG_MFD_MC13XXX)	+= mc13xxx-core.o
 obj-$(CONFIG_MFD_CORE)		+= mfd-core.o
 
 obj-$(CONFIG_EZX_PCAP)		+= ezx-pcap.o
+obj-$(CONFIG_MFD_W83627HF)	+= w83627hf-core.o
 
 obj-$(CONFIG_MCP)		+= mcp-core.o
 obj-$(CONFIG_MCP_SA11X0)	+= mcp-sa11x0.o
drivers/mfd/w83627hf-core.c new file +186 -0

186 lines not on this page · raw message

include/linux/mfd/w83627hf.h new file +118 -0

118 lines not on this page · raw message

Signature · 1 line
1.7.0.4

From f5044c05376e7d515a2d8a9b854784307dba3a18 Mon Sep 17 00:00:00 2001
From: Rodolfo Giometti <[email protected]>
Date: Mon, 29 Aug 2011 15:14:29 +0200
Subject: [PATCH 2/2] gpio w83627hf: add gpio support

---
 drivers/gpio/Kconfig         |   12 +
 drivers/gpio/Makefile        |    1 +
 drivers/gpio/w83627hf_gpio.c |  492 ++++++++++++++++++++++++++++++++++++++++++
 drivers/mfd/w83627hf-core.c  |    3 +
 4 files changed, 508 insertions(+), 0 deletions(-)
 create mode 100644 drivers/gpio/w83627hf_gpio.c
drivers/gpio/Kconfig +12 -0
index 2967002..065cf5b 100644
@@ -152,6 +152,18 @@ config GPIO_VX855
 	  additional drivers must be enabled in order to use the
 	  functionality of the device.
 
+config GPIO_W83627HF
+	tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF"
+	select MFD_CORE
+	select MFD_W83627HF
+	help
+	  If you say yes here you get support for the Winbond W836X7 series
+	  of sensor chips: the W83627HF, W83627THF, W83637HF, W83687THF and
+	  W83697HF.
+
+	  This driver can also be built as a module.  If so, the module
+	  will be called w83627hf.
+
 comment "I2C GPIO expanders:"
 
 config GPIO_MAX7300
drivers/gpio/Makefile +1 -0
index b605f8e..df527d0 100644
@@ -45,6 +45,7 @@ obj-$(CONFIG_GPIO_RDC321X)	+= rdc321x-gpio.o
 obj-$(CONFIG_GPIO_JANZ_TTL)	+= janz-ttl.o
 obj-$(CONFIG_GPIO_SX150X)	+= sx150x.o
 obj-$(CONFIG_GPIO_VX855)	+= vx855_gpio.o
+obj-$(CONFIG_GPIO_W83627HF)	+= w83627hf_gpio.o
 obj-$(CONFIG_GPIO_ML_IOH)	+= ml_ioh_gpio.o
 obj-$(CONFIG_AB8500_GPIO)       += ab8500-gpio.o
 obj-$(CONFIG_GPIO_TPS65910)	+= tps65910-gpio.o
drivers/gpio/w83627hf_gpio.c new file +492 -0

492 lines not on this page · raw message

drivers/mfd/w83627hf-core.c +3 -0
index 3496a6b..41a4764 100644
@@ -59,6 +59,9 @@ static struct mfd_cell cells[] = {
 	{
 		.name		= DRVNAME "_hwmon",
 	},
+	{
+		.name		= DRVNAME "_gpio",
+	},
 };
 
 #define W627_DEVID		0x52
Signature · 1 line
1.7.0.4

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors