mtd/nand: fix build failure caused by typo
Subsystems (2)
PATCH 1/1 mtd/nand: fix build failure caused by typo
From: Peter Huewe <[email protected]>
Fix a build failure introduced by the patch
mtd: orion_nand.c: add error handling and use resource_size()
The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.
---
drivers/mtd/nand/orion_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/orion_nand.c renamed from drivers/mtd/nand/orion_nand.c~mtd-nand-fix-build-failure-caused-by-typo +1 -1
@@ -92,7 +92,7 @@ static int __init orion_nand_probe(struc res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );if (!res) { - err = -ENODEV ; + ret = -ENODEV ; goto no_res; }
_
Hello Andrew,
Quoted 8 lines
From: Peter Huewe <[email protected]>
Fix a build failure introduced by the patch
mtd:
orion_nand.c: add error handling and useresource_size()The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.
why did you add a ? to the subject? IMHO it should go in 2.6.33 as it's an obvious build fix.
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 6 lines · Uwe Kleine-König
Hello Andrew,
Quoted 4 lines
From: Peter Huewe <[email protected]>
Fix a build failure introduced by the patch
Quoted 7 lines
Quoted 4 lines
mtd:
orion_nand.c: add error handling and useresource_size()The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.
why did you add a ? to the subject? IMHO it should go in 2.6.33 as it's an obvious build fix.
The build error isn't in 2.6.33 though -- it's only in linux-next.
Patch applied; thanks.
Signature · 2 lines
David Woodhouse Open Source Technology Centre [email protected] Intel Corporation
Quoted 12 lines · David Woodhouse
Quoted 11 lines · Uwe Kleine-König
Hello Andrew,
Quoted 8 lines
From: Peter Huewe <[email protected]>
Fix a build failure introduced by the patch
mtd:
orion_nand.c: add error handling and useresource_size()The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.
Quoted 6 lines
Quoted 2 lines
why did you add a ? to the subject? IMHO it should go in 2.6.33 as it's an obvious build fix.
The build error isn't in 2.6.33 though -- it's only in linux-next.
Patch applied; thanks.
Oh, right. We were all confused :-) The problem is solved now.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)
Quoted 8 lines · On Tue, 2010-02-02 at 14:12 -0800, [email protected] wrote:
From: Peter Huewe <[email protected]>
Fix a build failure introduced by the patch
mtd:
orion_nand.c: add error handling and useresource_size()The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.
Andrew,
I think you should send this fix to Linus, since this is a build fix. dwmw2 seem to bu unavailable now.
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)
Quoted 7 lines · On Tue, 09 Feb 2010 14:13:09 +0200 Artem Bityutskiy <[email protected]> wrote:
Quoted 6 lines · On Tue, 2010-02-02 at 14:12 -0800, [email protected] wrote:
From: Peter Huewe <[email protected]>
Fix a build failure introduced by the patch
mtd:
orion_nand.c: add error handling and useresource_size()
Quoted 7 lines
Quoted 2 lines
The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.
Andrew,
I think you should send this fix to Linus, since this is a build fix. dwmw2 seem to bu unavailable now.
OK, no probs, thanks.