bnx2 limits user-specified advertised speeds to one
Subsystems (2)
Hi
A customer has noted that when attempting to change the advertised speeds setting on card using a bnx2 driver, the driver advertises either all available speeds or just one. In other words, if a user attempts to set multiple advertised speeds, the settings will not be honored.
Looking at the code in bnx2_set_settings, the checks for 10baseT and 100baseT make an assumption that the user provided only 1 speed setting.
e1000 and e1000e work correctly when the user specifies multiple advertised speeds.
Before attempting to fix this, I wanted to ask if there was a reason for the current functionality.
Thanks
-vlad
Quoted 7 lines · Vlad Yasevich
Hi
A customer has noted that when attempting to change the advertised speeds setting on card using a bnx2 driver, the driver advertises either all available speeds or just one. In other words, if a user attempts to set multiple advertised speeds, the settings will not be honored.
Quoted 9 lines
Looking at the code in
bnx2_set_settings, the checks for 10baseT and 100baseT make an assumption that the user provided only 1 speed setting.e1000 and e1000e work correctly when the user specifies multiple advertised speeds.
Before attempting to fix this, I wanted to ask if there was a reason for the current functionality.
Probably code to handle limitations in older versions of the ethtool program. There is no reason for it to be like this anymore. I'll fix this in my next patch set. Thanks for reporting this.
Quoted 14 lines · Michael Chan
Quoted 13 lines · Vlad Yasevich
Hi
A customer has noted that when attempting to change the advertised speeds setting on card using a bnx2 driver, the driver advertises either all available speeds or just one. In other words, if a user attempts to set multiple advertised speeds, the settings will not be honored.
Looking at the code in
bnx2_set_settings, the checks for 10baseT and 100baseT make an assumption that the user provided only 1 speed setting.e1000 and e1000e work correctly when the user specifies multiple advertised speeds.
Quoted 7 lines
Quoted 3 lines
Before attempting to fix this, I wanted to ask if there was a reason for the current functionality.
Probably code to handle limitations in older versions of the ethtool program. There is no reason for it to be like this anymore. I'll fix this in my next patch set. Thanks for reporting this.
Older versions of ethtool can request invalid advertising masks (including flags not set in the supported mask) and do not enable advertising of 10G modes. In the out-of-tree version of sfc we use this workaround:
/* Older versions of ethtool don't set all the right bits when
* turning autoneg on with no speed/duplex specified. But they
* always set more than one bit in this case, so test for that.
* Allow overriding this in ethtool 6 by setting
* ADVERTISED_Autoneg = 0x40.
*/
if (ecmd->advertising & (ecmd->advertising - 1) &&
!(ecmd->advertising & ADVERTISED_Autoneg))
ecmd->advertising = ecmd->supported;Ben.
Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.