Skip to contentSkip to conversation

mac80211: fix netdev rename

PATCH In review Johannes Berg 2 participants 2 messages Feb 12, 2010 – Feb 15, 2010 mac80211

lore
Share & tools
lore

Johannes Berg

author maintainer
#0 lore raw

PATCH 1/1 mac80211: fix netdev rename

Fix a copy bug introduced by

commit 47846c9b0c10808d9337d2e7d09361f3e0a0a71a
Author: Johannes Berg <[email protected]>
Date: Wed Nov 25 17:46:19 2009 +0100

mac80211: reduce reliance on netdev

This manifested itself only in debug messages
and in the debugfs rename failure that would
always happen due to trying to rename the dir
over itself.

---
 net/mac80211/iface.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/mac80211/iface.c +1 -1
@@ -1031,7 +1031,7 @@ static int netdev_notify(struct notifier
 
 	sdata = IEEE80211_DEV_TO_SUB_IF(dev);
 
-	memcpy(sdata->name, sdata->name, IFNAMSIZ);
+	memcpy(sdata->name, dev->name, IFNAMSIZ);
 
 	ieee80211_debugfs_rename_netdev(sdata);
 	return 0;
Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines · Johannes Berg

Fix a copy bug introduced by

commit 47846c9b0c10808d9337d2e7d09361f3e0a0a71a
Author: Johannes Berg <[email protected]>
Date: Wed Nov 25 17:46:19 2009 +0100

mac80211: reduce reliance on netdev

Quoted 7 lines

This manifested itself only in debug messages
and in the debugfs rename failure that would
always happen due to trying to rename the dir
over itself.

Signature · 2 lines
Regards,
Pavel Roskin