Skip to contentSkip to conversation

Staging: wlan-ng: fix most of the style issues in hfa384x.h

PATCH In review Alessandro Ghedini 2 participants 2 messages Feb 14, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Staging: wlan-ng: fix most of the style issues in hfa384x.h

This patch fixes all the errors and the majority of the warnings found with checkpatch.pl script in hfa384x.h, following Gábor Stefanik hints

---
 drivers/staging/wlan-ng/hfa384x.h |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +2 -8
index 8e39f76..3d440f8 100644
@@ -63,15 +63,9 @@
 /*--- Mins & Maxs -----------------------------------*/
 #define		HFA384x_PORTID_MAX		((u16)7)
 #define		HFA384x_NUMPORTS_MAX		((u16)(HFA384x_PORTID_MAX+1))
-#define		HFA384x_PDR_LEN_MAX		((u16)512) 	/*
-								 * in bytes,
-								 * from EK
-								 */
+#define		HFA384x_PDR_LEN_MAX	((u16)512) 	/* in bytes, from EK */
 #define		HFA384x_PDA_RECS_MAX		((u16)200)	/* a guess */
-#define		HFA384x_PDA_LEN_MAX		((u16)1024)	/*
-								 * in bytes,
-								 * from EK
-								 */
+#define		HFA384x_PDA_LEN_MAX	((u16)1024)	/* in bytes, from EK*/
 #define		HFA384x_SCANRESULT_MAX		((u16)31)
 #define		HFA384x_HSCANRESULT_MAX		((u16)31)
 #define		HFA384x_CHINFORESULT_MAX	((u16)16)
Signature · 1 line
1.6.6.2
#1 lore raw

You posted the wrong patch - this is only an interdiff.

Also, it might be a good idea to reduce the spacing for all entries, not just these "overdone" ones, to keep them lined-up nicely.

Quoted 38 lines · Alessandro Ghedini

This patch fixes all the errors and the majority of the warnings found with checkpatch.pl script in hfa384x.h, following Gábor Stefanik hints

---
 drivers/staging/wlan-ng/hfa384x.h |   10 ++--------

 1 files changed, 2 insertions(+), 8 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +2 -9
index 8e39f76..3d440f8 100644
@@ -63,15 +63,9 @@
  /*--- Mins & Maxs -----------------------------------*/
  #define                HFA384x_PORTID_MAX              ((u16)7)
  #define                HFA384x_NUMPORTS_MAX            ((u16)(HFA384x_PORTID_MAX+1))
-#define                HFA384x_PDR_LEN_MAX             ((u16)512)      /*
-                                                                * in bytes,
-                                                                * from EK
-                                                                */
+#define                HFA384x_PDR_LEN_MAX     ((u16)512)      /* in bytes, from EK */
  #define                HFA384x_PDA_RECS_MAX            ((u16)200)      /* a guess */
-#define                HFA384x_PDA_LEN_MAX             ((u16)1024)     /*
-                                                                * in bytes,
-                                                                * from EK
-                                                                */
+#define                HFA384x_PDA_LEN_MAX     ((u16)1024)     /* in bytes, from EK*/
  #define                HFA384x_SCANRESULT_MAX          ((u16)31)
  #define                HFA384x_HSCANRESULT_MAX         ((u16)31)
  #define                HFA384x_CHINFORESULT_MAX        ((u16)16)
--

1.6.6.2

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Signature · 1 line
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)