Skip to contentSkip to conversation

: skbedit: use get_u32 for parsing mark

PATCH New jamal 1 participant 1 message Feb 15, 2010

Subsystems (2)
lore
Share & tools
lore

jamal

author
#0 lore raw

PATCH 1/1 : skbedit: use get_u32 for parsing mark

parsing a mark as a classid allows for acceptance of strange informal input.

cheers,
jamal

commit aad0da6507ff8a95a63ed8e529c05f52be5b0e75

Author: Jamal Hadi Salim <[email protected]>
Date:   Mon Feb 15 06:45:29 2010 -0500

skbedit: use get_u32 for parsing mark

get_u32 is the more appropriate parser for a mark.

tc/m_skbedit.c +1 -1
index 5d1a96a..990b9c7 100644
@@ -86,7 +86,7 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 		} else if (matches(*argv, "mark") == 0) {
 			flags |= SKBEDIT_F_MARK;
 			NEXT_ARG();
-			if (get_tc_classid(&mark, *argv)) {
+			if (get_u32(&mark, *argv, 0)) {
 				fprintf(stderr, "Illegal mark\n");
 				return -1;
 			}