Skip to contentSkip to conversation

dmatest: correct raid6 PQ test

PATCH Applied Anatolij Gustschin 2 participants 2 messages Feb 15, 2010 – Mar 1, 2010 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmatest: correct raid6 PQ test

The number of PQ sources specified by module parameter "pq_sources" is always forced odd to fit into dmatest's destination verificaton scheme. But number of PQ sources and coefficients as passed to the driver's prep_dma_pq() is not adjusted accordingly.

Fix it now to get correct PQ testing results in the case passed "pq_sources" parameter is even.

Cc Dan Williams <[email protected]>
Cc Maciej Sosnowski <[email protected]>
---
 drivers/dma/dmatest.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/dma/dmatest.c +3 -3
index 948d563..9ae3d11 100644
@@ -237,7 +237,7 @@ static int dmatest_func(void *data)
 	dma_cookie_t		cookie;
 	enum dma_status		status;
 	enum dma_ctrl_flags 	flags;
-	u8			pq_coefs[pq_sources];
+	u8			pq_coefs[pq_sources + 1];
 	int			ret;
 	int			src_cnt;
 	int			dst_cnt;
@@ -257,7 +257,7 @@ static int dmatest_func(void *data)
 	} else if (thread->type == DMA_PQ) {
 		src_cnt = pq_sources | 1; /* force odd to ensure dst = src */
 		dst_cnt = 2;
-		for (i = 0; i < pq_sources; i++)
+		for (i = 0; i < src_cnt; i++)
 			pq_coefs[i] = 1;
 	} else
 		goto err_srcs;
@@ -355,7 +355,7 @@ static int dmatest_func(void *data)
 			for (i = 0; i < dst_cnt; i++)
 				dma_pq[i] = dma_dsts[i] + dst_off;
 			tx = dev->device_prep_dma_pq(chan, dma_pq, dma_srcs,
-						     pq_sources, pq_coefs,
+						     src_cnt, pq_coefs,
 						     len, flags);
 		}
 
Signature · 1 line
1.6.3.3
Applied
#1 lore raw
Quoted 8 lines · Anatolij Gustschin

The number of PQ sources specified by module parameter "pq_sources" is always forced odd to fit into dmatest's destination verificaton scheme. But number of PQ sources and coefficients as passed to the driver's prep_dma_pq() is not adjusted accordingly.

Fix it now to get correct PQ testing results in the case passed "pq_sources" parameter is even.

Quoted 6 lines
Cc Dan Williams <[email protected]>
Cc Maciej Sosnowski <[email protected]>

---
 drivers/dma/dmatest.c |    6 +++---

 1 files changed, 3 insertions(+), 3 deletions(-)

Applied... and the same problem for the xor case (I'll fix that up).

--
Dan