Skip to contentSkip to conversation

ethtool: Don't flush n-tuple list from ethtool_reset()

PATCH In review Ben Hutchings 3 participants 3 messages Feb 17, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethtool: Don't flush n-tuple list from ethtool_reset()

The n-tuple list should be flushed if and only if the ETH_RESET_FILTER flag is set and the driver is able to reset filtering/flow direction hardware without also resetting a component whose flag is not set. This test is best left to the driver.

---
 net/core/ethtool.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
net/core/ethtool.c +0 -3
index d08a0c7..31b1edd 100644
@@ -654,9 +654,6 @@ static int ethtool_reset(struct net_device *dev, char __user *useraddr)
 	if (copy_from_user(&reset, useraddr, sizeof(reset)))
 		return -EFAULT;
 
-	/* Clear ethtool n-tuple list */
-	ethtool_ntuple_flush(dev);
-
 	ret = dev->ethtool_ops->reset(dev, &reset.data);
 	if (ret)
 		return ret;
Signature · 6 lines
1.6.2.5

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
#1 lore raw
Quoted 6 lines · Ben Hutchings

The n-tuple list should be flushed if and only if the ETH_RESET_FILTER flag is set and the driver is able to reset filtering/flow direction hardware without also resetting a component whose flag is not set. This test is best left to the driver.

Yes, this was the intent. Thanks for cleaning this bit up in the ethtool core.

-PJ

maintainer
#2 lore raw

From: "Waskiewicz Jr, Peter P" <[email protected]>
Date: Wed, 17 Feb 2010 11:29:33 -0800 (Pacific Standard Time)

Quoted 11 lines · Ben Hutchings
Quoted 7 lines

The n-tuple list should be flushed if and only if the ETH_RESET_FILTER flag is set and the driver is able to reset filtering/flow direction hardware without also resetting a component whose flag is not set. This test is best left to the driver.

Yes, this was the intent. Thanks for cleaning this bit up in the ethtool core.

Patch applied, thanks everyone.