Skip to contentSkip to conversation

: Fixing wrong target level being passed during Core DVFS.

PATCH In review Thara Gopinath 2 participants 2 messages Feb 23, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 : Fixing wrong target level being passed during Core DVFS.

As per the current implementaion (u8*)&target_level is being passed to freq_to_opp in set_opp. This would result in updating just the first 8 bits of a u32 variable. Later target_level is passed to resource_set_opp_level as a u32 parameter. This maens
a. Initially target_level was 0xabcdefgh.
b. freq_to_opp updates the lower eight bits of target_level to 0xXX. Now target_level = 0xabcdefXX.
c. We pass 0xabcdefXX as target_level to resource_set_opp_level when we want to pass just 0xXX.
This is leading to some corrupted bookkeeping later on in the dvfs path.

This patch ensures that target_level passed to resource_set_opp_level is actually the level that is intended by freq_to_opp API.

---
 arch/arm/mach-omap2/resource34xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/resource34xx.c +1 -0
index 3604a38..2c850a2 100644
@@ -478,6 +478,7 @@ int set_opp(struct shared_resource *resp, u32 target_level)
 		/* uh uh.. no OPPs?? */
 		BUG_ON(IS_ERR(oppx));
 
+		target_level = 0;
 		ret = freq_to_opp((u8 *)&target_level, OPP_L3, req_l3_freq);
 		/* we dont expect this to fail */
 		BUG_ON(ret);
Signature · 1 line
1.5.4.7
#1 lore raw
Quoted 12 lines · Thara Gopinath

As per the current implementaion (u8*)&target_level is being passed to freq_to_opp in set_opp. This would result in updating just the first 8 bits of a u32 variable. Later target_level is passed to resource_set_opp_level as a u32 parameter. This maens
a. Initially target_level was 0xabcdefgh.
b. freq_to_opp updates the lower eight bits of target_level to 0xXX. Now target_level = 0xabcdefXX.
c. We pass 0xabcdefXX as target_level to resource_set_opp_level when we want to pass just 0xXX.
This is leading to some corrupted bookkeeping later on in the dvfs path.

Quoted 5 lines

This patch ensures that target_level passed to resource_set_opp_level is actually the level that is intended by freq_to_opp API.

Thanks, applying to pm-wip-opp after cleaning up the formatting in the changelog to be a little more readable.

Kevin

Quoted 18 lines
---
 arch/arm/mach-omap2/resource34xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/resource34xx.c +1 -0
index 3604a38..2c850a2 100644
@@ -478,6 +478,7 @@ int set_opp(struct shared_resource *resp, u32 target_level)
 		/* uh uh.. no OPPs?? */
 		BUG_ON(IS_ERR(oppx));
 
+		target_level = 0;
 		ret = freq_to_opp((u8 *)&target_level, OPP_L3, req_l3_freq);
 		/* we dont expect this to fail */
 		BUG_ON(ret);
Signature · 1 line
1.5.4.7