Skip to contentSkip to conversation

DSPBRIDGE: Remove GT_TRACE conditional macro

PATCH RESEND New Omar Ramirez Luna 1 participant 1 message Feb 23, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 DSPBRIDGE: Remove GT_TRACE conditional macro

Please discard previous patch, I think it is best to place DBC* under CONFIG_BRIDGE_DEBUG instead of printing by default.
---

Remove GT_TRACE conditional macro, replace in needed places for CONFIG_BRIDGE_DEBUG

---
 arch/arm/plat-omap/include/dspbridge/dbc.h |    6 +-----
 drivers/dsp/bridge/Makefile                |    5 -----
 drivers/dsp/bridge/rmgr/drv.c              |    2 +-
 drivers/dsp/bridge/rmgr/drv_interface.c    |    2 --
 4 files changed, 2 insertions(+), 13 deletions(-)
arch/arm/plat-omap/include/dspbridge/dbc.h +1 -5
index c4bf803..90cad03 100644
@@ -25,12 +25,8 @@
 #ifndef DBC_
 #define DBC_
 
-#ifndef GT_TRACE
-#define GT_TRACE 0	    /* 0 = "trace compiled out"; 1 = "trace active" */
-#endif
-
 /* Assertion Macros: */
-#if GT_TRACE
+#ifdef CONFIG_BRIDGE_DEBUG
 
 #define DBC_Assert(exp) \
     if (!(exp)) \
drivers/dsp/bridge/Makefile +0 -5
index 11d92cd..11f48cb 100644
@@ -20,11 +20,6 @@ libhw = hw/hw_prcm.o hw/hw_dspssC64P.o hw/hw_mmu.o hw/hw_mbox.o
 bridgedriver-objs = $(libgen) $(libservices) $(libwmd) $(libpmgr) $(librmgr) \
 			$(libdload) $(libhw)
 
-# Debug
-ifeq ($(CONFIG_BRIDGE_DEBUG),y)
-ccflags-y += -DGT_TRACE
-endif
-
 #Machine dependent
 ccflags-y += -D_TI_ -D_DB_TIOMAP -DTMS32060 \
 		-DTICFG_PROC_VER -DTICFG_EVM_TYPE -DCHNL_SMCLASS \
drivers/dsp/bridge/rmgr/drv.c +1 -1
index ecd5905..a2737fd 100644
@@ -513,7 +513,7 @@ DSP_STATUS DRV_GetDevObject(u32 uIndex, struct DRV_OBJECT *hDrvObject,
 			   struct DEV_OBJECT **phDevObject)
 {
 	DSP_STATUS status = DSP_SOK;
-#if GT_TRACE	/* pDrvObject is used only for Assertions and debug messages.*/
+#ifdef CONFIG_BRIDGE_DEBUG	/* used only for Assertions and debug messages.*/
 	struct DRV_OBJECT *pDrvObject = (struct DRV_OBJECT *)hDrvObject;
 #endif
 	struct DEV_OBJECT *pDevObject;
drivers/dsp/bridge/rmgr/drv_interface.c +0 -2
index 3d3f02d..fa97caa 100644
@@ -533,9 +533,7 @@ err:
 /* This function maps kernel space memory to user space memory. */
 static int bridge_mmap(struct file *filp, struct vm_area_struct *vma)
 {
-#if GT_TRACE
 	u32 offset = vma->vm_pgoff << PAGE_SHIFT;
-#endif
 	u32 status;
 
 	DBC_Assert(vma->vm_start < vma->vm_end);
Signature · 1 line
1.6.2.4