Staging: comedi: poc: Adding some KERN_ facility level
PATCH 1/1 Staging: comedi: poc: Adding some KERN_ facility level
From: Chihau Chau <[email protected]>
This fixes some coding style issues like include KERN_ facility levels in some printk() and one trailing whitespace error.
Signed-off-by Chihau Chau <[email protected]>
--- drivers/staging/comedi/drivers/poc.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-)
drivers/staging/comedi/drivers/poc.c +5 -6
@@ -122,22 +122,21 @@ static int poc_attach(struct comedi_device *dev, struct comedi_devconfig *it)unsigned int iosize; iobase = it->options[0 ]; -printk ("comedi%d: poc: using %s iobase 0x%lx\n" , dev->minor, +printk (KERN_INFO "comedi%d: poc: using %s iobase 0x%lx\n" , dev->minor, this_board->name, iobase); dev->board_name = this_board->name;if (iobase ==0 ) { -printk ("io base address required\n" ); +printk (KERN_ERR "io base address required\n" );return -EINVAL ; } iosize = this_board->iosize;/* check if io addresses are available */ if (!request_region (iobase, iosize,"dac02" )) { -printk - ("I/O port conflict: failed to allocate ports 0x%lx to " -"0x%lx\n" , iobase, iobase + iosize -1 ); +printk (KERN_ERR "I/O port conflict: failed to allocate ports " +"0x%lx to 0x%lx\n" , iobase, iobase + iosize -1 );return -EIO ; } dev->iobase = iobase;
@@ -158,7 +157,7 @@ static int poc_attach(struct comedi_device *dev, struct comedi_devconfig *it) s->insn_bits = this_board->insnbits;if (s->type ==COMEDI_SUBD_AO || s->type ==COMEDI_SUBD_DO ) s->subdev_flags =SDF_WRITABLE ; - +return 0 ; }
Signature · 1 line
1.5.6.3
Hi Chihau,
Quoted 6 lines · Chihau Chau
From: Chihau Chau <[email protected]>
This fixes some coding style issues like include
KERN_facility levels in someprintk()and one trailing whitespace error.Signed-off-by Chihau Chau <[email protected]>
While you are at it, instead of using printk(KERN_INFO ""); you can also use pr_info();
Cheers,
Ameya.