sisusbvga: Remove the BKL from ioctl
Subsystems (2)
PATCH 1/1 sisusbvga: Remove the BKL from ioctl
Seems to me that BKL is not needed here because necessary locking is already provided by mutex sisusb->lock.
Also change the returned value to long.
Signed-off-by Alessio Igor Bogani <[email protected]>
--- drivers/usb/misc/sisusbvga/sisusb.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/usb/misc/sisusbvga/sisusb.c +1 -4
@@ -47,7 +47,6 @@#include <linux/spinlock.h> #include <linux/kref.h> #include <linux/usb.h> -#include <linux/smp_lock.h> #include <linux/vmalloc.h> #include "sisusb.h"
@@ -2964,13 +2963,12 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)struct sisusb_usb_data *sisusb;struct sisusb_info x;struct sisusb_command y; -int retval =0 ; +long retval =0 ;u32 __user *argp = (u32 __user *)arg;if (!(sisusb = (struct sisusb_usb_data *)file->private_data))return -ENODEV ; -lock_kernel ();mutex_lock (&sisusb->lock);/* Sanity check */
@@ -3029,7 +3027,6 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg) err_out:mutex_unlock (&sisusb->lock); -unlock_kernel ();return retval; }
Signature · 1 line
1.6.3.3