Skip to contentSkip to conversation

DRM: fix headers_check warnings

PATCH In review Jaswinder Singh Rajput 3 participants 3 messages Feb 27, 2010 – Mar 2, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DRM: fix headers_check warnings

Fixed following headers_check warnings:
CHECK include/drm (14 files)
include/drm/drm_mode.h:84: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>

Cc Kristian Høgsberg <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dave Airlie <[email protected]>
---
 include/drm/drm_mode.h   |    2 ++
 include/drm/i915_drm.h   |    1 +
 include/drm/mga_drm.h    |    1 +
 include/drm/radeon_drm.h |    1 +
 include/drm/via_drm.h    |    1 +
 5 files changed, 6 insertions(+), 0 deletions(-)
include/drm/drm_mode.h +2 -0
index c5ba163..c5aa66d 100644
@@ -27,6 +27,8 @@
 #ifndef _DRM_MODE_H
 #define _DRM_MODE_H
 
+#include <linux/types.h>
+
 #define DRM_DISPLAY_INFO_LEN	32
 #define DRM_CONNECTOR_NAME_LEN	32
 #define DRM_DISPLAY_MODE_LEN	32
include/drm/i915_drm.h +1 -0
index b64a8d7..5cf7f5b 100644
@@ -27,6 +27,7 @@
 #ifndef _I915_DRM_H_
 #define _I915_DRM_H_
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* Please note that modifications to all structs defined here are
include/drm/mga_drm.h +1 -0
index 3ffbc47..ae23df9 100644
@@ -35,6 +35,7 @@
 #ifndef __MGA_DRM_H__
 #define __MGA_DRM_H__
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* WARNING: If you change any of these defines, make sure to change the
include/drm/radeon_drm.h +1 -0
index 39537f3..459ff45 100644
@@ -33,6 +33,7 @@
 #ifndef __RADEON_DRM_H__
 #define __RADEON_DRM_H__
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* WARNING: If you change any of these defines, make sure to change the
include/drm/via_drm.h +1 -0
index fd11a5b..23880b0 100644
@@ -24,6 +24,7 @@
 #ifndef _VIA_DRM_H_
 #define _VIA_DRM_H_
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* WARNING: These defines must be the same as what the Xserver uses.
Signature · 1 line
1.6.6
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sat, 27 Feb 2010 14:57:36 +0530 Jaswinder Singh Rajput wrote:

Fixed following headers_check warnings:
CHECK include/drm (14 files)
include/drm/drm_mode.h:84: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>

Quoted 4 lines
Cc Kristian Høgsberg <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dave Airlie <[email protected]>

Thanks much.

Quoted 63 lines
---
 include/drm/drm_mode.h   |    2 ++
 include/drm/i915_drm.h   |    1 +
 include/drm/mga_drm.h    |    1 +
 include/drm/radeon_drm.h |    1 +
 include/drm/via_drm.h    |    1 +
 5 files changed, 6 insertions(+), 0 deletions(-)
include/drm/drm_mode.h +2 -0
index c5ba163..c5aa66d 100644
@@ -27,6 +27,8 @@
 #ifndef _DRM_MODE_H
 #define _DRM_MODE_H
 
+#include <linux/types.h>
+
 #define DRM_DISPLAY_INFO_LEN	32
 #define DRM_CONNECTOR_NAME_LEN	32
 #define DRM_DISPLAY_MODE_LEN	32
include/drm/i915_drm.h +1 -0
index b64a8d7..5cf7f5b 100644
@@ -27,6 +27,7 @@
 #ifndef _I915_DRM_H_
 #define _I915_DRM_H_
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* Please note that modifications to all structs defined here are
include/drm/mga_drm.h +1 -0
index 3ffbc47..ae23df9 100644
@@ -35,6 +35,7 @@
 #ifndef __MGA_DRM_H__
 #define __MGA_DRM_H__
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* WARNING: If you change any of these defines, make sure to change the
include/drm/radeon_drm.h +1 -0
index 39537f3..459ff45 100644
@@ -33,6 +33,7 @@
 #ifndef __RADEON_DRM_H__
 #define __RADEON_DRM_H__
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* WARNING: If you change any of these defines, make sure to change the
include/drm/via_drm.h +0 -0
index fd11a5b..23880b0 100644

include/drm/via_drm.h line 30

Quoted 7 lines
include/drm/via_drm.h +1 -0
@@ -24,6 +24,7 @@
 #ifndef _VIA_DRM_H_
 #define _VIA_DRM_H_
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* WARNING: These defines must be the same as what the Xserver uses.

---
~Randy

#2 lore raw
In reply to Jaswinder Singh Rajput
Quoted 9 lines · Jaswinder Singh Rajput

Fixed following headers_check warnings:
CHECK include/drm (14 files)
include/drm/drm_mode.h:84: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>

These files are shared with BSD, afaik, and they get the linux/types.h include from drm.h.

Cheers,
Julien

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--