hw-breakpoint fix
Ingo,
Please pull the perf/urgent branch that can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
perf/urgent
Thanks,
Frederic
---
Frederic Weisbecker (1):
hw-breakpoints: Remove stub unthrottle callback
arch/x86/kernel/hw_breakpoint.c | 5 ----- kernel/hw_breakpoint.c | 1 - 2 files changed, 0 insertions(+), 6 deletions(-)
---
commit 1e259e0a9982078896f3404240096cbea01daca4
Author: Frederic Weisbecker <[email protected]> Date: Sun Feb 28 20:51:15 2010 +0100
hw-breakpoints: Remove stub unthrottle callback
We support event unthrottling in breakpoint events. It means that if we have more than sysctl_perf_event_sample_rate/HZ, perf will throttle, ignoring subsequent events until the next tick.
So if ptrace exceeds this max rate, it will omit events, which breaks the ptrace determinism that is supposed to report every triggered breakpoints. This is likely to happen if we set sysctl_perf_event_sample_rate to 1.
This patch removes support for unthrottling in breakpoint events to break throttling and restore ptrace determinism.
arch/x86/kernel/hw_breakpoint.c +0 -5
@@ -531,8 +531,3 @@ void hw_breakpoint_pmu_read(struct perf_event *bp) {/* TODO */ } - -void hw_breakpoint_pmu_unthrottle (struct perf_event *bp) -{ -/* TODO */ -}
kernel/hw_breakpoint.c +0 -1
@@ -489,5 +489,4 @@ struct pmu perf_ops_bp = { .enable = arch_install_hw_breakpoint, .disable = arch_uninstall_hw_breakpoint, .read = hw_breakpoint_pmu_read, - .unthrottle = hw_breakpoint_pmu_unthrottle };