Skip to contentSkip to conversation

linux-next: build warning after merge of the drm tree

PATCH New Stephen Rothwell 2 participants 2 messages Mar 1, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi Dave,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

drivers/gpu/drm/radeon/r300_cmdbuf.c: In function 'r300_do_cp_cmdbuf':
drivers/gpu/drm/radeon/r300_cmdbuf.c:1154: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

Introduced by commit b4fe945405e477cded91772b4fec854705443dd5 ("drm/radeon: Fix memory allocation failures in the preKMS command stream checking").

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw

PATCH 1/1 drm/radeon: Fix printf type warning in 64bit system.

Type of iterator was promoted to unsigned long in 64bit systems.

*header is small structure so it is alwas safe to cast return value of sizeof operator to int.

---
 drivers/gpu/drm/radeon/r300_cmdbuf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/radeon/r300_cmdbuf.c +1 -1
index 18d3ff8..27930fc 100644
@@ -1148,7 +1148,7 @@ int r300_do_cp_cmdbuf(struct drm_device *dev,
 		default:
 			DRM_ERROR("bad cmd_type %i at byte %d\n",
 				  header->header.cmd_type,
-				  cmdbuf->buffer->iterator - sizeof(*header));
+				  cmdbuf->buffer->iterator - (int)sizeof(*header));
 			ret = -EINVAL;
 			goto cleanup;
 		}
Signature · 10 lines
1.6.3.3


------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--