block: don't access jiffies when initialising io_context
PATCH 1/1 block: don't access jiffies when initialising io_context
As the comment says the initial value of last_waited is never used, so there is no need to initialise it with the current jiffies. Jiffies is hot enough without accessing it for no reason.
Signed-off-by Richard Kennedy <[email protected]>
---
patch against 2.6.33
compiled & tested on x86_64
block/blk-ioc.c +1 -1
@@ -91,7 +91,7 @@ struct io_context *alloc_io_context(gfp_t gfp_flags, int node)spin_lock_init (&ret->lock); ret->ioprio_changed =0 ; ret->ioprio =0 ; - ret->last_waited = jiffies;/* doesn't matter... */ + ret->last_waited =0 ;/* doesn't matter... */ ret->nr_batch_requests =0 ;/* because this is 0 */ INIT_RADIX_TREE (&ret->radix_root,GFP_ATOMIC | __GFP_HIGH);INIT_HLIST_HEAD (&ret->cic_list);
Jens Axboe
AppliedQuoted 3 lines · Richard Kennedy
As the comment says the initial value of
last_waitedis never used, so there is no need to initialise it with the current jiffies. Jiffies is hot enough without accessing it for no reason.
Applied, though it will not make a huge difference in any way. alloc_io_context() only gets called the first time a process does IO, so it's not a hot path.
Quoted 21 lines
Signed-off-by Richard Kennedy <[email protected]>---
patch against 2.6.33
compiled & tested onx86_64block/blk-ioc.c +1
-1@@ -91,7 +91,7 @@ struct io_context *alloc_io_context(gfp_t gfp_flags, int node)spin_lock_init (&ret->lock); ret->ioprio_changed =0 ; ret->ioprio =0 ; - ret->last_waited = jiffies;/* doesn't matter... */ + ret->last_waited =0 ;/* doesn't matter... */ ret->nr_batch_requests =0 ;/* because this is 0 */ INIT_RADIX_TREE (&ret->radix_root,GFP_ATOMIC | __GFP_HIGH);INIT_HLIST_HEAD (&ret->cic_list);
Signature · 1 line
Jens Axboe