perf trace: a couple small fixes
cover perf trace: a couple small fixes
Tom Zanussi (2):
perf trace/scripting: remove extraneous header read perf trace: don't use pager if scripting
tools/perf/builtin-trace.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
PATCH 1/2 perf trace/scripting: remove extraneous header read
perf_header__read() is already done in perf_session__open(), so remove it from the script gen case.
--- tools/perf/builtin-trace.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
tools/perf/builtin-trace.c +0 -1
@@ -608,7 +608,6 @@ int cmd_trace(int argc, const char **argv, const char *prefix __used)return -1 ; } -perf_header__read (&session->header, input); err = scripting_ops->generate_script ("perf-trace" ); goto out; }
Signature · 1 line
1.6.4.GIT
[tip:perf/pebs] perf trace/scripting: Remove extraneous header read
Commit-ID: 10c95f4f41889daaa8130e0bd12209825dbe8d39 Gitweb: http://git.kernel.org/tip/10c95f4f41889daaa8130e0bd12209825dbe8d39 Author: Tom Zanussi <[email protected]> AuthorDate: Wed, 3 Mar 2010 01:04:32 -0600 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 4 Mar 2010 12:19:54 +0100
perf trace/scripting: Remove extraneous header read
perf_header__read() is already done in perf_session__open(), so remove it from the script gen case.
LKML-Reference: <[email protected]>
--- tools/perf/builtin-trace.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
tools/perf/builtin-trace.c +0 -1
@@ -608,7 +608,6 @@ int cmd_trace(int argc, const char **argv, const char *prefix __used)return -1 ; } -perf_header__read (&session->header, input); err = scripting_ops->generate_script ("perf-trace" ); goto out; }
PATCH 2/2 perf trace: don't use pager if scripting
In reply to Tom ZanussiIt's useful for paging through raw traces, but just gets in the way when scripting.
--- tools/perf/builtin-trace.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
tools/perf/builtin-trace.c +2 -1
@@ -573,7 +573,8 @@ int cmd_trace(int argc, const char **argv, const char *prefix __used)if (symbol__init () <0 )return -1 ; -setup_pager (); +if (!script_name) +setup_pager (); session =perf_session__new (input_name,O_RDONLY ,0 );if (session ==NULL )
Signature · 1 line
1.6.4.GIT
[tip:perf/pebs] perf trace: Don't use pager if scripting
Commit-ID: cf4fee50282312528e1f8adf73b1831d1d6ae389 Gitweb: http://git.kernel.org/tip/cf4fee50282312528e1f8adf73b1831d1d6ae389 Author: Tom Zanussi <[email protected]> AuthorDate: Wed, 3 Mar 2010 01:04:33 -0600 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 4 Mar 2010 12:19:55 +0100
perf trace: Don't use pager if scripting
It's useful for paging through raw traces, but just gets in the way when scripting.
LKML-Reference: <[email protected]>
--- tools/perf/builtin-trace.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
tools/perf/builtin-trace.c +2 -1
@@ -573,7 +573,8 @@ int cmd_trace(int argc, const char **argv, const char *prefix __used)if (symbol__init () <0 )return -1 ; -setup_pager (); +if (!script_name) +setup_pager (); session =perf_session__new (input_name,O_RDONLY ,0 );if (session ==NULL )