Skip to contentSkip to conversation

airo : Print of firmware version

PATCH In review matthieu castet 4 participants 6 messages Feb 28, 2010 – Mar 4, 2010 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 airo : Print of firmware version

For the firmware version 5.30.17 the log file shows:
Firmware version 5.30.11

The variable softSubVer is binary.

drivers/net/wireless/airo.c +1 -1
Index: airo.c
===================================================================
@@ -2993,7 +2993,7 @@
 	ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
 	ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
 
-	airo_print_info(dev->name, "Firmware version %x.%x.%02x",
+	airo_print_info(dev->name, "Firmware version %x.%x.%02d",
 	                ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
 	                (le16_to_cpu(cap_rid.softVer) & 0xFF),
 	                le16_to_cpu(cap_rid.softSubVer));
#1 lore raw
Quoted 14 lines · matthieu castet

For the firmware version 5.30.17 the log file shows:
Firmware version 5.30.11

The variable softSubVer is binary.

Index: airo.c
===================================================================

drivers/net/wireless/airo.c line 2999

Quoted 8 lines
drivers/net/wireless/airo.c +1 -1
@@ -2993,7 +2993,7 @@
 	ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
 	ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
 
-	airo_print_info(dev->name, "Firmware version %x.%x.%02x",
+	airo_print_info(dev->name, "Firmware version %x.%x.%02d",
 	                ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
 	                (le16_to_cpu(cap_rid.softVer) & 0xFF),
 	                le16_to_cpu(cap_rid.softSubVer));

Why should the last segment be in decimal form if the other two segments of the version number are in hexadecimal form?

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#2 lore raw
Quoted 18 lines · John W. Linville
Quoted 17 lines · matthieu castet

For the firmware version 5.30.17 the log file shows:
Firmware version 5.30.11

The variable softSubVer is binary.

Index: airo.c
===================================================================

drivers/net/wireless/airo.c +0 -0
@@ -2993,7 +2993,7 @@
 	ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
 	ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
 
Quoted 8 lines

drivers/net/wireless/airo.c line 2999

Quoted 5 lines
drivers/net/wireless/airo.c +1 -1
-	airo_print_info(dev->name, "Firmware version %x.%x.%02x",
+	airo_print_info(dev->name, "Firmware version %x.%x.%02d",
 	                ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
 	                (le16_to_cpu(cap_rid.softVer) & 0xFF),
 	                le16_to_cpu(cap_rid.softSubVer));

Why should the last segment be in decimal form if the other two segments of the version number are in hexadecimal form?

The airo.c shows the usage of hexadecimal and binary form:

        /* Test for WPA support */
        /* Only firmware versions 5.30.17 or better can do WPA */
        if (le16_to_cpu(cap_rid.softVer) > 0x530
         || (le16_to_cpu(cap_rid.softVer) == 0x530
              && le16_to_cpu(cap_rid.softSubVer) >= 17)) {
                airo_print_info(ai->dev->name, "WPA supported.");
#3 lore raw
Quoted 28 lines · Jose Alonso
Quoted 18 lines · John W. Linville
Quoted 17 lines · matthieu castet

For the firmware version 5.30.17 the log file shows:
Firmware version 5.30.11

The variable softSubVer is binary.

Index: airo.c
===================================================================

drivers/net/wireless/airo.c +0 -0
@@ -2993,7 +2993,7 @@
 	ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
 	ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
 
Quoted 8 lines

drivers/net/wireless/airo.c line 2999

Quoted 5 lines
drivers/net/wireless/airo.c +1 -1
-	airo_print_info(dev->name, "Firmware version %x.%x.%02x",
+	airo_print_info(dev->name, "Firmware version %x.%x.%02d",
 	                ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
 	                (le16_to_cpu(cap_rid.softVer) & 0xFF),
 	                le16_to_cpu(cap_rid.softSubVer));

Why should the last segment be in decimal form if the other two segments of the version number are in hexadecimal form?

Quoted 8 lines

The airo.c shows the usage of hexadecimal and binary form:

        /* Test for WPA support */
        /* Only firmware versions 5.30.17 or better can do WPA */
        if (le16_to_cpu(cap_rid.softVer) > 0x530
         || (le16_to_cpu(cap_rid.softVer) == 0x530
              && le16_to_cpu(cap_rid.softSubVer) >= 17)) {
                airo_print_info(ai->dev->name, "WPA supported.");

Alright, but that could be an argument for changing the comment. Probably too much to ask, but is there some authoritative source for this busted numbering scheme?

John

Signature · 2 lines
John W. Linville                Someday the world will need a hero, and you
[email protected]                  might be all we have.  Be ready.
#4 lore raw
Quoted 38 lines · John W. Linville
Quoted 28 lines · Jose Alonso
Quoted 18 lines · John W. Linville
Quoted 17 lines · matthieu castet

For the firmware version 5.30.17 the log file shows:
Firmware version 5.30.11

The variable softSubVer is binary.

Index: airo.c
===================================================================

drivers/net/wireless/airo.c +0 -0
@@ -2993,7 +2993,7 @@
 	ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
 	ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
 
Quoted 8 lines

drivers/net/wireless/airo.c line 2999

Quoted 5 lines
drivers/net/wireless/airo.c +1 -1
-	airo_print_info(dev->name, "Firmware version %x.%x.%02x",
+	airo_print_info(dev->name, "Firmware version %x.%x.%02d",
 	                ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
 	                (le16_to_cpu(cap_rid.softVer) & 0xFF),
 	                le16_to_cpu(cap_rid.softSubVer));

Why should the last segment be in decimal form if the other two segments of the version number are in hexadecimal form?

Quoted 8 lines

The airo.c shows the usage of hexadecimal and binary form:

        /* Test for WPA support */
        /* Only firmware versions 5.30.17 or better can do WPA */
        if (le16_to_cpu(cap_rid.softVer) > 0x530
         || (le16_to_cpu(cap_rid.softVer) == 0x530
              && le16_to_cpu(cap_rid.softSubVer) >= 17)) {
                airo_print_info(ai->dev->name, "WPA supported.");
Quoted 3 lines

Alright, but that could be an argument for changing the comment. Probably too much to ask, but is there some authoritative source for this busted numbering scheme?

Not really, you flash a certain known version of firmware onto the device in Windows, then see what Linux supports. I'll see if I can check my card out and see what I come up with.

Dan

#5 lore raw
Quoted 39 lines · Dan Williams
Quoted 38 lines · John W. Linville
Quoted 36 lines · Jose Alonso
Quoted 18 lines · John W. Linville
Quoted 17 lines · matthieu castet

For the firmware version 5.30.17 the log file shows:
Firmware version 5.30.11

The variable softSubVer is binary.

Index: airo.c
===================================================================

drivers/net/wireless/airo.c +0 -0
@@ -2993,7 +2993,7 @@
 	ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
 	ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
 
Quoted 8 lines

drivers/net/wireless/airo.c line 2999

Quoted 5 lines
drivers/net/wireless/airo.c +1 -1
-	airo_print_info(dev->name, "Firmware version %x.%x.%02x",
+	airo_print_info(dev->name, "Firmware version %x.%x.%02d",
 	                ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
 	                (le16_to_cpu(cap_rid.softVer) & 0xFF),
 	                le16_to_cpu(cap_rid.softSubVer));

Why should the last segment be in decimal form if the other two segments of the version number are in hexadecimal form?

The airo.c shows the usage of hexadecimal and binary form:

        /* Test for WPA support */
        /* Only firmware versions 5.30.17 or better can do WPA */
        if (le16_to_cpu(cap_rid.softVer) > 0x530
         || (le16_to_cpu(cap_rid.softVer) == 0x530
              && le16_to_cpu(cap_rid.softSubVer) >= 17)) {
                airo_print_info(ai->dev->name, "WPA supported.");
Quoted 7 lines
Quoted 3 lines

Alright, but that could be an argument for changing the comment. Probably too much to ask, but is there some authoritative source for this busted numbering scheme?

Not really, you flash a certain known version of firmware onto the device in Windows, then see what Linux supports. I'll see if I can check my card out and see what I come up with.

s/supports/reports.

Dan