drm: Remove the EDID blob stored in the EDID property when it is disconnected
Subsystems (2)
PATCH 1/1 drm: Remove the EDID blob stored in the EDID property when it is disconnected
From: Zhao Yakui <[email protected]>
Now the EDID property will be updated when the corresponding EDID can be obtained from the external display device. But after the external device is plugged-out, the EDID property is not updated. In such case we still get the corresponding EDID property although it is already detected as disconnected.
https://bugs.freedesktop.org/show_bug.cgi?id=26743
--- drivers/gpu/drm/drm_crtc_helper.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/drm_crtc_helper.c +1 -0
@@ -104,6 +104,7 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector,if (connector->status == connector_status_disconnected) {DRM_DEBUG_KMS ("%s is disconnected\n" ,drm_get_connector_name (connector)); +drm_mode_connector_update_edid_property (connector,NULL ); goto prune; }
Signature · 10 lines
1.6.3.3 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --
Quoted 21 lines · On Thu, 4 Mar 2010 16:25:55 +0800 Zhenyu Wang <[email protected]> wrote:
From: Zhao Yakui <[email protected]>
Now the EDID property will be updated when the corresponding EDID can be obtained from the external display device. But after the external device is plugged-out, the EDID property is not updated. In such case we still get the corresponding EDID property although it is already detected as disconnected.
https://bugs.freedesktop.org/show_bug.cgi?id=26743
Signed-off-by Zhao Yakui <[email protected]>Signed-off-by Zhenyu Wang <[email protected]>--- drivers/gpu/drm/drm_crtc_helper.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/gpu/drm/drm_crtc_helper.c +0
-0
drivers/gpu/drm/drm_crtc_helper.c int drm_helper_probe_single_connector_modes(struct drm_connector *connector, · line 110
Quoted 7 lines
drivers/gpu/drm/drm_crtc_helper.c +1
-0@@ -104,6 +104,7 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector,if (connector->status == connector_status_disconnected) {DRM_DEBUG_KMS ("%s is disconnected\n" ,drm_get_connector_name (connector)); +drm_mode_connector_update_edid_property (connector,NULL ); goto prune; }
I think this should be safe, and does fix a real bug. If so, it should also be cc: [email protected].
Dave?
Signature · 9 lines
Jesse Barnes, Intel Open Source Technology Center ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --