Skip to contentSkip to conversation

block: blk-timeout.c possible mishandling of jiffies wrap?

DISCUSSION Richard Kennedy 1 participant 1 message Mar 7, 2010

lore
Share & tools
lore
#0 lore raw

Hi Jens,

In blk_rq_timed_out_timer() in blk-timeout.c the comment at line 129 says that the request deadline can never be zero as that gets fixed in blk_add_timer.

However commit 7838c15b8dd18e78a523513749e5b54bda07b0cb removed the line that bumped deadline if zero.

So now AFAICT there's nothing to prevent deadline being zero, and blk_rq_timed_out_timer may not always do the right thing when jiffies is about to wrap.

There was a next_set flag in blk_rq_timed_out_timer but that's been removed too.

Do you have any preferred fix? A next_set flag or a deadline bump or something else?

regards
Richard