Skip to contentSkip to conversation

HID: Export hid_register_field

PATCH In review Benjamin Tissoires 1 participant 1 message Mar 8, 2010 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 HID: Export hid_register_field

The Apple Magic Mouse (and probably other devices) publish reports that are not called out in their HID report descriptors -- they only send them when enabled through other writes to the devices. Exporting hid_register_report is not sufficient as the given report is empty.

As the hid parser does not know the new fields, the driver has to register them manually. This allows the driver to manually register the different fields.

---
 drivers/hid/hid-core.c |    3 ++-
 include/linux/hid.h    |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)
drivers/hid/hid-core.c +2 -1
index bfd8301..3313dff 100644
@@ -83,7 +83,7 @@ EXPORT_SYMBOL_GPL(hid_register_report);
  * Register a new field for this report.
  */
 
-static struct hid_field *hid_register_field(struct hid_report *report, unsigned usages, unsigned values)
+struct hid_field *hid_register_field(struct hid_report *report, unsigned usages, unsigned values)
 {
 	struct hid_field *field;
 
@@ -103,6 +103,7 @@ static struct hid_field *hid_register_field(struct hid_report *report, unsigned
 
 	return field;
 }
+EXPORT_SYMBOL_GPL(hid_register_field);
 
 /*
  * Open a collection. The type/usage is pushed on the stack.
include/linux/hid.h +1 -0
index b1344ec..50f17de 100644
@@ -691,6 +691,7 @@ int hidinput_find_field(struct hid_device *hid, unsigned int type, unsigned int
 void hid_output_report(struct hid_report *report, __u8 *data);
 struct hid_device *hid_allocate_device(void);
 struct hid_report *hid_register_report(struct hid_device *device, unsigned type, unsigned id);
+struct hid_field *hid_register_field(struct hid_report *report, unsigned usages, unsigned values);
 int hid_parse_report(struct hid_device *hid, __u8 *start, unsigned size);
 int hid_check_keys_pressed(struct hid_device *hid);
 int hid_connect(struct hid_device *hid, unsigned int connect_mask);

-- 1.6.6.1