Skip to contentSkip to conversation

input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

PATCH In review Thomas Bächler 2 participants 5 messages Mar 9, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: alps: Add support for the touchpad of the Toshiba Tecra A11-11L

---
This patch was made by trial-and-error, I copied the byte0 and mask0 value from another model, tried different flags settings and it seems to work. I have no idea if there might be side- effects due to incorrect settings. Please tell me if I can do anything to verify or correct these values.

 drivers/input/mouse/alps.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/input/mouse/alps.c +2 -0
index f93c2c0..f6dad83 100644
@@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
 	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
 	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
+	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
+		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
 };
 
 /*
Signature · 6 lines
1.7.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#1 lore raw

Hi Thomas,

Quoted 17 lines · Thomas Bächler

---
This patch was made by trial-and-error, I copied the byte0 and mask0 value from another model, tried different flags settings and it seems to work. I have no idea if there might be side- effects due to incorrect settings. Please tell me if I can do anything to verify or correct these values.

 drivers/input/mouse/alps.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/input/mouse/alps.c +0 -0
index f93c2c0..f6dad83 100644

drivers/input/mouse/alps.c static const struct alps_model_info alps_model_data[] = { · line 69

Quoted 7 lines
drivers/input/mouse/alps.c +2 -0
@@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
 	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
 	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
+	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
+		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
 };
 

Looking at the picture it appears to have a touchpad only, not a touchpad/trackpoint combo. So I am wondering if ALPS_DUALPOINT and ALPS_PS2_INTERLEAVED flags are needed here. What happens if you remove them? Also, does it have external PS/2 post?

Thanks.

Signature · 5 lines
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw

Am 09.03.2010 20:01, schrieb Dmitry Torokhov:

Quoted 24 lines

Hi Thomas,

Quoted 21 lines · Thomas Bächler

---
This patch was made by trial-and-error, I copied the byte0 and mask0 value from another model, tried different flags settings and it seems to work. I have no idea if there might be side- effects due to incorrect settings. Please tell me if I can do anything to verify or correct these values.

 drivers/input/mouse/alps.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/input/mouse/alps.c +1 -0
index f93c2c0..f6dad83 100644
@@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
 	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
 	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
+	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
Quoted 8 lines

drivers/input/mouse/alps.c static const struct alps_model_info alps_model_data[] = { · line 69

Quoted 3 lines
drivers/input/mouse/alps.c +1 -0
+		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
 };
 

Looking at the picture it appears to have a touchpad only, not a touchpad/trackpoint combo. So I am wondering if ALPS_DUALPOINT and ALPS_PS2_INTERLEAVED flags are needed here. What happens if you remove them? Also, does it have external PS/2 post?

The model I have here does have a trackpoint, thus I put ALPS_DUALPOINT in. Also, I had problems without ALPS_PS2_INTERLEAVED ([...] lost sync at byte 1). I did not try without ALPS_PASS though, only with.

The device does not seem to have an external PS/2 port, but there is a connector for a docking station (which I don't own).

I am more concerned about the two 0xff values here, because they are actually guesses.

Thanks for the quick response.

maintainer
#3 lore raw
Quoted 34 lines · Thomas Bächler

Am 09.03.2010 20:01, schrieb Dmitry Torokhov:

Quoted 24 lines

Hi Thomas,

Quoted 21 lines · Thomas Bächler

---
This patch was made by trial-and-error, I copied the byte0 and mask0 value from another model, tried different flags settings and it seems to work. I have no idea if there might be side- effects due to incorrect settings. Please tell me if I can do anything to verify or correct these values.

 drivers/input/mouse/alps.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/input/mouse/alps.c +1 -0
index f93c2c0..f6dad83 100644
@@ -63,6 +63,8 @@ static const struct alps_model_info alps_model_data[] = {
 	{ { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
 	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },	  /* Dell Vostro 1400 */
+	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
Quoted 8 lines

drivers/input/mouse/alps.c static const struct alps_model_info alps_model_data[] = { · line 69

Quoted 3 lines
drivers/input/mouse/alps.c +1 -0
+		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
 };
 

Looking at the picture it appears to have a touchpad only, not a touchpad/trackpoint combo. So I am wondering if ALPS_DUALPOINT and ALPS_PS2_INTERLEAVED flags are needed here. What happens if you remove them? Also, does it have external PS/2 post?

Quoted 4 lines

The model I have here does have a trackpoint, thus I put ALPS_DUALPOINT in. Also, I had problems without ALPS_PS2_INTERLEAVED ([...] lost sync at byte 1). I did not try without ALPS_PASS though, only with.

No, ALPS_PASS is OK - you would notice right away if you didn't need it
- the device would not switch to absolute mode.

Quoted 3 lines

The device does not seem to have an external PS/2 port, but there is a connector for a docking station (which I don't own).

Ah, I see.

Quoted 3 lines

I am more concerned about the two 0xff values here, because they are actually guesses.

If you do not see it loosing sync as you workign it then you selected proper byte0 and mask.

Signature · 5 lines
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw

Am 09.03.2010 20:26, schrieb Dmitry Torokhov:

Quoted 12 lines
Quoted 4 lines

The model I have here does have a trackpoint, thus I put ALPS_DUALPOINT in. Also, I had problems without ALPS_PS2_INTERLEAVED ([...] lost sync at byte 1). I did not try without ALPS_PASS though, only with.

No, ALPS_PASS is OK - you would notice right away if you didn't need it
- the device would not switch to absolute mode.

Quoted 3 lines

The device does not seem to have an external PS/2 port, but there is a connector for a docking station (which I don't own).

Quoted 8 lines

Ah, I see.

Quoted 3 lines

I am more concerned about the two 0xff values here, because they are actually guesses.

If you do not see it loosing sync as you workign it then you selected proper byte0 and mask.

Good. In this case I guess you can apply the patch as it is. After applying this, would you mind sending this to linux-stable as well?