Skip to contentSkip to conversation

regulator: handle kcalloc() failure

PATCH Applied Dan Carpenter 4 participants 4 messages Mar 7, 2010 – Mar 10, 2010

Subsystems (2)
Kernel janitors Voltage and current regulator framework
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 regulator: handle kcalloc() failure

Return -ENOMEM if kcalloc() fails

Signed-off-by Dan Carpenter <[email protected]>
drivers/regulator/lp3971.c +5 -0
index f5532ed..55fab4a 100644
@@ -439,6 +439,10 @@ static int __devinit setup_regulators(struct lp3971 *lp3971,
 	lp3971->num_regulators = pdata->num_regulators;
 	lp3971->rdev = kcalloc(pdata->num_regulators,
 				sizeof(struct regulator_dev *), GFP_KERNEL);
+	if (!lp3971->rdev) {
+		err = -ENOMEM;
+		goto err_nomem;
+	}
 
 	/* Instantiate the regulators */
 	for (i = 0; i < pdata->num_regulators; i++) {

@@ -461,6 +465,7 @@ error:
 		regulator_unregister(lp3971->rdev[i]);
 	kfree(lp3971->rdev);
 	lp3971->rdev = NULL;
+err_nomem:
 	return err;
 }