Skip to contentSkip to conversation

Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

PATCH In review Chihau Chau 3 participants 7 messages Mar 15, 2010 – Apr 1, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

From: Chihau Chau <[email protected]>

This is moving toward using <linux/uaccess.h> instead of the old <asm/uaccess.h> file.

---
 drivers/staging/dream/generic_gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/dream/generic_gpio.c +1 -1
index fe24d38..bf19b85 100644
@@ -18,7 +18,7 @@
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
-#include <asm/gpio.h>
+#include <linux/gpio.h>
 #include "gpio_chip.h"
 
 #define GPIO_NUM_TO_CHIP_INDEX(gpio) ((gpio)>>5)
Signature · 1 line
1.5.6.3
#1 lore raw
Quoted 4 lines · Chihau Chau

From: Chihau Chau <[email protected]>

This is moving toward using <linux/uaccess.h> instead of the old <asm/uaccess.h> file.

Changelog does not match the patch.

...plus, was the patch actually tested?
Pavel

Quoted 11 lines
drivers/staging/dream/generic_gpio.c +1 -1
@@ -18,7 +18,7 @@
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
-#include <asm/gpio.h>
+#include <linux/gpio.h>
 #include "gpio_chip.h"
 
 #define GPIO_NUM_TO_CHIP_INDEX(gpio) ((gpio)>>5)
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw

Sorry I have been confused with the description of another patch.

I will fix the description.

Thanks Pavel!

2010/3/15 Pavel Machek <[email protected]>:

Quoted 27 lines · Chihau Chau
Quoted 4 lines

From: Chihau Chau <[email protected]>

This is moving toward using <linux/uaccess.h> instead of the old <asm/uaccess.h> file.

Changelog does not match the patch.

...plus, was the patch actually tested?
                                                                       Pavel

drivers/staging/dream/generic_gpio.c line 24

Quoted 11 lines
drivers/staging/dream/generic_gpio.c +1 -1
@@ -18,7 +18,7 @@
  #include <linux/errno.h>
  #include <linux/slab.h>
  #include <linux/spinlock.h>
-#include <asm/gpio.h>
+#include <linux/gpio.h>
  #include "gpio_chip.h"
 
  #define GPIO_NUM_TO_CHIP_INDEX(gpio) ((gpio)>>5)

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Signature · 1 line
Chihau Chau
#3 lore raw

Hi!

Quoted 5 lines

Sorry I have been confused with the description of another patch.

I will fix the description.

Thanks Pavel!

...

Quoted 1 line
Quoted 1 line

...plus, was the patch actually tested?

I'd still like to know if it was tested...
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#4 lore raw

No I don't know how to test it in my G1.

2010/3/15 Pavel Machek <[email protected]>:

Quoted 16 lines

Hi!

Quoted 5 lines

Sorry I have been confused with the description of another patch.

I will fix the description.

Thanks Pavel!

...

Quoted 1 line
Quoted 1 line

...plus, was the patch actually tested?

I'd still like to know if it was tested...
                                                                       Pavel --
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Signature · 1 line
Chihau Chau
#5 lore raw
In reply to Pavel Machek
Quoted 6 lines · Pavel Machek
Quoted 4 lines · Chihau Chau

From: Chihau Chau <[email protected]>

This is moving toward using <linux/uaccess.h> instead of the old <asm/uaccess.h> file.

Quoted 7 lines

Changelog does not match the patch.

...plus, was the patch actually tested?
Pavel

drivers/staging/dream/generic_gpio.c

Quoted 2 lines
drivers/staging/dream/generic_gpio.c +0 -0

We need to do some sort of staging re-sync .. This file for instance doesn't exist in the Google's tree any longer .. They moved to gpiolib, although they still need cleanups on top of that.

Daniel

#6 lore raw
Quoted 12 lines · Daniel Walker
Quoted 11 lines · Pavel Machek
Quoted 4 lines · Chihau Chau

From: Chihau Chau <[email protected]>

This is moving toward using <linux/uaccess.h> instead of the old <asm/uaccess.h> file.

Changelog does not match the patch.

...plus, was the patch actually tested?
Pavel

Quoted 6 lines
Quoted 2 lines

drivers/staging/dream/generic_gpio.c

Quoted 2 lines
drivers/staging/dream/generic_gpio.c +0 -0

We need to do some sort of staging re-sync .. This file for instance doesn't exist in the Google's tree any longer .. They moved to gpiolib, although they still need cleanups on top of that.

Yep. I hoped Google would just start using the stuff once it hit staging, but...
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html