Skip to contentSkip to conversation

TI: Davinci: NAND Driver Cleanup

PATCH Superseded Cyril Chemparathy 3 participants 3 messages Mar 16, 2010 – Mar 17, 2010

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 TI: Davinci: NAND Driver Cleanup

Modified to use IO accessor routines consistently. Eliminated volatile usage to keep checkpatch.pl happy.

---
1. Added fixes for DA830 EVM and Davinci Schmoogie boards
2. Reverted to include davinci_emif_regs macro definition

 board/davinci/da830evm/da830evm.c        |    2 +-
 drivers/mtd/nand/davinci_nand.c          |  125 ++++++++++++++++--------------
 include/asm-arm/arch-davinci/emif_defs.h |   80 +++++++++----------
 3 files changed, 105 insertions(+), 102 deletions(-)
board/davinci/da830evm/da830evm.c +1 -1
index ed668af..6385443 100644
@@ -150,7 +150,7 @@ int board_init(void)
 		DAVINCI_ABCR_RHOLD(0) |
 		DAVINCI_ABCR_TA(2) |
 		DAVINCI_ABCR_ASIZE_8BIT),
-	       &davinci_emif_regs->AB2CR);
+	       &davinci_emif_regs->ab2cr);
 #endif
 
 	/* arch number of the board */
drivers/mtd/nand/davinci_nand.c +66 -59

291 lines not on this page · raw message

include/asm-arm/arch-davinci/emif_defs.h +38 -42

88 lines not on this page · raw message

Signature · 1 line
1.6.3.3
#1 lore raw

PATCH v2 1/1 TI: Davinci: NAND Driver Cleanup

include/asm-arm/arch-davinci/emif_defs.h line 66

Quoted 4 lines · Cyril Chemparathy

#define davinci_emif_regs \

include/asm-arm/arch-davinci/emif_defs.h +2 -1
-	((struct davinci_emif_regs *)DAVINCI_ASYNC_EMIF_CNTRL_BASE)
+       ((struct davinci_emif_regs *)DAVINCI_ASYNC_EMIF_CNTRL_BASE)
+

I didn't check, but I would assume checkpatch would complain about the spaces that have crept in here? Can you please restore the original tab? Mainly this would remove these lines from your patch, which cause a small confusion as to what exactly has changed and why.

If you haven't already done so, it would be a good idea to run checkpatch to check for any other formatting violations.

Other than that, the patch looks good to me.

Thanks,
Nick.

#2 lore raw

PATCH v2 1/1 TI: Davinci: NAND Driver Cleanup

Hi Nick,

Quoted 2 lines

I didn't check, but I would assume checkpatch would complain about the spaces that have crept in here?

Interestingly checkpatch complains only if it finds 8 or more spaces at the beginning of the line (below). For some reason, vim cindent inserted 7 spaces in there, and that kept checkpatch from complaining.

...

# at the beginning of a line any tabs must come first and anything
# more than 8 must use tabs.
                if ($rawline =~ /^\+\s* \t\s*\S/ ||
                    $rawline =~ /^\+\s*        \s*/) {
                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
                        ERROR("code indent should use tabs where possible\n" . $herevet);
                }
...
Quoted 2 lines

If you haven't already done so, it would be a good idea to run checkpatch to check for any other formatting violations.

Thanks, resubmitted.

Regards
Cyril.