Skip to contentSkip to conversation

powerpc/fsl-booke: Get coherent bit from PTE

PATCH In review Kumar Gala 2 participants 3 messages Mar 17, 2010 – Mar 18, 2010 PowerPC

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 powerpc/fsl-booke: Get coherent bit from PTE

We shouldn't be always setting 'M' in the TLB entry since its reasonable for somethings to be mapped non-coherent. The PTE should have 'M' set properly.

---
 arch/powerpc/kernel/head_fsl_booke.S |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
arch/powerpc/kernel/head_fsl_booke.S +0 -3
index 25793bb..a7cf493 100644
@@ -747,9 +747,6 @@ finish_tlb_load:
 #else
 	rlwimi	r12, r11, 26, 27, 31	/* extract WIMGE from pte */
 #endif
-#ifdef CONFIG_SMP
-	ori	r12, r12, MAS2_M
-#endif
 	mtspr	SPRN_MAS2, r12
 
 #ifdef CONFIG_PTE_64BIT
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 3 lines · Kumar Gala

We shouldn't be always setting 'M' in the TLB entry since its reasonable for somethings to be mapped non-coherent. The PTE should have 'M' set properly.

properly = not at all? AFAICS the patch only removes the setting of the bit; so where is that 'M' bit set then?

Micha

author
#2 lore raw
Quoted 2 lines · Micha Nelissen
Quoted 1 line · Kumar Gala

We shouldn't be always setting 'M' in the TLB entry since its =

reasonable

Quoted 1 line
Quoted 1 line

for somethings to be mapped non-coherent. The PTE should have 'M' =

set

Quoted 3 lines
Quoted 1 line

properly.

=20
properly =3D not at all? AFAICS the patch only removes the setting of =

the bit; so where is that 'M' bit set then?

Quoted 2 lines

=20
Micha

Its set via things like the _PAGE_BASE define in = arch/powerpc/include/asm/pte-common.h

- k=