Skip to contentSkip to conversation

private field in led_classdev?

DISCUSSION Samuel Thibault 3 participants 5 messages Mar 7, 2010 – Mar 17, 2010

lore
Share & tools
lore
#0 lore raw

Hello,

Would there be an objection to adding a void *private field to the led_classdev struct? It would be a lot less burden for the input key board leds support for finding out the keyboard device from the brightness_set callback, as each device may have a long series of leds, not just a fixed number of them.

Samuel

#1 lore raw
Quoted 7 lines · Samuel Thibault

Hello,

Would there be an objection to adding a void *private field to the led_classdev struct? It would be a lot less burden for the input key board leds support for finding out the keyboard device from the brightness_set callback, as each device may have a long series of leds, not just a fixed number of them.

What's wrong with using the private pointer in the struct device instead? That's what it is there for.

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg KH, le Tue 09 Mar 2010 18:54:11 -0800, a écrit :
Quoted 5 lines · Samuel Thibault

Would there be an objection to adding a void *private field to the led_classdev struct? It would be a lot less burden for the input key board leds support for finding out the keyboard device from the brightness_set callback, as each device may have a long series of leds, not just a fixed number of them.

What's wrong with using the private pointer in the struct device instead?

Ah, right. In my case there is a struct device corresponding to the actual input device. I hadn't realized that since registering a led creates a new device, I have another private pointer which I can use.

Samuel

#3 lore raw
Quoted 8 lines · Samuel Thibault, le Wed 10 Mar 2010 10:44:52 +0100, a écrit :
Quoted 7 lines · Greg KH, le Tue 09 Mar 2010 18:54:11 -0800, a écrit :
Quoted 5 lines · Samuel Thibault

Would there be an objection to adding a void *private field to the led_classdev struct? It would be a lot less burden for the input key board leds support for finding out the keyboard device from the brightness_set callback, as each device may have a long series of leds, not just a fixed number of them.

Quoted 6 lines
Quoted 2 lines

What's wrong with using the private pointer in the struct device instead?

Ah, right. In my case there is a struct device corresponding to the actual input device. I hadn't realized that since registering a led creates a new device, I have another private pointer which I can use.

One issue, however, is that led_classdev_register() calls led_trigger_set_default(), which eventually calls the brightness_set hook, but the private field (platform_data) still hasn't been initialized, so the brightness_set hook has to abort setting the initial state. In my case, after led_classdev_register and setting platform_data, I can call the low level function by hand, it's just not very pretty...

Samuel

#4 lore raw
Quoted 9 lines · Samuel Thibault
Quoted 7 lines · Samuel Thibault, le Wed 10 Mar 2010 10:44:52 +0100, a écrit :
Quoted 2 lines · Greg KH, le Tue 09 Mar 2010 18:54:11 -0800, a écrit :

What's wrong with using the private pointer in the struct device instead?

Ah, right. In my case there is a struct device corresponding to the actual input device. I hadn't realized that since registering a led creates a new device, I have another private pointer which I can use.

Quoted 7 lines

One issue, however, is that led_classdev_register() calls led_trigger_set_default(), which eventually calls the brightness_set hook, but the private field (platform_data) still hasn't been initialized, so the brightness_set hook has to abort setting the initial state. In my case, after led_classdev_register and setting platform_data, I can call the low level function by hand, it's just not very pretty...

That is a bit ugly :/.

It would probably make sense to pass that parameter to led_classdev_register() but changing references to that function everywhere will be a pain.

I'm tempted to make led_classdev_register() a wrapper around a led_classdev_register_drvdata() function which takes an extra parameter.

I agree using the private pointer makes sense though.

Cheers,

Richard