drm/radeon/kms: Fix NULL pointer dereference if memory allocation failed.
Subsystems (2)
PATCH 1/1 drm/radeon/kms: Fix NULL pointer dereference if memory allocation failed.
When there is allocation failure in radeon_cs_parser_relocs parser->nrelocs is not cleaned. This causes NULL pointer defeference in radeon_cs_parser_fini when clean up code is trying to loop over the relocation array and free the objects.
Fix adds a check for a possible NULL pointer in clean up code.
Signed-off-by Pauli Nieminen <[email protected]>
--- drivers/gpu/drm/radeon/radeon_cs.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_cs.c +5 -3
@@ -193,9 +193,11 @@ static void radeon_cs_parser_fini(struct radeon_cs_parser *parser, int error)radeon_bo_list_fence (&parser->validated, parser->ib->fence); }radeon_bo_list_unreserve (&parser->validated); -for (i =0 ; i < parser->nrelocs; i++) { -if (parser->relocs[i].gobj) -drm_gem_object_unreference_unlocked (parser->relocs[i].gobj); +if (parser->relocs !=NULL ) { +for (i =0 ; i < parser->nrelocs; i++) { +if (parser->relocs[i].gobj) +drm_gem_object_unreference_unlocked (parser->relocs[i].gobj); + } }kfree (parser->track);kfree (parser->relocs);
Signature · 10 lines
1.6.3.3 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --