Skip to contentSkip to conversation

dm-log-userspace: Failure to trap all errors

PATCH New Jonathan Brassow 1 participant 1 message Mar 19, 2010 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm-log-userspace: Failure to trap all errors

This patch resolves unhandled errors.

When constructing a mirror, it is possible for the initial request to fail for other reasons besides just -ESRCH. These must be handled too.

drivers/md/dm-log-userspace-base.c +5 -2
Index: linux-2.6/drivers/md/dm-log-userspace-base.c
===================================================================
@@ -180,8 +180,11 @@ static int userspace_ctr(struct dm_dirty
 	r = dm_consult_userspace(lc->uuid, lc->luid, DM_ULOG_CTR,
 				 ctr_str, str_size, NULL, NULL);
 
-	if (r == -ESRCH) {
-		DMERR("Userspace log server not found");
+	if (r < 0) {
+		if (r == -ESRCH)
+			DMERR("Userspace log server not found");
+		else
+			DMERR("Userspace log server failed to create log");
 		goto out;
 	}