Skip to contentSkip to conversation

ALSA: ASoC: pxa-pcm-lib: initialize DMA channel to -1

PATCH In review Daniel Mack 3 participants 4 messages Mar 18, 2010 – Mar 22, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: ASoC: pxa-pcm-lib: initialize DMA channel to -1

This fixes a warning ("pxa_free_dma: trying to free channel 0 which is already freed") when a device was opened but the hw_params() call failed.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Nicolas Pitre <[email protected]>
---
 sound/arm/pxa2xx-pcm-lib.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/arm/pxa2xx-pcm-lib.c +1 -0
index 743ac6a..fd51fa8 100644
@@ -205,6 +205,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream)
 	if (!rtd->dma_desc_array)
 		goto err1;
 
+	rtd->dma_ch = -1;
 	runtime->private_data = rtd;
 	return 0;
 
Signature · 1 line
1.6.3.3
#1 lore raw

Any oppinion about this one?

(Sorry for the clock skew - the virtual machine I did this in lives in
its own world)

Quoted 27 lines · Daniel Mack

This fixes a warning ("pxa_free_dma: trying to free channel 0 which is already freed") when a device was opened but the hw_params() call failed.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Nicolas Pitre <[email protected]>
---
 sound/arm/pxa2xx-pcm-lib.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/arm/pxa2xx-pcm-lib.c +1 -0
index 743ac6a..fd51fa8 100644
@@ -205,6 +205,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream)
 	if (!rtd->dma_desc_array)
 		goto err1;
 
+	rtd->dma_ch = -1;
 	runtime->private_data = rtd;
 	return 0;
 
Signature · 1 line
1.6.3.3
#2 lore raw
Quoted 1 line · Daniel Mack

Any oppinion about this one?

It's probably OK, but I'll wait for Liam.

Quoted 2 lines

(Sorry for the clock skew - the virtual machine I did this in lives in
its own world)

Your clock skew buries it in mail folders.

#3 lore raw
Quoted 9 lines · Mark Brown
Quoted 1 line · Daniel Mack

Any oppinion about this one?

It's probably OK, but I'll wait for Liam.

Quoted 2 lines

(Sorry for the clock skew - the virtual machine I did this in lives in
its own world)

Your clock skew buries it in mail folders.

That maybe why I missed it.

Acked by: Liam Girdwood <[email protected]>

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk