Skip to contentSkip to conversation

Monotonic time test: Don't force static compilation of time_test

PATCH In review Lucas Meneghel Rodrigues 4 participants 6 messages Mar 23, 2010 – Mar 24, 2010 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Monotonic time test: Don't force static compilation of time_test

The Makefile for the monotonic_test C program forces static compilation of the object files. Since we are compiling the code already, not having a static binary doesn't make much of a difference on the systems we are running this test.

As the static compilation might fail in some boxes, just remove this constraint from the Makefile.

---
 client/tests/monotonic_time/src/Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
client/tests/monotonic_time/src/Makefile +0 -1
index 56aa7b6..2121ec4 100644
@@ -1,7 +1,6 @@
 CC=	cc
 
 CFLAGS=	-O -std=gnu99 -Wall
-LDFLAGS=-static
 LIBS=	-lpthread -lrt
 
 PROG=	time_test
Signature · 1 line
1.6.6.1
#1 lore raw

+cc:md (he wrote the test).

Quoted 7 lines · Lucas Meneghel Rodrigues

The Makefile for the monotonic_test C program forces static compilation of the object files. Since we are compiling the code already, not having a static binary doesn't make much of a difference on the systems we are running this test.

As the static compilation might fail in some boxes, just remove this constraint from the Makefile.

I presume this was to fix some Google interdependency. Is it actually breaking something? If not, seems safer to leave it? If so, we'll have to fix one end or the other ;-)

Quoted 25 lines

---
 client/tests/monotonic_time/src/Makefile |    1 -

 1 files changed, 0 insertions(+), 1 deletions(-)
client/tests/monotonic_time/src/Makefile +0 -0
index 56aa7b6..2121ec4 100644
@@ -1,7 +1,6 @@

 CC=    cc

 CFLAGS=        -O -std=gnu99 -Wall
-LDFLAGS=-static
 LIBS=  -lpthread -lrt

 PROG=  time_test
--
1.6.6.1

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

#2 lore raw

This sounds fine to me - since the test is normally being built on the machine on which it is going to be run there is no need to build a static linked binary.

I suspect that the --static in the Makefile is just a throwback to some point in time at which I was building the test on a development machine and running it on a number of test systems which were not guaranteed to have a compatible set of shared libraries on them,

md

Quoted 37 lines · Martin Bligh

+cc:md (he wrote the test).

Quoted 7 lines · Lucas Meneghel Rodrigues

The Makefile for the monotonic_test C program forces static compilation of the object files. Since we are compiling the code already, not having a static binary doesn't make much of a difference on the systems we are running this test.

As the static compilation might fail in some boxes, just remove this constraint from the Makefile.

I presume this was to fix some Google interdependency. Is it actually breaking something? If not, seems safer to leave it? If so, we'll have to fix one end or the other ;-)

Review

Quoted 6 lines
---
 client/tests/monotonic_time/src/Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/client/tests/monotonic_time/src/Makefile

Quoted 14 lines

index 56aa7b6..2121ec4 100644

client/tests/monotonic_time/src/Makefile +0 -2
@@ -1,7 +1,6 @@
 CC=    cc
 
 CFLAGS=        -O -std=gnu99 -Wall
-LDFLAGS=-static
 LIBS=  -lpthread -lrt
 
 PROG=  time_test
--

1.6.6.1

Quoted 6 lines
Quoted 5 lines

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

#3 lore raw
In reply to Martin Bligh
Quoted 9 lines · Martin Bligh

+cc:md (he wrote the test).

Quoted 5 lines · Lucas Meneghel Rodrigues

The Makefile for the monotonic_test C program forces static compilation of the object files. Since we are compiling the code already, not having a static binary doesn't make much of a difference on the systems we are running this test.

Quoted 6 lines
Quoted 2 lines

As the static compilation might fail in some boxes, just remove this constraint from the Makefile.

I presume this was to fix some Google interdependency. Is it actually breaking something? If not, seems safer to leave it? If so, we'll have to fix one end or the other ;-)

Yes, I can't get a static build on a Fedora 13 box by no means, that's why I looked into what was going wrong and cooked this patch. If someone has any suggestions of what I need to do to work around this, let me know.

Quoted 30 lines
Quoted 16 lines

---
 client/tests/monotonic_time/src/Makefile |    1 -

 1 files changed, 0 insertions(+), 1 deletions(-)
client/tests/monotonic_time/src/Makefile +0 -0
index 56aa7b6..2121ec4 100644
@@ -1,7 +1,6 @@

 CC=    cc

 CFLAGS=        -O -std=gnu99 -Wall
-LDFLAGS=-static
 LIBS=  -lpthread -lrt

Quoted 9 lines

 PROG=  time_test
--
1.6.6.1

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Signature · 1 line
Lucas
#4 lore raw
Quoted 13 lines · Lucas Meneghel Rodrigues
Quoted 12 lines · Martin Bligh

+cc:md (he wrote the test).

Quoted 7 lines · Lucas Meneghel Rodrigues

The Makefile for the monotonic_test C program forces static compilation of the object files. Since we are compiling the code already, not having a static binary doesn't make much of a difference on the systems we are running this test.

As the static compilation might fail in some boxes, just remove this constraint from the Makefile.

Quoted 8 lines
Quoted 3 lines

I presume this was to fix some Google interdependency. Is it actually breaking something? If not, seems safer to leave it? If so, we'll have to fix one end or the other ;-)

Yes, I can't get a static build on a Fedora 13 box by no means, that's why I looked into what was going wrong and cooked this patch. If someone has any suggestions of what I need to do to work around this, let me know.

OK, sounds like Michael is happy - and there's a real problem to fix. LGTM - go ahead and apply it.

Thanks,

M.

#5 lore raw
In reply to Lucas Meneghel Rodrigues
Quoted 20 lines · Lucas Meneghel Rodrigues
Quoted 10 lines · Martin Bligh

+cc:md (he wrote the test).

Quoted 5 lines · Lucas Meneghel Rodrigues

The Makefile for the monotonic_test C program forces static compilation of the object files. Since we are compiling the code already, not having a static binary doesn't make much of a difference on the systems we are running this test.

Quoted 7 lines
Quoted 3 lines

As the static compilation might fail in some boxes, just remove this constraint from the Makefile.

I presume this was to fix some Google interdependency. Is it actually breaking something? If not, seems safer to leave it? If so, we'll have to fix one end or the other ;-)

Quoted 6 lines

Yes, I can't get a static build on a Fedora 13 box by no means, that's why I looked into what was going wrong and cooked this patch. If someone has any suggestions of what I need to do to work around this, let me know.

I met the same problem and there should be no difference when not using the static build.

Quoted 36 lines
Quoted 32 lines
Quoted 20 lines
---
 client/tests/monotonic_time/src/Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
client/tests/monotonic_time/src/Makefile +0 -2
index 56aa7b6..2121ec4 100644
@@ -1,7 +1,6 @@
 CC=    cc
 
 CFLAGS=        -O -std=gnu99 -Wall
-LDFLAGS=-static
 LIBS=  -lpthread -lrt
 
 PROG=  time_test
--

1.6.6.1

Quoted 6 lines

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest