Skip to contentSkip to conversation

dspbridge: minor mbox cleanups

PATCH In review Omar Ramirez Luna 2 participants 10 messages Mar 23, 2010 – Mar 25, 2010

lore
Share & tools
lore

Omar Ramirez Luna

author
#0 lore raw

cover dspbridge: minor mbox cleanups

Fix obvious coding style issues not seen during review.

And now bridge driver will auto select mailbox driver.

Omar Ramirez Luna (3):
DSPBRIDGE: fix checkpatch error introduced with mailbox patches
DSPBRIDGE: Fix obvious wrong comment formats in mbox migration
DSPBRIDGE: auto select mailbox when compiling bridge

 drivers/dsp/bridge/Kconfig          |    1 +
 drivers/dsp/bridge/wmd/_tiomap.h    |    4 ++--
 drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)
author
#1 lore raw

PATCH 1/3 DSPBRIDGE: fix checkpatch error introduced with mailbox patches

This fixes:
ERROR: "foo* bar" should be "foo *bar"
218: FILE: drivers/dsp/bridge/wmd/_tiomap.h:374:
+dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);

Signed-off-by Omar Ramirez Luna <[email protected]>
---
 drivers/dsp/bridge/wmd/_tiomap.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dsp/bridge/wmd/_tiomap.h +1 -1
index 7a884f4..e853777 100644
@@ -371,6 +371,6 @@ extern dsp_status wmd_tlb_dsp_va_to_mpu_pa(struct wmd_dev_context *dev_context,
  *  Requires:
  *  Ensures:
  */
-dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);
+dsp_status sm_interrupt_dsp(struct wmd_dev_context *dev_context, u16 mb_val);
 
 #endif /* _TIOMAP_ */
Signature · 1 line
1.6.2.4
author
#2 lore raw

PATCH 2/3 DSPBRIDGE: Fix obvious wrong comment formats in mbox migration

Fix obvious wrong comment formats in mbox migration.

Signed-off-by Omar Ramirez Luna <[email protected]
---
 drivers/dsp/bridge/wmd/_tiomap.h    |    2 +-
 drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/dsp/bridge/wmd/_tiomap.h +1 -1
index e853777..71ef731 100644
@@ -326,7 +326,7 @@ struct wmd_dev_context {
 	u32 dw_dsp_start_add;	/* API Boot vector */
 	u32 dw_internal_size;	/* Internal memory size */
 
-	struct omap_mbox *mbox;		/* Mail box handle*/
+	struct omap_mbox *mbox;		/* Mail box handle */
 
 	/*
 	 * Processor specific info is set when prog loaded and read from DCD.
drivers/dsp/bridge/wmd/tiomap3430.c +1 -1
index d90518a..a972ea2 100644
@@ -663,7 +663,7 @@ static dsp_status bridge_brd_start(struct wmd_dev_context *hDevContext,
 					       ul_dsp_clk_addr, sizeof(u32), 0);
 		}
 		/*
-		 *Enable Mailbox events and also drain any pending
+		 * Enable Mailbox events and also drain any pending
 		 * stale messages.
 		 */
 		dev_context->mbox = omap_mbox_get("dsp");
Signature · 1 line
1.6.2.4
author
#3 lore raw

PATCH 3/3 DSPBRIDGE: auto select mailbox when compiling bridge

Auto select mailbox when compiling bridgedriver.

If selected as module, first install:
arch/arm/plat-omap/mailbox.ko
arch/arm/mach-omap2/mailbox_mach.ko

Signed-off-by Omar Ramirez Luna <[email protected]
---
 drivers/dsp/bridge/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/dsp/bridge/Kconfig +1 -0
index c721f40..a3251c3 100644
@@ -5,6 +5,7 @@
 menuconfig MPU_BRIDGE
 	tristate "DSP Bridge driver"
 	default n
+	select OMAP_MBOX_FWK
 	help
 	  DSP/BIOS Bridge is designed for platforms that contain a GPP and
 	  one or more attached DSPs.  The GPP is considered the master or
Signature · 1 line
1.6.2.4
Acked-by on v1 3/3
#4 lore raw

Re: [PATCH 3/3] DSPBRIDGE: auto select mailbox when compiling bridge

Quoted 17 lines · Omar Ramirez Luna

Auto select mailbox when compiling bridgedriver.

If selected as module, first install:
arch/arm/plat-omap/mailbox.ko
arch/arm/mach-omap2/mailbox_mach.ko

Signed-off-by Omar Ramirez Luna <[email protected]
---
 drivers/dsp/bridge/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/dsp/bridge/Kconfig +0 -0
index c721f40..a3251c3 100644

drivers/dsp/bridge/Kconfig line 11

Quoted 7 lines
drivers/dsp/bridge/Kconfig +1 -0
@@ -5,6 +5,7 @@
 menuconfig MPU_BRIDGE
 	tristate "DSP Bridge driver"
 	default n
+	select OMAP_MBOX_FWK
 	help
 	  DSP/BIOS Bridge is designed for platforms that contain a GPP and
 	  one or more attached DSPs.  The GPP is considered the master or
Acked-by Deepak Chitriki <[email protected]>

Deepak

author Applied
#5 lore raw

Re: [PATCH 3/3] DSPBRIDGE: auto select mailbox when compiling bridge

Quoted 8 lines · Deepak
Quoted 7 lines · Omar Ramirez Luna

Auto select mailbox when compiling bridgedriver.

If selected as module, first install:
arch/arm/plat-omap/mailbox.ko
arch/arm/mach-omap2/mailbox_mach.ko

Signed-off-by Omar Ramirez Luna<[email protected]

[...]

Quoted 2 lines
Acked-by Deepak Chitriki<[email protected]>

Pushed to dspbridge.

- Omar

Acked-by on v1 2/3
#6 lore raw

Re: [PATCH 2/3] DSPBRIDGE: Fix obvious wrong comment formats in mbox migration

In reply to Omar Ramirez Luna
Quoted 27 lines · Omar

Fix obvious wrong comment formats in mbox migration.

Signed-off-by Omar Ramirez Luna <[email protected]
---
 drivers/dsp/bridge/wmd/_tiomap.h    |    2 +-
 drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/dsp/bridge/wmd/_tiomap.h +1 -1
index e853777..71ef731 100644
@@ -326,7 +326,7 @@ struct wmd_dev_context {
 	u32 dw_dsp_start_add;	/* API Boot vector */
 	u32 dw_internal_size;	/* Internal memory size */
 
-	struct omap_mbox *mbox;		/* Mail box handle*/
+	struct omap_mbox *mbox;		/* Mail box handle */
 
 	/*
 	 * Processor specific info is set when prog loaded and read from DCD.
drivers/dsp/bridge/wmd/tiomap3430.c +0 -0
index d90518a..a972ea2 100644

drivers/dsp/bridge/wmd/tiomap3430.c static dsp_status bridge_brd_start(struct wmd_dev_context *hDevContext, · line 669

Quoted 8 lines
drivers/dsp/bridge/wmd/tiomap3430.c +1 -1
@@ -663,7 +663,7 @@ static dsp_status bridge_brd_start(struct wmd_dev_context *hDevContext,
 					       ul_dsp_clk_addr, sizeof(u32), 0);
 		}
 		/*
-		 *Enable Mailbox events and also drain any pending
+		 * Enable Mailbox events and also drain any pending
 		 * stale messages.
 		 */
 		dev_context->mbox = omap_mbox_get("dsp");
Acked-by Deepak Chitriki <[email protected]>

Deepak

author Applied
#7 lore raw

Re: [PATCH 2/3] DSPBRIDGE: Fix obvious wrong comment formats in mbox migration

Quoted 9 lines · Deepak
Quoted 8 lines · Omar

Fix obvious wrong comment formats in mbox migration.

Signed-off-by Omar Ramirez Luna<[email protected]
---
  drivers/dsp/bridge/wmd/_tiomap.h    |    2 +-
  drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

[...]

Quoted 2 lines
Acked-by Deepak Chitriki<[email protected]>

Pushed to dspbridge.

- Omar

Acked-by on v1 1/3
#8 lore raw

Re: [PATCH 1/3] DSPBRIDGE: fix checkpatch error introduced with mailbox patches

In reply to Omar Ramirez Luna
Quoted 16 lines · Omar Ramirez Luna

This fixes:
ERROR: "foo* bar" should be "foo *bar"
218: FILE: drivers/dsp/bridge/wmd/_tiomap.h:374:
+dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);

Signed-off-by Omar Ramirez Luna <[email protected]>
---
 drivers/dsp/bridge/wmd/_tiomap.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dsp/bridge/wmd/_tiomap.h +0 -0
index 7a884f4..e853777 100644

drivers/dsp/bridge/wmd/_tiomap.h extern dsp_status wmd_tlb_dsp_va_to_mpu_pa(struct wmd_dev_context *dev_context, · line 376

Quoted 7 lines
drivers/dsp/bridge/wmd/_tiomap.h +1 -1
@@ -371,6 +371,6 @@ extern dsp_status wmd_tlb_dsp_va_to_mpu_pa(struct wmd_dev_context *dev_context,
  *  Requires:
  *  Ensures:
  */
-dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);
+dsp_status sm_interrupt_dsp(struct wmd_dev_context *dev_context, u16 mb_val);
 
 #endif /* _TIOMAP_ */
Acked-by Deepak Chitriki <[email protected]>

Deepak

author Applied
#9 lore raw

Re: [PATCH 1/3] DSPBRIDGE: fix checkpatch error introduced with mailbox patches

Quoted 7 lines · Deepak
Quoted 6 lines · Omar Ramirez Luna

This fixes:
ERROR: "foo* bar" should be "foo *bar"
218: FILE: drivers/dsp/bridge/wmd/_tiomap.h:374:
+dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);

Signed-off-by Omar Ramirez Luna<[email protected]>

[...]

Quoted 2 lines
Acked-by Deepak Chitriki<[email protected]>

Pushed to dspbridge.

- Omar