Skip to contentSkip to conversation

ath: fix macros coding style issue in regd.c

PATCH In review Luis de Bethencourt 2 participants 3 messages Mar 29, 2010 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 ath: fix macros coding style issue in regd.c

This is a patch to the ath/regd.c file that fixes up three warnings about macros found by the checkpatch.pl tool, these said that complex values should be enclosed in parenthesis.

---
 drivers/net/wireless/ath/regd.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)
drivers/net/wireless/ath/regd.c +7 -6
index 04abd1f..971edc4 100644
@@ -45,15 +45,16 @@
 #define ATH9K_5GHZ_5725_5850	REG_RULE(5725-10, 5850+10, 40, 0, 30,\
 				NL80211_RRF_PASSIVE_SCAN | NL80211_RRF_NO_IBSS)
 
-#define ATH9K_2GHZ_ALL		ATH9K_2GHZ_CH01_11, \
+#define ATH9K_2GHZ_ALL		(ATH9K_2GHZ_CH01_11, \
 				ATH9K_2GHZ_CH12_13, \
-				ATH9K_2GHZ_CH14
+				ATH9K_2GHZ_CH14)
+
+#define ATH9K_5GHZ_ALL		(ATH9K_5GHZ_5150_5350, \
+				ATH9K_5GHZ_5470_5850)
 
-#define ATH9K_5GHZ_ALL		ATH9K_5GHZ_5150_5350, \
-				ATH9K_5GHZ_5470_5850
 /* This one skips what we call "mid band" */
-#define ATH9K_5GHZ_NO_MIDBAND	ATH9K_5GHZ_5150_5350, \
-				ATH9K_5GHZ_5725_5850
+#define ATH9K_5GHZ_NO_MIDBAND	(ATH9K_5GHZ_5150_5350, \
+				ATH9K_5GHZ_5725_5850)
 
 /* Can be used for:
  * 0x60, 0x61, 0x62 */
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 3 lines · Luis de Bethencourt

This is a patch to the ath/regd.c file that fixes up three warnings about macros found by the checkpatch.pl tool, these said that complex values should be enclosed in parenthesis.

Hi Luis.

Checkpatch isn't always correct.

Please make sure to compile test your changes
before submitting them.

These macros are used as initializers and
can not be surrounded by parentheses.

	.reg_rules = {
		ATH9K_2GHZ_ALL,

cheers, Joe

A message that is not in the archive (sent off-list or not yet received): 1269905624.4558.56.camel-AkRN8/[email protected]

#3 lore raw
Quoted 12 lines · Joe Perches
Quoted 3 lines · Luis de Bethencourt

This is a patch to the ath/regd.c file that fixes up three warnings about macros found by the checkpatch.pl tool, these said that complex values should be enclosed in parenthesis.

Hi Luis.

Checkpatch isn't always correct.

Please make sure to compile test your changes
before submitting them.

Quoted 9 lines

These macros are used as initializers and
can not be surrounded by parentheses.

       .reg_rules = {
               ATH9K_2GHZ_ALL,

cheers, Joe

Hi Joe,

Sorry about this. I compiled test the changes but make didn't complain.

My bad, will try to avoid this better in the future.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html