xfs: don't warn on EAGAIN in inode reclaim
PATCH 1/1 xfs: don't warn on EAGAIN in inode reclaim
From: Dave Chinner <[email protected]>
Any inode reclaim flush that returns EAGAIN will result in the inode reclaim being attempted again later. There is no need to issue a warning into the logs about this situation.
Signed-off-by Dave Chinner <[email protected]>
--- fs/xfs/linux-2.6/xfs_sync.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
fs/xfs/linux-2.6/xfs_sync.c +2 -2
@@ -820,10 +820,10 @@ xfs_reclaim_inode(* call into reclaim to find it in a clean state instead of waiting for * it now. We also don't return errors here - if the error is transient * then the next reclaim pass will flush the inode, and if the error -* is permanent then the next sync reclaim will relcaim the inode and +* is permanent then the next sync reclaim will reclaim the inode and * pass on the error. */ -if (error && !XFS_FORCED_SHUTDOWN (ip->i_mount)) { +if (error && error !=EAGAIN && !XFS_FORCED_SHUTDOWN (ip->i_mount)) {xfs_fs_cmn_err (CE_WARN , ip->i_mount,"inode 0x%llx background reclaim flush failed with %d" , (long long )ip->i_ino, error);
Signature · 6 lines
1.6.5 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Dave Chinner
From: Dave Chinner <[email protected]>
Any inode reclaim flush that returns EAGAIN will result in the inode reclaim being attempted again later. There is no need to issue a warning into the logs about this situation.
Looks good.
Quoted 1 line
Signed-off-by Dave Chinner <[email protected]>
Reviewed-by Alex Elder <[email protected]>
Quoted 11 lines
--- fs/xfs/linux-2.6/xfs_sync.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)fs/xfs/linux-2.6/xfs_sync.c +0
-0@@ -820,10 +820,10 @@ xfs_reclaim_inode(* call into reclaim to find it in a clean state instead of waiting for * it now. We also don't return errors here - if the error is transient
fs/xfs/linux-2.6/xfs_sync.c xfs_reclaim_inode( · line 829
Quoted 10 lines
fs/xfs/linux-2.6/xfs_sync.c +2
-2* then the next reclaim pass will flush the inode, and if the error -* is permanent then the next sync reclaim will relcaim the inode and +* is permanent then the next sync reclaim will reclaim the inode and * pass on the error. */ -if (error && !XFS_FORCED_SHUTDOWN (ip->i_mount)) { +if (error && error !=EAGAIN && !XFS_FORCED_SHUTDOWN (ip->i_mount)) {xfs_fs_cmn_err (CE_WARN , ip->i_mount,"inode 0x%llx background reclaim flush failed with %d" , (long long )ip->i_ino, error);
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs