Skip to contentSkip to conversation

typdef uintptr_t drm_handle_t; unsigned int is wrong on 64-bit.

PATCH In review Matthew W. S. Bell 4 participants 15 messages Apr 3, 2010 – Apr 14, 2010

Subsystems (2)
DRM drivers DRM misc
lore
Share & tools
lore

Matthew W. S. Bell

author
#0 lore raw

PATCH 1/1 typdef uintptr_t drm_handle_t; unsigned int is wrong on 64-bit.

From d457b05faabde1a51b8e4b8f6fc13af9f07809f8 Mon Sep 17 00:00:00 2001

drm_handle_t appears to be assigned values from void*. As such unsigned int is certainly not the same size on 64-bit. Convert to uintptr_t in all cases as it is defined for this purpose.

I fear this patch changes ABI, but I am not sure.

Matthew W.S. Bell

---
 include/drm/drm.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/drm/drm.h +2 -2
index 4822159..95141a2 100644
@@ -40,7 +40,7 @@
 
 #include <linux/types.h>
 #include <asm/ioctl.h>
-typedef unsigned int drm_handle_t;
+typedef uintptr_t drm_handle_t;
 
 #else /* One of the BSDs */
 

@@ -54,7 +54,7 @@ typedef int32_t  __s32;
 typedef uint32_t __u32;
 typedef int64_t  __s64;
 typedef uint64_t __u64;
-typedef unsigned long drm_handle_t;
+typedef uintptr_t drm_handle_t;
 
 #endif
Signature · 1 line
1.7.0

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

#1 lore raw
Quoted 5 lines

drm_handle_t appears to be assigned values from void*. As such unsigned int is certainly not the same size on 64-bit. Convert to uintptr_t in all cases as it is defined for this purpose.

No, its "designed" as is. We can't change it now as its ABI. We make sure we only use 32-bit handles anyways.

Dave.

Quoted 24 lines

I fear this patch changes ABI, but I am not sure.

Matthew W.S. Bell

---
 include/drm/drm.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/drm/drm.h +1 -1
index 4822159..95141a2 100644
@@ -40,7 +40,7 @@
 
 #include <linux/types.h>
 #include <asm/ioctl.h>
-typedef unsigned int drm_handle_t;
+typedef uintptr_t drm_handle_t;
 
 #else /* One of the BSDs */

include/drm/drm.h typedef int32_t __s32; · line 60

Quoted 8 lines
include/drm/drm.h +1 -1
@@ -54,7 +54,7 @@ typedef int32_t  __s32;
 typedef uint32_t __u32;
 typedef int64_t  __s64;
 typedef uint64_t __u64;
-typedef unsigned long drm_handle_t;
+typedef uintptr_t drm_handle_t;
 
 #endif

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

author
#2 lore raw
Quoted 2 lines · Dave Airlie

No, its "designed" as is. We can't change it now as its ABI. We make sure we only use 32-bit handles anyways.

OK, is this documented anywhere, as I'd like to pull some of that into a comment? (It appears, on a casual glance, that this type is not used in the kernel ABI, but only in the libdrm, and associates?, ABI, so could be changed if the SONAME got bumped and anyone cared.)

Matthew

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

maintainer
#3 lore raw
Quoted 3 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

No, its "designed" as is. We can't change it now as its ABI. We make sure we only use 32-bit handles anyways.

The thing is "unsigned int" is correct for the handles, they are defined to be 32-bit numbers no matter what system they are on, its the use of the void * that is actually the problem.

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Dave.

Quoted 9 lines

OK, is this documented anywhere, as I'd like to pull some of that into a comment? (It appears, on a casual glance, that this type is not used in the kernel ABI, but only in the libdrm, and associates?, ABI, so could be changed if the SONAME got bumped and anyone cared.)

Matthew

Quoted 13 lines

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

#4 lore raw
Quoted 6 lines · Dave Airlie
Quoted 3 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

No, its "designed" as is. We can't change it now as its ABI. We make sure we only use 32-bit handles anyways.

Quoted 6 lines

The thing is "unsigned int" is correct for the handles, they are defined to be 32-bit numbers no matter what system they are on, its the use of the void * that is actually the problem.

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

No, they are not. They are only 32bit on linux. The size of handle varies with architecture on FreeBSD as it is passed to mmap as an offset into memory. Honestly, I would prefer that they always be 64bits, but that would break ABI... The dual meaning of handle has frustrated me more than a few times.

robert.

Quoted 23 lines

Dave.

Quoted 8 lines

OK, is this documented anywhere, as I'd like to pull some of that into a comment? (It appears, on a casual glance, that this type is not used in the kernel ABI, but only in the libdrm, and associates?, ABI, so could be changed if the SONAME got bumped and anyone cared.)

Matthew

Quoted 13 lines

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Quoted 11 lines

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

author
#5 lore raw

PATCH 1/1 drm_handle_t type

In reply to Dave Airlie
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Well, here's a patch that silences the warnings and adds a little note.

Matthew

---
From 9111cd82560052a329b78cff8d7e45c6815e0276 Mon Sep 17 00:00:00 2001
From: Matthew W. S. Bell <[email protected]>
Date: Fri, 9 Apr 2010 02:58:42 +0100

Add a comment about content of void* variable exchanged with kernel. Add casts to silence warnings about pointer to integer of a different size assignment.

---
 include/drm/drm.h |    2 ++
 xf86drm.c         |    4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
include/drm/drm.h +2 -0
index 4822159..e74d6d6 100644
@@ -216,6 +216,8 @@ struct drm_map {
 	enum drm_map_flags flags;	 /**< Flags */
 	void *handle;		 /**< User-space: "Handle" to pass to mmap() */
 				 /**< Kernel-space: kernel-virtual address */
+				 /**  The value herein shall be the size of */
+				 /**  drm_handle_t despite the size of void *. */
 	int mtrr;		 /**< MTRR slot used */
 	/*   Private data */
 };
xf86drm.c +2 -2
index 220aaa1..012408a 100644
@@ -959,7 +959,7 @@ int drmAddMap(int fd, drm_handle_t offset, drmSize size, drmMapType type,
     if (drmIoctl(fd, DRM_IOCTL_ADD_MAP, &map))
 	return -errno;
     if (handle)
-	*handle = (drm_handle_t)map.handle;
+	*handle = (uintptr_t)map.handle;
     return 0;
 }
 

@@ -2138,7 +2138,7 @@ int drmGetMap(int fd, int idx, drm_handle_t *offset, drmSize *size,
     *size   = map.size;
     *type   = map.type;
     *flags  = map.flags;
-    *handle = (unsigned long)map.handle;
+    *handle = (uintptr_t)map.handle;
     *mtrr   = map.mtrr;
     return 0;
 }
Signature · 1 line
1.7.0

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

author
#6 lore raw

PATCH 1/1 drm_handle_t type

In reply to Dave Airlie
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

From a92f45396cd13f91ffd0bd1ea27250e5606184f8 Mon Sep 17 00:00:00 2001
From: Matthew W. S. Bell <[email protected]>
Date: Fri, 9 Apr 2010 02:58:42 +0100

Add a comment about content of void* variable exchanged with kernel. Add casts to silence warnings about pointer to integer of a different size assignment.

---
 include/drm/drm.h |    2 ++
 xf86drm.c         |   10 +++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)
include/drm/drm.h +2 -0
index 4822159..e74d6d6 100644
@@ -216,6 +216,8 @@ struct drm_map {
 	enum drm_map_flags flags;	 /**< Flags */
 	void *handle;		 /**< User-space: "Handle" to pass to mmap() */
 				 /**< Kernel-space: kernel-virtual address */
+				 /**  The value herein shall be the size of */
+				 /**  drm_handle_t despite the size of void *. */
 	int mtrr;		 /**< MTRR slot used */
 	/*   Private data */
 };
xf86drm.c +5 -5
index 220aaa1..35576fa 100644
@@ -959,7 +959,7 @@ int drmAddMap(int fd, drm_handle_t offset, drmSize size, drmMapType type,
     if (drmIoctl(fd, DRM_IOCTL_ADD_MAP, &map))
 	return -errno;
     if (handle)
-	*handle = (drm_handle_t)map.handle;
+	*handle = (uintptr_t)map.handle;
     return 0;
 }
 

@@ -967,7 +967,7 @@ int drmRmMap(int fd, drm_handle_t handle)
 {
     drm_map_t map;
 
-    map.handle = (void *)handle;
+    map.handle = (void *)(uintptr_t)handle;
 
     if(drmIoctl(fd, DRM_IOCTL_RM_MAP, &map))
 	return -errno;

@@ -2103,7 +2103,7 @@ int drmAddContextPrivateMapping(int fd, drm_context_t ctx_id,
     drm_ctx_priv_map_t map;
 
     map.ctx_id = ctx_id;
-    map.handle = (void *)handle;
+    map.handle = (void *)(uintptr_t)handle;
 
     if (drmIoctl(fd, DRM_IOCTL_SET_SAREA_CTX, &map))
 	return -errno;

@@ -2120,7 +2120,7 @@ int drmGetContextPrivateMapping(int fd, drm_context_t ctx_id,
     if (drmIoctl(fd, DRM_IOCTL_GET_SAREA_CTX, &map))
 	return -errno;
     if (handle)
-	*handle = (drm_handle_t)map.handle;
+	*handle = (uintptr_t)map.handle;
 
     return 0;
 }

@@ -2138,7 +2138,7 @@ int drmGetMap(int fd, int idx, drm_handle_t *offset, drmSize *size,
     *size   = map.size;
     *type   = map.type;
     *flags  = map.flags;
-    *handle = (unsigned long)map.handle;
+    *handle = (uintptr_t)map.handle;
     *mtrr   = map.mtrr;
     return 0;
 }
Signature · 1 line
1.7.0

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

#7 lore raw

Re: [PATCH] drm_handle_t type

Quoted 5 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

drm_handle_t is correct here...

robert.

Quoted 81 lines

From a92f45396cd13f91ffd0bd1ea27250e5606184f8 Mon Sep 17 00:00:00 2001
From: Matthew W. S. Bell <[email protected]>
Date: Fri, 9 Apr 2010 02:58:42 +0100

Add a comment about content of void* variable exchanged with kernel. Add casts to silence warnings about pointer to integer of a different size assignment.

---
 include/drm/drm.h |    2 ++
 xf86drm.c         |   10 +++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)
include/drm/drm.h +2 -0
index 4822159..e74d6d6 100644
@@ -216,6 +216,8 @@ struct drm_map {
 	enum drm_map_flags flags;	 /**< Flags */
 	void *handle;		 /**< User-space: "Handle" to pass to mmap() */
 				 /**< Kernel-space: kernel-virtual address */
+				 /**  The value herein shall be the size of */
+				 /**  drm_handle_t despite the size of void *. */
 	int mtrr;		 /**< MTRR slot used */
 	/*   Private data */
 };
xf86drm.c +5 -6
index 220aaa1..35576fa 100644
@@ -959,7 +959,7 @@ int drmAddMap(int fd, drm_handle_t offset, drmSize size, drmMapType type,
     if (drmIoctl(fd, DRM_IOCTL_ADD_MAP, &map))
 	return -errno;
     if (handle)
-	*handle = (drm_handle_t)map.handle;
+	*handle = (uintptr_t)map.handle;
     return 0;
 }
 

@@ -967,7 +967,7 @@ int drmRmMap(int fd, drm_handle_t handle)
 {
     drm_map_t map;
 
-    map.handle = (void *)handle;
+    map.handle = (void *)(uintptr_t)handle;
 
     if(drmIoctl(fd, DRM_IOCTL_RM_MAP, &map))
 	return -errno;

@@ -2103,7 +2103,7 @@ int drmAddContextPrivateMapping(int fd, drm_context_t ctx_id,
     drm_ctx_priv_map_t map;
 
     map.ctx_id = ctx_id;
-    map.handle = (void *)handle;
+    map.handle = (void *)(uintptr_t)handle;
 
     if (drmIoctl(fd, DRM_IOCTL_SET_SAREA_CTX, &map))
 	return -errno;

@@ -2120,7 +2120,7 @@ int drmGetContextPrivateMapping(int fd, drm_context_t ctx_id,
     if (drmIoctl(fd, DRM_IOCTL_GET_SAREA_CTX, &map))
 	return -errno;
     if (handle)
-	*handle = (drm_handle_t)map.handle;
+	*handle = (uintptr_t)map.handle;
 
     return 0;
 }

@@ -2138,7 +2138,7 @@ int drmGetMap(int fd, int idx, drm_handle_t *offset, drmSize *size,
     *size   = map.size;
     *type   = map.type;
     *flags  = map.flags;
-    *handle = (unsigned long)map.handle;
+    *handle = (uintptr_t)map.handle;
     *mtrr   = map.mtrr;
     return 0;
 }
------------------------------------------------------------------------------

Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
-- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel

Signature · 11 lines
Robert Noland <[email protected]>
2Hip Networks


------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
author
#8 lore raw

Re: [PATCH] drm_handle_t type

Quoted 8 lines · Robert Noland
Quoted 5 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

drm_handle_t is correct here...

No, drm_handle_t can be of a different size to void *; converting between integers and pointers of different sizes causes a warning. To eliminate the warning, the value first needs to be passed between uintptr_t and void *, which are of the same size, and then converted to drm_handle_t. The last part is implicit; the drm_handle_t casts are irrelevant/useless.

Matthew

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#9 lore raw

Re: [PATCH] drm_handle_t type

Quoted 8 lines · Matthew W. S. Bell
Quoted 7 lines · Robert Noland
Quoted 5 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

Quoted 8 lines
Quoted 1 line

drm_handle_t is correct here...

No, drm_handle_t can be of a different size to void *; converting between integers and pointers of different sizes causes a warning. To eliminate the warning, the value first needs to be passed between uintptr_t and void *, which are of the same size, and then converted to drm_handle_t. The last part is implicit; the drm_handle_t casts are irrelevant/useless.

My point being that the casts to drm_handle_t are correct. Feel free to fix linux' define for drm_handle_t.

robert.

Quoted 1 line

Matthew

Signature · 2 lines
Robert Noland <[email protected]>
2Hip Networks
maintainer
#10 lore raw

Re: [PATCH] drm_handle_t type

Quoted 18 lines · Robert Noland
Quoted 8 lines · Matthew W. S. Bell
Quoted 7 lines · Robert Noland
Quoted 5 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

Quoted 8 lines
Quoted 1 line

drm_handle_t is correct here...

No, drm_handle_t can be of a different size to void *; converting between integers and pointers of different sizes causes a warning. To eliminate the warning, the value first needs to be passed between uintptr_t and void *, which are of the same size, and then converted to drm_handle_t. The last part is implicit; the drm_handle_t casts are irrelevant/useless.

Quoted 3 lines

My point being that the casts to drm_handle_t are correct.  Feel free to fix linux' define for drm_handle_t.

Weird the drm is defined on Linux and is considered the standard, and uint32_t is considered correct handle sizing on Linux.

I'm not sure why FreeBSD didn't change to 32-bit handles at the same time, I think nobody wanted to break stuff by accident at the time, assuming FreeBSD maintainers would take care of it.

Dave.

#11 lore raw

Re: [PATCH] drm_handle_t type

Quoted 19 lines · Dave Airlie
Quoted 8 lines · Robert Noland
Quoted 7 lines · Matthew W. S. Bell
Quoted 6 lines · Robert Noland
Quoted 4 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

drm_handle_t is correct here...

Quoted 9 lines
Quoted 6 lines

No, drm_handle_t can be of a different size to void *; converting between integers and pointers of different sizes causes a warning. To eliminate the warning, the value first needs to be passed between uintptr_t and void *, which are of the same size, and then converted to drm_handle_t. The last part is implicit; the drm_handle_t casts are irrelevant/useless.

My point being that the casts to drm_handle_t are correct. Feel free to fix linux' define for drm_handle_t.

Quoted 6 lines

Weird the drm is defined on Linux and is considered the standard, and uint32_t is considered correct handle sizing on Linux.

I'm not sure why FreeBSD didn't change to 32-bit handles at the same time, I think nobody wanted to break stuff by accident at the time, assuming FreeBSD maintainers would take care of it.

drm_handle_t is passed directly to mmap() and on FreeBSD that is expected to be an offset into the device memory. If drm_handle_t were only a handle, this would all be fine, but due to the fact that it's meaning is overloaded and is supposed to represent the KVA as well, it either needs to vary with the architecture or be 64bits... Last time I looked at just making it 64bits everywhere, some minor fixups and API breakage would have been required in the DDX drivers, which was too much trouble to argue about...

The define on FreeBSD is an unsigned long, which works fine on 32/64 bit platforms with current DDX drivers and doesn't produce warnings.

robert.

Quoted 1 line

Dave.

author
#12 lore raw

Re: [PATCH] drm_handle_t type

In reply to Robert Noland
Quoted 18 lines · Robert Noland
Quoted 8 lines · Matthew W. S. Bell
Quoted 7 lines · Robert Noland
Quoted 5 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

Quoted 8 lines
Quoted 1 line

drm_handle_t is correct here...

No, drm_handle_t can be of a different size to void *; converting between integers and pointers of different sizes causes a warning. To eliminate the warning, the value first needs to be passed between uintptr_t and void *, which are of the same size, and then converted to drm_handle_t. The last part is implicit; the drm_handle_t casts are irrelevant/useless.

Quoted 2 lines

My point being that the casts to drm_handle_t are correct. Feel free to fix linux' define for drm_handle_t.

Warnings; warnings. The point is to get rid of the warnings. warnings? Did I mention that when compiling a warning is emitted? Warnings. This code just silences the warnings.

Warnings.
Matthew

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#13 lore raw

Re: [PATCH] drm_handle_t type

In reply to Matthew W. S. Bell
Quoted 8 lines · Matthew W. S. Bell
Quoted 7 lines · Robert Noland
Quoted 5 lines · Matthew W. S. Bell
Quoted 2 lines · Dave Airlie

Its probably not documented well anywhere, though I think the handles are 32-bit is written down somewhere.

Ah sorry, I missed some.

Quoted 8 lines
Quoted 1 line

drm_handle_t is correct here...

No, drm_handle_t can be of a different size to void *; converting between integers and pointers of different sizes causes a warning. To eliminate the warning, the value first needs to be passed between uintptr_t and void *, which are of the same size, and then converted to drm_handle_t. The last part is implicit; the drm_handle_t casts are irrelevant/useless.

No, if you look at the BSD define for drm_handle_t, it does the right thing on each arch. The problem is that the linux define for drm_handle_t is u32.

robert.

Quoted 1 line

Matthew

Signature · 2 lines
Robert Noland <[email protected]>
2Hip Networks
author
#14 lore raw
In reply to Dave Airlie
Quoted 2 lines · Dave Airlie

No, its "designed" as is. We can't change it now as its ABI. We make sure we only use 32-bit handles anyways.

Sorry, the comment about the ABI is, of course, nonsense, as the assumption is implicit in the kernel ABI.

Matthew

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel