Skip to contentSkip to conversation

Make virtio-pci building conditional again

PATCH Applied Alexander Graf 2 participants 2 messages Apr 6, 2010 – Apr 8, 2010 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make virtio-pci building conditional again

Commit b305b9d7d6990e492966ffb1fdf619482adeb7e2 made building of virtio-pci conditional and not enabled on S390x, because it collides with the S390 bus.

Commit 087431d1d1bf4e785edfa89e8cd05fcdac558dc3 accidentially reverted that behavior, breaking S390x again.

So here's a follow-up patch disabling building of virtio-pci on S390x again.

This unbreaks the S390x target.

---
 Makefile.target |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Makefile.target +2 -1
index 45cbe56..2624b1d 100644
@@ -164,7 +164,8 @@ ifdef CONFIG_SOFTMMU
 obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o vl.o
 # virtio has to be here due to weird dependency between PCI and virtio-net.
 # need to fix this properly
-obj-y += virtio-blk.o virtio-balloon.o virtio-net.o virtio-pci.o virtio-serial-bus.o
+obj-y += virtio-blk.o virtio-balloon.o virtio-net.o virtio-serial-bus.o
+obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
 obj-y += event_notifier.o
 obj-y += vhost_net.o
 obj-$(CONFIG_VHOST_NET) += vhost.o
Signature · 1 line
1.6.0.2
#1 lore raw
Quoted 9 lines · Alexander Graf

Commit b305b9d7d6990e492966ffb1fdf619482adeb7e2 made building of virtio-pci conditional and not enabled on S390x, because it collides with the S390 bus.

Commit 087431d1d1bf4e785edfa89e8cd05fcdac558dc3 accidentially reverted that behavior, breaking S390x again.

So here's a follow-up patch disabling building of virtio-pci on S390x again.

This unbreaks the S390x target.

Thanks, applied.

Quoted 25 lines
---
 Makefile.target |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Makefile.target +2 -1
index 45cbe56..2624b1d 100644
@@ -164,7 +164,8 @@ ifdef CONFIG_SOFTMMU
 obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o vl.o
 # virtio has to be here due to weird dependency between PCI and virtio-net.
 # need to fix this properly
-obj-y += virtio-blk.o virtio-balloon.o virtio-net.o virtio-pci.o virtio-serial-bus.o
+obj-y += virtio-blk.o virtio-balloon.o virtio-net.o virtio-serial-bus.o
+obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
 obj-y += event_notifier.o
 obj-y += vhost_net.o
 obj-$(CONFIG_VHOST_NET) += vhost.o
Signature · 1 line
1.6.0.2
Signature · 2 lines
Aurelien Jarno                          GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net