fs/btrfs: Avoid possible NULL pointer dereference for fs_devices

PATCH New Harshavardhana 1 participant 1 message Apr 8, 2010 Btrfs file system

lore

Share & tools

lore

Harshavardhana

author

2010-04-08 01:24 UTC #0 lore raw

PATCH 1/1 fs/btrfs: Avoid possible NULL pointer dereference for fs_devices

loop is never traversed for fs_devices NULL in volumes.c

<snip>
while (fs_devices) {
.........
....... }
</snip>

Dereferencing happens right after, in this case over NULL pointer.

Signed-off-by Harshavardhana <[email protected]>

---
 fs/btrfs/volumes.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

fs/btrfs/volumes.c +2 -1

index b584e9a..e3d2e6b 100644
@@ -1261,7 +1261,8 @@ int btrfs_rm_device(struct btrfs_root *root, char *device_path)
 				break;
 			fs_devices = fs_devices->seed;
 		}
-		fs_devices->seed = device->fs_devices->seed;
+                if (fs_devices)
+                        fs_devices->seed = device->fs_devices->seed;
 		device->fs_devices->seed = NULL;
 		__btrfs_close_devices(device->fs_devices);
 		free_fs_devices(device->fs_devices);

Signature · 1 line

1.6.6.1