Skip to contentSkip to conversation

ppc4xx: alpr: Remove some not needed commands to make image fit again

PATCH New Stefan Roese 2 participants 4 messages Apr 8, 2010 – Apr 14, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: alpr: Remove some not needed commands to make image fit again

The latest changes increased the size of the alpr image a bit more. Now it doesn't fit into the 256k reserved for it. This patch now removes the commands "loads" and "loadb" which are not needed in the production systems.

Cc Pieter Voorthuijsen <[email protected]>
---
 include/configs/alpr.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
include/configs/alpr.h +3 -1
index f2392f6..ee0c14d 100644
@@ -236,11 +236,13 @@
 #define CONFIG_CMD_EEPROM
 #define CONFIG_CMD_FPGA
 #define CONFIG_CMD_I2C
+#undef CONFIG_CMD_LOADB
+#undef CONFIG_CMD_LOADS
 #define CONFIG_CMD_MII
 #define CONFIG_CMD_NAND
 #define CONFIG_CMD_NET
-#define CONFIG_CMD_PCI
 #undef CONFIG_CMD_NFS
+#define CONFIG_CMD_PCI
 
 #undef CONFIG_WATCHDOG			/* watchdog disabled		*/
 
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 ppc4xx: alpr: Remove some not needed commands to make image fit again

Hi Stefan,

Quoted 4 lines

The latest changes increased the size of the alpr image a bit more. Now it doesn't fit into the 256k reserved for it. This patch now removes the commands "loads" and "loadb" which are not needed in the production systems.

I see that PCI is also enabled again. This is not used and can be turned off. Otherwise I think we'll see this 'won't fit' message again in a few months. :)

Quoted 26 lines
Cc Pieter Voorthuijsen <[email protected]>
---
 include/configs/alpr.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
include/configs/alpr.h +3 -1
index f2392f6..ee0c14d 100644
@@ -236,11 +236,13 @@
 #define CONFIG_CMD_EEPROM
 #define CONFIG_CMD_FPGA
 #define CONFIG_CMD_I2C
+#undef CONFIG_CMD_LOADB
+#undef CONFIG_CMD_LOADS
 #define CONFIG_CMD_MII
 #define CONFIG_CMD_NAND
 #define CONFIG_CMD_NET
-#define CONFIG_CMD_PCI
 #undef CONFIG_CMD_NFS
+#define CONFIG_CMD_PCI
 
 #undef CONFIG_WATCHDOG			/* watchdog 

disabled */

Quoted 4 lines

--
1.7.0.4

Disclaimer: The information contained in this email, including any attachments is confidential and is for the sole use of the intended recipient(s). Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please notify the sender immediately by replying to this message and destroy all copies of this message and any attachments.

#2 lore raw

PATCH 1/1 ppc4xx: alpr: Remove some not needed commands to make image fit again

Hi Pieter,

I didn't hear from you for a long time. Hope you are doing well and business is good for Prodrive as always.

Quoted 8 lines · On Thursday 08 April 2010 09:37:05 Pieter Voorthuijsen wrote:
Quoted 4 lines

The latest changes increased the size of the alpr image a bit more. Now it doesn't fit into the 256k reserved for it. This patch now removes the commands "loads" and "loadb" which are not needed in the production systems.

I see that PCI is also enabled again. This is not used and can be turned off. Otherwise I think we'll see this 'won't fit' message again in a few months. :)

Has PCI support been disabled at some time? Not sure. I'm hesitating to make such a change without testing it on real hardware. Please feel free to test it and send an addon patch to the list.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#3 lore raw

PATCH 1/1 ppc4xx: alpr: Remove some not needed commands to make image fit again

In reply to Stefan Roese
Quoted 4 lines · On Thursday 08 April 2010 09:34:05 Stefan Roese wrote:

The latest changes increased the size of the alpr image a bit more. Now it doesn't fit into the 256k reserved for it. This patch now removes the commands "loads" and "loadb" which are not needed in the production systems.

Applied to u-boot-ppc4xx/master. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de